Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2274243rdb; Mon, 20 Nov 2023 06:56:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrXcFofXjC+v6MEu0P35GB1R6yLKw30jP0+9TUTyaPqg6CfTw+XM2tMHJ+bX7ficmZJG9G X-Received: by 2002:a05:6808:2f12:b0:3a4:894a:9f3d with SMTP id gu18-20020a0568082f1200b003a4894a9f3dmr9652704oib.41.1700492162990; Mon, 20 Nov 2023 06:56:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700492162; cv=none; d=google.com; s=arc-20160816; b=qobPp/bepJ31NW1lTV1tElt9xSrK9/TsGa4Jzm+yMZ/Z7qFZ9e3qPUiWoOCV+Y4T6/ 3qH9PTI7g8ntjVoZC4Pqr4yz5L13rLal5TUKkPbP7JnVJbw9tlBdiaN62kfTgWgmtLXh om5rkuvnd4c/ZvEAHaao62nmf1aWFHv2wZPA1UDk3srq3/rQr9zHTKOgPxTD2K1VKt33 rKwjfQT2vCkJAQhD/PMw9Q/EubJIUEwRJRdWDwehSA4+ZP/+gsZiwEu1jytUSfCEa2Ks yd5baHoPXemcQ2CiLjlbXKnxeqj0jrK6WG+b4tk6jdi5bw75kCkIcRavNqsAfAAdT8lb wJAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tJGXPcQlrfiaKM9DCGHJI4xttqf5Maw6yauIyx3L7og=; fh=16z9eSgr+T6wkiFTMo20mXPHGWzPIsCuS8kXeZ8Bzu4=; b=DTeUFqUr9v75BhqHLmT3I1Eyf7R5oBnWFoCVCw19YfM/WZ8KUPe3ZEIIPsgZ9JQDmS uzxFelPvmQiUkqrzkjKnyGvCL9UBPCb58kibi64MJS9E5VGGHKWdGxF9rga1dtZ1yvHC 1vwYCA5nx+E/kNgnBM3csL1gPtnwVZvRQN672DGeMHBOYqqyaaS8ORwyjx0njhJHJtfw oJ8OnzaJlyIks3d9kn1w5eSV0BqBbxdZlU4Wc0btGifvqjawfFSiZ6Cf9RzSMd2ZSMPh G/DhlqY7NB2RoZDrrPPqcQoLPe+gwTgUCJrL1O1KLHlfdA83igqAqtWn3iPh4PIfbXfw vZ7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=iFLIJnn7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id o5-20020a656145000000b00577475ee5f6si7820353pgv.618.2023.11.20.06.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:56:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=iFLIJnn7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3DBA18032F8C; Mon, 20 Nov 2023 06:55:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234156AbjKTOzG (ORCPT + 99 others); Mon, 20 Nov 2023 09:55:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233980AbjKTOyo (ORCPT ); Mon, 20 Nov 2023 09:54:44 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 025AC1FDF; Mon, 20 Nov 2023 06:54:18 -0800 (PST) Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AKECBIx024464; Mon, 20 Nov 2023 14:54:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=tJGXPcQlrfiaKM9DCGHJI4xttqf5Maw6yauIyx3L7og=; b=iFLIJnn7iSsPOgEVFaaDvNL3ROX/60yglT7SNZh8mDLBznzlc6Tsv1+/1V9CrdrXap7V ZwFN0XoW43tU124psuQKPjy9mWMT0Uk1hLlx2NWMNAee2ZmgTs4s3MpFRapoL4/jm3Md V6rru4KlzEfZZnTtucphPNHbRthQvFII2HT1CfRtE+GFKU5nRaqSvmaTU1z6Lssjrpe+ 5J1cRLkUkBSHua2DKxrQzr2wODsKH5NJtCMyeBIfGb2C3KMi7R1XUWGS6rI604tipI3k GAVC81Rwh5kZoEHYWktea8QrL3Ru5QN9brBxDRkAtVFUzyeXxJmQxw50FfQrKGRr0rQj 9A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug90t982m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 14:54:07 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AKEFgXm026050; Mon, 20 Nov 2023 14:54:06 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug90t9827-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 14:54:06 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AKDUSex012325; Mon, 20 Nov 2023 14:54:05 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ufaa1sa80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 14:54:05 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AKEs2q55636628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Nov 2023 14:54:02 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D6F320049; Mon, 20 Nov 2023 14:54:02 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 379C220040; Mon, 20 Nov 2023 14:54:02 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 20 Nov 2023 14:54:02 +0000 (GMT) From: Sumanth Korikkar To: linux-mm , Andrew Morton , David Hildenbrand Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: [PATCH v3 0/3] mm/memory_hotplug: fixes for memory hotplug altmap support Date: Mon, 20 Nov 2023 15:53:51 +0100 Message-Id: <20231120145354.308999-1-sumanthk@linux.ibm.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vNLsWdaKUlNcM2YGGxNnjVQpROYb0apB X-Proofpoint-ORIG-GUID: 5HnGJsbBK53So67xcGdvZf2YEb0C5Kly X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_14,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 malwarescore=0 mlxlogscore=573 adultscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311200103 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:55:24 -0800 (PST) Patch 1 adds the missing lock in memory hotplug operations, ensuring that the mem_hotplug_lock is held during critical operations like mhp_init_memmap_on_memory() and mhp_deinit_memmap_on_memory() Patch 2 deals with error handling in add_memory_resource() and considers the possibility of altmap support. This ensures proper deallocation of struct pages, aligning with the allocation strategy. Patch 3 relocates the vmem_altmap code to sparse-vmemmap.c, enabling the utilization of vmem_altmap_free() and vmem_altmap_offset() without the dependency on CONFIG_ZONE_DEVICE. v3: * added Acked-by in patch 3. * added cc: stable@vger.kernel.org to commit messages (both patch 1 and patch 2), as reported by patch-bot. v2: * cc: stable@vger.kernel.org * make vmem_altmap_offset()/vmem_altmap_free() inline. * added Acked-by for patch 1 and patch 2. v1: Changes since patch series "implement "memmap on memory" feature on s390": Feedback from David: Patch 1: * Fixed subject for memory hotplug lock. * Added locking comments before memory_block_online()/memory_block_offline(). Patch 2: * Fixed Fixes-by commit. lkp report: Patch 3: * when CONFIG_SPARSEMEM_VMEMMAP is disabled, resolve undefined reference to `vmem_altmap_offset' error. * Request for Reviewed-by once again due to the change in patch3. Thank you Sumanth Korikkar (3): mm/memory_hotplug: add missing mem_hotplug_lock mm/memory_hotplug: fix error handling in add_memory_resource() mm: use vmem_altmap code without CONFIG_ZONE_DEVICE drivers/base/memory.c | 18 +++++++++++++++--- include/linux/memremap.h | 12 ------------ include/linux/mm.h | 26 ++++++++++++++++++++++++++ mm/memory_hotplug.c | 15 +++++++-------- mm/memremap.c | 14 +------------- 5 files changed, 49 insertions(+), 36 deletions(-) -- 2.41.0