Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2275860rdb; Mon, 20 Nov 2023 06:59:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHwIY8hYgRlitJfYcErRnAZEWGKRx6Fb83JbXsPuwQQynAWMlT2wxAPkQu2gIgk3pi4r2RO X-Received: by 2002:a17:902:e890:b0:1cf:6945:7573 with SMTP id w16-20020a170902e89000b001cf69457573mr822516plg.29.1700492351029; Mon, 20 Nov 2023 06:59:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700492351; cv=none; d=google.com; s=arc-20160816; b=PlK7V5e0xfW/NWcSXGzHij8iIpNvXQKBf4iuLcJlP6rDMmkPfSgGl0Cx+QKrmSARcn az7U2mNIawQDLVmOc9+TIi+73pS4RKRb1ZHRj/g7+MZEZ9hRdShnX7R5njyQK/q5d3Dy wiqpf4Jccz0Os74zdQ+YdFZq0B5RHj8fXv6KCg6xOUy3+RYgDa64HgadH69/lWbY7Wso 3/Vsns2ugnpLBF0upalhMEdVlwef6FXELBeoqzTEY/63VtyliGYSJn/c4JcM905UTzY5 ZYtauLDQR9YHGBfCg1v8s7RzGLxtPthbaO074EXioBx86MxUquwI2rQcqsd6uqyo87Qv B+XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=8+wd4QKLZbQgoejuATdhtqqFo6wKaCpRdP9UyoZGxKQ=; fh=1Ivk8ZYEui9VJI4FcLmN5yNukgF2i0mouO56iDXEBg0=; b=WkPQbFQXT7EAnhyc+bbB96ZW1CVWnZo2p/2b73cE9tES2W1hTW6WeuPt/Retx6VLwC /onPwrmIjThKWTndaYb0O0jk7T+Gn5BF4AcBDO0wIh4Vw6iZcv0ueUS7awc44u7Sk8kR 79nuS+TQco43A/9HHTBHDnb1HhJ2/sLtMFmSvD19pIn2mFA6/tkjThcrV3NhtspSXZsv dOc2VYDD9Xtpi1LiWpqlTz5a0+Q9iZJH1JiziOCdB+Ve9TqaNKEDh79FFkJMstItfzxr ImsRZKdWN4vytQjTFvU4qTggH6lT2B1XgfN5BttcttJk0tVjLJxnI+yK1kessrzsWgL2 gDNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rWLKJ9PR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id q20-20020a170902789400b001bb792749a2si7667093pll.146.2023.11.20.06.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:59:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rWLKJ9PR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BDCC58061C13; Mon, 20 Nov 2023 06:59:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233973AbjKTO63 (ORCPT + 99 others); Mon, 20 Nov 2023 09:58:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233785AbjKTO62 (ORCPT ); Mon, 20 Nov 2023 09:58:28 -0500 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACE6BBE for ; Mon, 20 Nov 2023 06:58:23 -0800 (PST) Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-d9c66e70ebdso4069281276.2 for ; Mon, 20 Nov 2023 06:58:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700492303; x=1701097103; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8+wd4QKLZbQgoejuATdhtqqFo6wKaCpRdP9UyoZGxKQ=; b=rWLKJ9PRnrE+D5neCiFKNP1gEbhdIaPTGN53+lnnglRPB6MjjkiT567zjRtrf8QsQs O0yqWn/NlM5gezowJ3oMexcA1lo2o/4t64kSrvxQjr1cBp6jVClAQbl3jW0I42ytN151 oYCIdHI0aLsBzmmv7yN2t6hLMJsusuVzgeIwmAAlzC0K8e3dePbMv2AJ01Cze/OZ9ORn ByAtGinl4ncMnKHihJY33iADKN4SEjexR23VaZhv5LqAnZ114D5hvDyZSWH0APw2gO4J 3W0LR1cH9IhOWohseA7dYakd6lc6N6PxtaoTBCcd0q16+LbRipRRXgRt3VUuI2j6skyp O7KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700492303; x=1701097103; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8+wd4QKLZbQgoejuATdhtqqFo6wKaCpRdP9UyoZGxKQ=; b=ktrZ5Kf6EIgf/bwKtLU/r2XhTTHBxD7UKmm1guhsPXZqB85yRbjJjWj1Q4TZJROVP+ WEMO5yy/g4/w3G+1hjBdUI4VITKCNfLgBRvkqcU5VpRwNBL+Byg/2mHDqK1AegU47FCY QHXYjJKfxWUNxYe8D8zcdxD6pW3lCE5GQU+4hAVIroMRMSRcSIzPrjsYFgeYBYqDM0up x6J+2TDfaM2RHFa69gjyZCcXLZnB2VpQW4F1w9t8oS2Za6gorPY6MQHKl4Cy7BKtiPhg Hb5SU2X+GUviiBkh2PMV6YkWw+R2lSB7bM6v93NM/zFcGMpvvLoYon0w0d+wUtt9lvJ5 edHA== X-Gm-Message-State: AOJu0YxTWIELIbptd/Agm1JiWzj46fUE774bRG1K7vC/INHbwn6IsoIk 3WJg5BzmByA1SFzeAjY2J0BXGGEzDJKwPWzu/A9+3Q== X-Received: by 2002:a25:dc01:0:b0:da0:c5eb:a6c6 with SMTP id y1-20020a25dc01000000b00da0c5eba6c6mr6388057ybe.32.1700492302820; Mon, 20 Nov 2023 06:58:22 -0800 (PST) MIME-Version: 1.0 References: <20231120134754.9526-1-quic_kbajaj@quicinc.com> <20231120134754.9526-4-quic_kbajaj@quicinc.com> In-Reply-To: <20231120134754.9526-4-quic_kbajaj@quicinc.com> From: Dmitry Baryshkov Date: Mon, 20 Nov 2023 16:58:11 +0200 Message-ID: Subject: Re: [PATCH v5 3/3] arm64: dts: qcom: Add base qcs6490-rb3gen2 board dts To: Komal Bajaj Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Naina Mehta Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:59:02 -0800 (PST) On Mon, 20 Nov 2023 at 15:48, Komal Bajaj wrote: > > Add DTS for Qualcomm qcs6490-rb3gen2 board which uses > QCS6490 SoC. This adds debug uart and usb support along > with regulators found on this board. > > Co-developed-by: Naina Mehta > Signed-off-by: Naina Mehta > Signed-off-by: Komal Bajaj > Reviewed-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 410 +++++++++++++++++++ > 2 files changed, 411 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 77babebe4904..4c0f9e4a2e5b 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -90,6 +90,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcm6490-fairphone-fp5.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcm6490-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qcs6490-rb3gen2.dtb > dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += qrb2210-rb1.dtb > dtb-$(CONFIG_ARCH_QCOM) += qrb4210-rb2.dtb > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > new file mode 100644 > index 000000000000..f023dcf768f1 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -0,0 +1,410 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +/* PM7250B is configured to use SID8/9 */ > +#define PM7250B_SID 8 > +#define PM7250B_SID1 9 > + > +#include > +#include "sc7280.dtsi" > +#include "pm7250b.dtsi" > +#include "pm7325.dtsi" > +#include "pm8350c.dtsi" > +#include "pmk8350.dtsi" > + > +/delete-node/ &ipa_fw_mem; > +/delete-node/ &remoteproc_mpss; > +/delete-node/ &rmtfs_mem; > +/delete-node/ &video_mem; > +/delete-node/ &wlan_ce_mem; > +/delete-node/ &xbl_mem; > + > +/ { > + model = "Qualcomm Technologies, Inc. Robotics RB3gen2"; > + compatible = "qcom,qcs6490-rb3gen2", "qcom,qcm6490"; > + chassis-type = "embedded"; > + > + aliases { > + serial0 = &uart5; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; The board definitely has some fixed-voltage regulators. At least the vph-pwr. Please describe them here. > + > + reserved-memory { > + xbl_mem: xbl@80700000 { > + reg = <0x0 0x80700000 0x0 0x100000>; > + no-map; > + }; > + > + cdsp_secure_heap_mem: cdsp-secure-heap@81800000 { > + reg = <0x0 0x81800000 0x0 0x1e00000>; > + no-map; > + }; > + > + camera_mem: camera@84300000 { > + reg = <0x0 0x84300000 0x0 0x500000>; > + no-map; > + }; > + > + wpss_mem: wpss@84800000 { > + reg = <0x0 0x84800000 0x0 0x1900000>; > + no-map; > + }; > + > + adsp_mem: adsp@86100000 { > + reg = <0x0 0x86100000 0x0 0x2800000>; > + no-map; > + }; > + > + cdsp_mem: cdsp@88900000 { > + reg = <0x0 0x88900000 0x0 0x1e00000>; > + no-map; > + }; > + > + video_mem: video@8a700000 { > + reg = <0x0 0x8a700000 0x0 0x700000>; > + no-map; > + }; > + > + cvp_mem: cvp@8ae00000 { > + reg = <0x0 0x8ae00000 0x0 0x500000>; > + no-map; > + }; > + > + ipa_fw_mem: ipa-fw@8b300000 { > + reg = <0x0 0x8b300000 0x0 0x10000>; > + no-map; > + }; > + > + ipa_gsi_mem: ipa-gsi@8b310000 { > + reg = <0x0 0x8b310000 0x0 0xa000>; > + no-map; > + }; > + > + gpu_microcode_mem: gpu-microcode@8b31a000 { > + reg = <0x0 0x8b31a000 0x0 0x2000>; > + no-map; > + }; > + > + tz_stat_mem: tz-stat@c0000000 { > + reg = <0x0 0xc0000000 0x0 0x100000>; > + no-map; > + }; > + > + tags_mem: tags@c0100000 { > + reg = <0x0 0xc0100000 0x0 0x1200000>; > + no-map; > + }; > + > + qtee_mem: qtee@c1300000 { > + reg = <0x0 0xc1300000 0x0 0x500000>; > + no-map; > + }; > + > + trusted_apps_mem: trusted_apps@c1800000 { > + reg = <0x0 0xc1800000 0x0 0x1c00000>; > + no-map; > + }; > + > + debug_vm_mem: debug-vm@d0600000 { > + reg = <0x0 0xd0600000 0x0 0x100000>; > + no-map; > + }; > + }; > +}; > + > +&apps_rsc { > + regulators-0 { > + compatible = "qcom,pm7325-rpmh-regulators"; > + qcom,pmic-id = "b"; No supplies for any of the regulators? That's a pity. > + > + vreg_s1b_1p872: smps1 { > + regulator-min-microvolt = <1840000>; > + regulator-max-microvolt = <2040000>; > + }; > + > + vreg_s2b_0p876: smps2 { > + regulator-min-microvolt = <570070>; > + regulator-max-microvolt = <1050000>; > + }; > + > + vreg_s7b_0p972: smps7 { > + regulator-min-microvolt = <535000>; > + regulator-max-microvolt = <1120000>; > + }; > + > + vreg_s8b_1p272: smps8 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1500000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l1b_0p912: ldo1 { > + regulator-min-microvolt = <825000>; > + regulator-max-microvolt = <925000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l2b_3p072: ldo2 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l3b_0p504: ldo3 { > + regulator-min-microvolt = <312000>; > + regulator-max-microvolt = <910000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l4b_0p752: ldo4 { > + regulator-min-microvolt = <752000>; > + regulator-max-microvolt = <820000>; > + regulator-initial-mode = ; > + }; > + > + reg_l5b_0p752: ldo5 { > + regulator-min-microvolt = <552000>; > + regulator-max-microvolt = <832000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l6b_1p2: ldo6 { > + regulator-min-microvolt = <1140000>; > + regulator-max-microvolt = <1260000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l7b_2p952: ldo7 { Voltage ranges must be added here. > + regulator-allow-set-load; > + regulator-allowed-modes = ; > + regulator-initial-mode = ; > + }; > + > + vreg_l8b_0p904: ldo8 { > + regulator-min-microvolt = <870000>; > + regulator-max-microvolt = <970000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l9b_1p2: ldo9 { Voltage ranges must be added here. > + regulator-allow-set-load; > + regulator-allowed-modes = ; > + regulator-initial-mode = ; > + }; > + > + vreg_l11b_1p504: ldo11 { > + regulator-min-microvolt = <1504000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l12b_0p751: ldo12 { > + regulator-min-microvolt = <751000>; > + regulator-max-microvolt = <824000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l13b_0p53: ldo13 { > + regulator-min-microvolt = <530000>; > + regulator-max-microvolt = <824000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l14b_1p08: ldo14 { > + regulator-min-microvolt = <1080000>; > + regulator-max-microvolt = <1304000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l15b_0p765: ldo15 { > + regulator-min-microvolt = <765000>; > + regulator-max-microvolt = <1020000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l16b_1p1: ldo16 { > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l17b_1p7: ldo17 { > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1900000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l18b_1p8: ldo18 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l19b_1p8: ldo19 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; > + }; > + }; > + > + regulators-1 { > + compatible = "qcom,pm8350c-rpmh-regulators"; > + qcom,pmic-id = "c"; > + > + vreg_s1c_2p19: smps1 { > + regulator-min-microvolt = <2190000>; > + regulator-max-microvolt = <2210000>; > + }; > + > + vreg_s2c_0p752: smps2 { > + regulator-min-microvolt = <750000>; > + regulator-max-microvolt = <800000>; > + }; > + > + vreg_s5c_0p752: smps5 { > + regulator-min-microvolt = <465000>; > + regulator-max-microvolt = <1050000>; > + }; > + > + vreg_s7c_0p752: smps7 { > + regulator-min-microvolt = <465000>; > + regulator-max-microvolt = <800000>; > + }; > + > + vreg_s9c_1p084: smps9 { > + regulator-min-microvolt = <1010000>; > + regulator-max-microvolt = <1170000>; > + }; > + > + vreg_l1c_1p8: ldo1 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1980000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l2c_1p62: ldo2 { > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <1980000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l3c_2p8: ldo3 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3540000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l4c_1p62: ldo4 { > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <3300000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l5c_1p62: ldo5 { > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <3300000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l6c_2p96: ldo6 { > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l7c_3p0: ldo7 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l8c_1p62: ldo8 { > + regulator-min-microvolt = <1620000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l9c_2p96: ldo9 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <35440000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l10c_0p88: ldo10 { > + regulator-min-microvolt = <720000>; > + regulator-max-microvolt = <1050000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l11c_2p8: ldo11 { > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l12c_1p65: ldo12 { > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l13c_2p7: ldo13 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = ; > + }; > + > + vreg_bob_3p296: bob { > + regulator-min-microvolt = <3008000>; > + regulator-max-microvolt = <3960000>; > + }; > + }; > +}; > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <32 2>, /* ADSP */ > + <48 4>; /* NFC */ > +}; > + > +&uart5 { > + compatible = "qcom,geni-debug-uart"; > + status = "okay"; > +}; > + > +&usb_1 { > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + dr_mode = "peripheral"; > +}; > + > +&usb_1_hsphy { > + vdda-pll-supply = <&vreg_l10c_0p88>; > + vdda33-supply = <&vreg_l2b_3p072>; > + vdda18-supply = <&vreg_l1c_1p8>; > + > + status = "okay"; > +}; > + > +&usb_1_qmpphy { > + vdda-phy-supply = <&vreg_l6b_1p2>; > + vdda-pll-supply = <&vreg_l1b_0p912>; > + > + status = "okay"; > +}; > + > +&wifi { > + memory-region = <&wlan_fw_mem>; Same question regarding the CE region. > +}; > -- > 2.42.0 > > -- With best wishes Dmitry