Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 20 Nov 2023 10:43:52 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     dan.carpenter@linaro.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        maple-tree@lists.infradead.org
Subject: Re: [PATCH v2 0/5] Some cleanups of maple tree
Message-ID: <20231120154352.z2cn5vgllprnnkko@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>, dan.carpenter@linaro.org,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, maple-tree@lists.infradead.org
References: <20231120070937.35481-1-zhangpeng.00@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231120070937.35481-1-zhangpeng.00@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0XDi/fPQKRdkGBgvUQsHtK76CuGtPqaMa6vWmBA5yV90SFO8lPf3MVCyVUGs?=
 =?us-ascii?Q?IPCb36t/oLzAMG5Asw0CLwi4wq+zo4NsmXkNUfne2Bdlcs405MjhZy+QdisK?=
 =?us-ascii?Q?Lb1363AV4/PK4UT5gt/lPv4btiRCXkAxVYYed99VsPVb3xNNE0ui4bts+iR5?=
 =?us-ascii?Q?sQa4m9WYNexWIgbdHU6+TTh8ZEOjO4Gqs7wt0yRrntgB7HVdgkEGeFb6J6XB?=
 =?us-ascii?Q?srNXsaebfskPBlJqti4PEut1FLZLRJ93ubAwQCUgV8FhvG1exmlVXAXps3gU?=
 =?us-ascii?Q?Mx4LwRRTXsIty7vN4bhZohQjgpDg0Ka7g0xJKWKUpJgU0vBgtHEn/iAB1ynC?=
 =?us-ascii?Q?wCMvWTUTqwzSYv8nrL6mQmVGKj1j/XIyrFBL8Sg1b24ydAqvUHBsOpP31gQ3?=
 =?us-ascii?Q?+tUJ+evZDO/0XR6+iXwJ84kv49U6h6eHdqH99YRYzKoiPrNsoURawkOgz5xU?=
 =?us-ascii?Q?iB2S0a2cu798flRbgHSnnF6j5Q4O4Y9DovrS+NHXKFwjGMSqhHGmiaSU/FKM?=
 =?us-ascii?Q?zq1jga2sO2cP6xRL3YP4azN9JKrpDJ9bzYq+ua9TnP2S2redQ9gFnV3kKwux?=
 =?us-ascii?Q?w6Hq1QWN6o+F4XVkfrS0XP7ekVjdL1zNG+767/qJsSYNads+fqREx1MxEbed?=
 =?us-ascii?Q?h/KUzLTJaA7i0SE+huOCWEgK/KxOppdOyOom+fq46DYAPRmYJJFvZT2X+cMR?=
 =?us-ascii?Q?OFuYv2URKGi1oXz02f0wkpn0PUppYnOowLQhIneoZR+yba+iKY5+PJmXn30Z?=
 =?us-ascii?Q?VuC99fSxryBsdMz0DUSuFj3wnMNdQGgRaRrdgjWuLa+5w/C7WiX2tJuLno8+?=
 =?us-ascii?Q?VDz5nlFleUjSQlyQsFj0D5B7njfW5XRcOlUc0gVG26PYjJGZRowHgndr70JP?=
 =?us-ascii?Q?MHXBI7gEGVJjodQFvU/mTXYbBHBUWA9kc9W6FqTUKXgmKv6RL+emC7z407A7?=
 =?us-ascii?Q?eoQIu2G032tnY7npRibzBLg4gwApjvG2n65hLD+AoFmOVljNS0kXCt4HDSe/?=
 =?us-ascii?Q?jNI7k+7yLuK4UpnSL/RQhKp3fUIlZ20Y1yXYNwnfdFI61YWFdZ5ncXxvzwHV?=
 =?us-ascii?Q?bqBTXn+nsESnpezpzzW/QI0HhRu3/hkMb440GK9GUESxcLsYN63ZuvmGQ8nB?=
 =?us-ascii?Q?ZeSg4xMRjFl6eb+uWb4qGLyUXyHXrZQrVvkGvVRSwrxbHFAQsgbtuRSSPwzT?=
 =?us-ascii?Q?yo3Qg+NGlMd5P1tZYn7roFvmAnWSmfHF84hng/QBGnF/xbXrxfatW2p8gJet?=
 =?us-ascii?Q?y/5GE5AWejxZjRXXAx/fE9Qov5MrIB7leXGP7fU8atKTzfkx2UoYvX2Kizo0?=
 =?us-ascii?Q?6Mgbpn3oI7OYBiBOJCNeHkSZKXB5l+g2EA1YKbkQVTeqf/rX2zAf3ZgeKx6G?=
 =?us-ascii?Q?cLvkebAoe+vVb9H3bZMXjlzMNnBB+pUg9fw9ESwsIaemN2+NcenR8tyUb4f7?=
 =?us-ascii?Q?q3gvnI07ftwA/MhwvXATjk4Lnd7eVwNdPv84Wu6gEw/DcTYapSM0Z/BzoIdv?=
 =?us-ascii?Q?lqO0Mnjj7o2W5ezez8/h7zivO9fwcigzhzZtx+Lw75nFmUNvfvMuIO6y98BZ?=
 =?us-ascii?Q?mX0ruxJRs8iwoOSNmUt61f9h5Wireb8UCXALnlW1?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?CqbyvaEOa087EEcOQZfIzTwX+1oYWhjr5sjvdBJP7SMyUefDZBTxQYmP1NfQ?=
 =?us-ascii?Q?LIrYgf7oRjFmYgjOex8YpLbUC+gYwgw7TsG09MrXdAFRmXjaYLD/MpAIe7GU?=
 =?us-ascii?Q?CMHvaZ0o22d9eZXgO+myU2lJepDJx4HjjDfl2ly9dciRI9ePG6O3tp1Rq4Xf?=
 =?us-ascii?Q?IpjiQOLtqCqDdQIDp9wbZEL9rWdYjGTyrF4Apes6Jd4HnsiKJodKPDZVggQg?=
 =?us-ascii?Q?wEYG8pIpc4mWkzLxGX4szSyboW6279ZQAXSfuIJuWraDd5lseLurHGgnc5MX?=
 =?us-ascii?Q?fm2iMxhHGf7lV0lpMzQTDKbDO8DqTi2jX8R6YFGLnofRXm0D4GuENhitWH84?=
 =?us-ascii?Q?pRRbMlN/OGbP6z3svq6E9QLzX2wyuO47ixruChj5wNPkpBwDtWDVEGa4R0cc?=
 =?us-ascii?Q?hmWtw4k7tw1bohIHpxGJhHrq4LUIVwMegwziGW/kzcKCe6piPS4VjF9xhwTW?=
 =?us-ascii?Q?87huzWnNRG7vBHoCMUizVXvNSud/kJo/UsvvjIkY8DkbH+JpT+9QlqJJHIt0?=
 =?us-ascii?Q?i+ht3abqQa2hEfUclfvLxaDc/GcNsmUHT8y34PFGA7PrS//1EgBXr+RmyDAP?=
 =?us-ascii?Q?cLIdRma+aSLJux0bOjjSBaTSl6UQk8xm4z5TAldDFiRR/dQAiOI6wm4BRinQ?=
 =?us-ascii?Q?4g0xryf12RpF4SjksXEskq9dDrSNLT6SjHoPMRHpx5hzlgJJnshTxc2UzQZl?=
 =?us-ascii?Q?w0JrLlnUAzDn2QN/3c/yY17CQ6kQSM/pf6vIh3VtipPfSaGxUjLfvJxfdDxk?=
 =?us-ascii?Q?CXdExwjEWINERdyRSUAP8pMgSJ9g/txkA4TNWSUjdTuxcgXQVH7nQH37mW0k?=
 =?us-ascii?Q?b03lFZsFg2qhysdtBVYejO++tykTBGMC+YSLBbRPNUQaDsxFKE1NcViatH/6?=
 =?us-ascii?Q?o9eNcDJR8Rnr28E4YbRpdz08a1FdwtQhydTMGTNMIsVbXV9xgkync02frum1?=
 =?us-ascii?Q?pFH+5rZE2CXLI+hoYk5NZQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bd5b9910-a713-4545-1e22-08dbe9df80b3
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 15:43:55.1208
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gjevmt+RltgAUtaC10gQ3nig/2X25uqmTW+U1QMOJ/oKAegCQH+0ByH8rFQxwjUNwqM3VhYFzCG1yUYrmtuf8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5288
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-20_16,2023-11-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2311200110
X-Proofpoint-GUID: Mt2bryQTEg662mBIebYB3SqvbQdp7prs
X-Proofpoint-ORIG-GUID: Mt2bryQTEg662mBIebYB3SqvbQdp7prs
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 20 Nov 2023 07:45:33 -0800 (PST)

* Peng Zhang <zhangpeng.00@bytedance.com> [231120 02:09]:
> These are some small cleanups of maple tree.
> 
> Just to mention, in v1, I forgot to CC LKML, but it has been added in this
> version.
> 
> Changes since v1:
>   - Removed the 'return' statement from [1/5].
>   - Made slight modifications to the commit log of [5/5].
> 
> v1: http://lists.infradead.org/pipermail/maple-tree/2023-November/003047.html

Thanks, they all look good now.

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> 
> Peng Zhang (5):
>   maple_tree: Move the check forward to avoid static check warning
>   maple_tree: Avoid ascending when mas->min is also the parent's minimum
>   maple_tree: Remove an unused parameter for ma_meta_end()
>   maple_tree: Delete one of the two identical checks
>   maple_tree: Simplify mas_leaf_set_meta()
> 
>  lib/maple_tree.c | 45 ++++++++++++++-------------------------------
>  1 file changed, 14 insertions(+), 31 deletions(-)
> 
> -- 
> 2.20.1
>