Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 20 Nov 2023 15:54:14 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Maciej Strozek <mstrozek@opensource.cirrus.com>
Cc:     James Schulman <james.schulman@cirrus.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
        linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ASoC: cs43130: Allow driver to work without IRQ
 connection
Message-ID: <c031657a-a1ec-44eb-8885-afee68d7523b@sirena.org.uk>
References: <20231120141734.76679-1-mstrozek@opensource.cirrus.com>
 <7248897a-0b59-4cdc-9915-d3297f2d6efe@sirena.org.uk>
 <261e118d-529b-0ce0-5524-d24d767fa92f@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ycCrs6TZIAPbbyZe"
Content-Disposition: inline
In-Reply-To: <261e118d-529b-0ce0-5524-d24d767fa92f@opensource.cirrus.com>
Precedence: bulk


--ycCrs6TZIAPbbyZe
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 20, 2023 at 03:46:26PM +0000, Maciej Strozek wrote:
> W dniu 20/11/2023 o=A014:40, Mark Brown pisze:

> > > +		} else {
> > > +			return 0;
> > > +		}

> > Is it a bug to call this function without to_poll set to something
> > known?  This will just silently ignore it which seems wrong and is
> > inconsitent with the handling in the interrupt case which will wait for
> > the the completion to be signalled and report a timeout on error.

> In interrupt case 0 means timeout (and calling function should expect 0 as
> error/timeout), so the only inconsistency I see is in not waiting before
> returning a timeout, but that would be needlessly wasting time?
> Do you think adding a debug print or a comment would help here?

It seems like a clear code bug if this is ever called with an unknown
completion, I'd expect a WARN_ON_ONCE() there.  The lack of a delay is
potentially going to affect how any error handling works which doesn't
feel ideal though the users look fine right now.

--ycCrs6TZIAPbbyZe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVbgSUACgkQJNaLcl1U
h9DLHggAgw4p1rPiLwpJ1J/hleOS2jFFzXuwTkstI6G2g5uZWsaBuaUFeZQyHriY
avc7aCFDEjYZBryEbey+S08tmNygDp+qVkHrCy2VSCyVM3TeP7vaIwtebTA+bLWL
3bdP22f26lajNin048S3VyyLv0pYblUm3hSpCA/fIhp2TGW2HtRD7U1cSx9giCx1
yMpMKx559NWzmdv2Mmi9iRCDZvgFixZT+74VtshWAwhDBE3pmxax7DxXQ2XlG0RM
/WlpqGQbtspRZrIuhrL5TC1xZG4V1HEB5S9FpYggmY97cOxb7ZiPaN1Y7NP2ZaCt
qiwhCBj+GjggmiCqjjqbzxVHhdwouA==
=hruj
-----END PGP SIGNATURE-----

--ycCrs6TZIAPbbyZe--