Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Mon, 20 Nov 2023 23:58:36 +0800
From:   kernel test robot <lkp@intel.com>
To:     Raag Jadav <raag.jadav@intel.com>, mika.westerberg@linux.intel.com,
        andriy.shevchenko@linux.intel.com, rafael@kernel.org,
        lenb@kernel.org, robert.moore@intel.com, ardb@kernel.org,
        will@kernel.org, mark.rutland@arm.com
Cc:     oe-kbuild-all@lists.linux.dev, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        acpica-devel@lists.linuxfoundation.org, linux-efi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com,
        Raag Jadav <raag.jadav@intel.com>
Subject: Re: [PATCH v1 3/6] ACPI: bus: update acpi_dev_hid_uid_match() to
 support multiple types
Message-ID: <202311202353.O38sik0Y-lkp@intel.com>
References: <20231120120837.3002-4-raag.jadav@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231120120837.3002-4-raag.jadav@intel.com>
Precedence: bulk

Hi Raag,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 5bd262f4820f2d5645d8ff1f251ef8e96715ef84]

url:    https://github.com/intel-lab-lkp/linux/commits/Raag-Jadav/compiler-h-Introduce-helpers-for-identifying-array-and-pointer-types/20231120-201140
base:   5bd262f4820f2d5645d8ff1f251ef8e96715ef84
patch link:    https://lore.kernel.org/r/20231120120837.3002-4-raag.jadav%40intel.com
patch subject: [PATCH v1 3/6] ACPI: bus: update acpi_dev_hid_uid_match() to support multiple types
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20231120/202311202353.O38sik0Y-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311202353.O38sik0Y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311202353.O38sik0Y-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/acpi.h:45,
                    from drivers/iommu/amd/iommu.c:13:
   drivers/iommu/amd/iommu.c: In function 'get_acpihid_device_id':
>> drivers/iommu/amd/iommu.c:103:63: warning: pointer/integer type mismatch in conditional expression
     103 |                                            p->uid[0] ? p->uid : NULL)) {
         |                                                               ^
   include/acpi/acpi_bus.h:915:46: note: in definition of macro 'acpi_dev_hid_uid_match'
     915 |         (acpi_dev_hid_match(adev, hid2) && (!uid2 || acpi_dev_uid_match(adev, uid2)))
         |                                              ^~~~


vim +103 drivers/iommu/amd/iommu.c

81cd07b9c92ad4 drivers/iommu/amd_iommu.c   Joerg Roedel    2016-07-07   85  
15898bbcb48fc8 arch/x86/kernel/amd_iommu.c Joerg Roedel    2009-11-24   86  /****************************************************************************
15898bbcb48fc8 arch/x86/kernel/amd_iommu.c Joerg Roedel    2009-11-24   87   *
15898bbcb48fc8 arch/x86/kernel/amd_iommu.c Joerg Roedel    2009-11-24   88   * Helper functions
15898bbcb48fc8 arch/x86/kernel/amd_iommu.c Joerg Roedel    2009-11-24   89   *
15898bbcb48fc8 arch/x86/kernel/amd_iommu.c Joerg Roedel    2009-11-24   90   ****************************************************************************/
15898bbcb48fc8 arch/x86/kernel/amd_iommu.c Joerg Roedel    2009-11-24   91  
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01   92  static inline int get_acpihid_device_id(struct device *dev,
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01   93  					struct acpihid_map_entry **entry)
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01   94  {
ae5e6c6439c3d0 drivers/iommu/amd_iommu.c   Andy Shevchenko 2019-10-01   95  	struct acpi_device *adev = ACPI_COMPANION(dev);
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01   96  	struct acpihid_map_entry *p;
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01   97  
ae5e6c6439c3d0 drivers/iommu/amd_iommu.c   Andy Shevchenko 2019-10-01   98  	if (!adev)
ae5e6c6439c3d0 drivers/iommu/amd_iommu.c   Andy Shevchenko 2019-10-01   99  		return -ENODEV;
ae5e6c6439c3d0 drivers/iommu/amd_iommu.c   Andy Shevchenko 2019-10-01  100  
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  101  	list_for_each_entry(p, &acpihid_map, list) {
ea90228c7b2ae6 drivers/iommu/amd_iommu.c   Raul E Rangel   2020-05-11  102  		if (acpi_dev_hid_uid_match(adev, p->hid,
ea90228c7b2ae6 drivers/iommu/amd_iommu.c   Raul E Rangel   2020-05-11 @103  					   p->uid[0] ? p->uid : NULL)) {
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  104  			if (entry)
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  105  				*entry = p;
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  106  			return p->devid;
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  107  		}
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  108  	}
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  109  	return -EINVAL;
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  110  }
2bf9a0a12749b2 drivers/iommu/amd_iommu.c   Wan Zongshun    2016-04-01  111  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki