Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Min Li <min.li.xe@renesas.com>
To:     Simon Horman <horms@kernel.org>, Min Li <lnimi@hotmail.com>
CC:     "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "lee@kernel.org" <lee@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v4 1/1] ptp: clockmatrix: support 32-bit address
 space
Thread-Topic: [PATCH net-next v4 1/1] ptp: clockmatrix: support 32-bit address
 space
Thread-Index: AQHaF9X+rfqWHxkaSE65IZplIdGS4rB+vb2AgASiGZA=
Date:   Mon, 20 Nov 2023 16:00:18 +0000
Message-ID: <OS3PR01MB6593FBB65E9AC4B2CA721F95BAB4A@OS3PR01MB6593.jpnprd01.prod.outlook.com>
References: <MW5PR03MB693280FDB441C89906BE044BA0B1A@MW5PR03MB6932.namprd03.prod.outlook.com>
 <20231117165419.GO164483@vergenet.net>
In-Reply-To: <20231117165419.GO164483@vergenet.net>
Accept-Language: en-CA, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T6s3S8FgleoCz1eybOpb32jXxmSs45ggYWFpChnOuDOiH196ntzRv/+dlKBw?=
 =?us-ascii?Q?glza3hXxya8lRewFN2g0+9OUwei98ZwwredDQfGFduL+FSVmkOtMlKY/LBlf?=
 =?us-ascii?Q?iTr+UgHKqQ2AIrivjX4MA1FheExddVgE9aFeoAl3cEkvnz2cDNGC2JHnEEU2?=
 =?us-ascii?Q?ESLsZAegXP3jBEWy5ZXaR91tcxLdfLQuEaN9nH+6KI4/x88+REa5s06WHwEf?=
 =?us-ascii?Q?6XZpKiff0DpoQRoEQOiSZN4LncrCE8xTbo9xejyboAgYSTMNIMxR8at7PSfJ?=
 =?us-ascii?Q?RQ0iZHu5m9huZF2qo34wAhdvx0A04Ls7TcRrRjmvhwyNnWU9gsHK3a3zYfLg?=
 =?us-ascii?Q?7odQYWSDoGB2xLObs2yPljPlrazHEJ33FV04m0VHkQU8Dz8aLAJA1Zs3b1+m?=
 =?us-ascii?Q?c95ez/hc6JVD/ktClGJ/Lns2EieEkyZwbwvOR+S5JzWsArFlvq3ak9BWuiBN?=
 =?us-ascii?Q?Zynu7YJkuZpk9yxpstL3cCe9iZeQP/DKuEdaDYs27Cgg4ykxYMmi6U+3nw9A?=
 =?us-ascii?Q?VPafdURlvQ1Sgq65B5N0p0ZFIRH4YI2+FA3MkhqgdfHPtK6xNMKtSsWvBPGT?=
 =?us-ascii?Q?maPclRsgWvILo1hSZh13Mjsm13LkjB9U1T5uP7EzE+Zw17xzG++OKxFnOmFj?=
 =?us-ascii?Q?XYkhZTODiUIcOhyB52kYCY+3e4Kq/gjxiQ18nAa5t4MD0CTFKUPS3/AovMhi?=
 =?us-ascii?Q?+thcXulPbdBvP1afnkZ/kvdcb9rwO74YkJe+nTEPcPILhjXRIWDKsfKDmciB?=
 =?us-ascii?Q?SA1UomVFm0css+WtJbF5FrzOwgkUuCV/Yhvsf8IsMGN976Q07YzLtEYmigdo?=
 =?us-ascii?Q?uD81l+RYq6DHFPLyB0MbxviTU7rAUxEghbD7LRbJzoyVL1o9HgvE3tgsuVXr?=
 =?us-ascii?Q?wZTpADZdv4ukUH9JSi4BJwkOi2P7Q6pCocqKw6HoSUl1Js1/LyzfVhDMk2on?=
 =?us-ascii?Q?mwnHLclpt6X8i6JJVw9fBXy6+bgSp5XBJdDXAeXAmR+03CLTPSD4uRWeMc5c?=
 =?us-ascii?Q?fI7gLGWZqyORm3Kj8ATqn9amacKhpZ2oSQIqXJeFGSvvTqtz/WpUEoDc8iR8?=
 =?us-ascii?Q?sX8mdRXuQgTKSf3D1xF7fR/fqG7ZBcwkc3f8EtR4Jy8XS+rI2H/CyTWy58BC?=
 =?us-ascii?Q?7pgw3dpzmi2AQK0Qramkw3t8sd4vRiQwAz6X37VNmR2OmULPxqzVDx+zkYMN?=
 =?us-ascii?Q?3uCle31G4E1UVE59oeUlVQ2IVr9JbhmD505XkTmfNMaMeUDs2ZFW+TNFSZLy?=
 =?us-ascii?Q?uUhNoka+MqFfAqJl2A3ZizBc3BxCFUezPteLOzwz/u/ryeRw7OOqzOGR6qS9?=
 =?us-ascii?Q?i7N7fWDMNMydmBWE1FP2fyL5RGB9BoYNEyrRvq5HjGyFy00lpUZjE3xMxFmO?=
 =?us-ascii?Q?4cxZ59eKb60mRi03QD8KT2/LiCHnb3ulzbEnHifKm2NpnCXOjflFQwE0qYoL?=
 =?us-ascii?Q?u8y116UTMRj3ZiHBReCN0+zQbeTV8b2WOMOEpGLmLqqzvOkkDoZZppTVy8i1?=
 =?us-ascii?Q?yZ41+fKx9pQ4FiFQfqKzJVY6hvf5+QLCiVJHqV2e9yt/C0DER8QuFdlJiTcB?=
 =?us-ascii?Q?2Kj+DZnyoqCUCV4PTl9Z9LX8s2BUWKDBe5VcqYxQ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB6593.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 790e0add-1f95-42cc-8480-08dbe9e1cb40
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 16:00:18.9652
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: It/qaDtcFRAWyuadXCzo2gP3JKdUfSbo+n4AUop1R+3RA+ZQG0Fpfczq1Nxy/vkjjBk2pIqWPpGpBi0DTh4ZSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB7940
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 08:00:40 -0800 (PST)

>=20
> I feel that I am missing something obvious, but I have a question which I
> would like to ask by way of an example.
>=20
> Both before and after this patch idtcm_read() looks like this:
>=20
> static inline int idtcm_read(struct idtcm *idtcm,
> 			     u16 module,
> 			     u16 regaddr,
> 			     u8 *buf,
> 			     u16 count) {
>         return regmap_bulk_read(idtcm->regmap, module + regaddr, buf,
> count); }
>=20
> And so before this patch the above call to idtcm_read() ends up as a call=
 to
> regmap_bulk_read:
>=20
> 	regmap_bulk_read(idtcm->regmap, 0 + 0xa7d4, buf, count);
>=20
> In particular, the 2nd argument is 0 + 0xa7d4 =3D 0xa7d4.
>=20
> But after this patch the call to idtcm_read() becomes:
>=20
> 	regmap_bulk_read(idtcm->regmap,  0x2010a7d4 + 0, buf, count);
>=20
> In particular, the 2nd argument is now 0x2010a7d4 + 0 =3D 0x2010a7d4.
>=20
> My question is, how does this patch take into account the change in this
> value from 0xa7d4 to 0x2010a7d4?
>=20
> Or to the point, does the call to regmap_bulk_read() still work with the =
new
> value?

Hi Simon:

The regmap_bulk_read side of change is handled by the following patch. Basi=
cally
Clockmatrix has 4 bytes of offset registers and rsmu_i2c driver used to ass=
ume=20
0x2010 as part of the offset and only take the lower 2 byte offset from reg=
map_bulk_read.
After the change, rsmu_i2c will take the full 4 byte offset from regmap_bul=
k_read

https://lore.kernel.org/lkml/MW5PR03MB693295AF31ABCAF6AE52EE74A08B9@MW5PR03=
MB6932.namprd03.prod.outlook.com/T/