Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2348311rdb; Mon, 20 Nov 2023 08:35:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuaH8o4vzUp7hqxkm+TX/5mcppFfi8bV2nRkYoZT03kRberhcrn1MYKM1zVXeNpw6XgnZX X-Received: by 2002:a05:6a20:9188:b0:187:dd5f:93b9 with SMTP id v8-20020a056a20918800b00187dd5f93b9mr6611567pzd.14.1700498116168; Mon, 20 Nov 2023 08:35:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700498116; cv=none; d=google.com; s=arc-20160816; b=aD+gzU+755CO++FNNj0X0JLisMVngV7aGsFf1gLYQvIr3c9bEfJYQbnlOnKrdB7P1f WLBPaEVUEnaY03RnHBlU0V1dBG4asUsqfxnR5HsVzJ5od7R3gh+TZqBpxC5aY8G5GmyQ YxPTz8laKbk6T7r35W0e38KFytvoAdrt2nVG73C6Oz+BYecbGtYju0M7IHbGfZMABPzT NhI53prUeg58il0ztG6a1Jel/lbNT2RfuLTLaaBYssfE6settREcWdaR1ywoB8kjc7WH w5z7tyVqvrmcjWEg9mBwnCufxhhV++um/5quaK0deIonjb4M6tecAl4Fr8JAxe/EJRRh FYAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=RZvczFxIKyKy6D2excjoW9QSNl/x+SIklQ2YwnPNLtE=; fh=mWE/SaaSHK2sEn52aW1nbID2pkbtaJIVyWwNgMRcooM=; b=JlJ4N4RSV2nPkyL1MRPv31Zk7dJIfIUoXzZapTLtFwa4VkAhUB/lTYrrbPFmFz1J00 95JCOpz1la+5+PkpVIFLwXWK+OCEeMU64tGd7S9nAJzhSlTLLUhhdL8g0iGB2MoSA/kL B0+MUUIiZO/FdsSpAcSFGQcBsXp6nRffv2soJmNE/aZtZD2onfrB+OrnhTRwKufwSBim 6C9OR5UTyuGGeuj+zzA45PF7vQTLErpsGRRDy9nEpaS3kzxM1rq6UH9lZ7VnFKNowidF XI1o5OJL9CAiz5XrYtvZH4XE4m1yZiBYu73/dfrhobUtGKVBdt7zMYR+w4pzj5uTJLuf sukw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gp6hnjM0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id h26-20020a63531a000000b005b95fbb1747si8376461pgb.761.2023.11.20.08.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 08:35:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gp6hnjM0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7B3158031AF9; Mon, 20 Nov 2023 08:35:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231605AbjKTQfH (ORCPT + 99 others); Mon, 20 Nov 2023 11:35:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230169AbjKTQfG (ORCPT ); Mon, 20 Nov 2023 11:35:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 975DCC5 for ; Mon, 20 Nov 2023 08:35:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700498101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RZvczFxIKyKy6D2excjoW9QSNl/x+SIklQ2YwnPNLtE=; b=Gp6hnjM0nN5WIinUdZ4cQMP6wxHtovXz9KVCpDQaJCS2IpCJX+puH/uQKYWv682IAJ7CzP ou+BB5AafrrquIRtDCu6pHRlSf59K6OP3hQjEcZlHYFhpq6tiPsQo50vQzBt+6C7xIeoae TuRQFlOoCu/YXbiD4yiWzZUT3HBzUVY= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-467-a3NuuBPnN3Wfx6Zp3V8zug-1; Mon, 20 Nov 2023 11:35:00 -0500 X-MC-Unique: a3NuuBPnN3Wfx6Zp3V8zug-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-58a23b6c2d3so4357051eaf.3 for ; Mon, 20 Nov 2023 08:35:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700498099; x=1701102899; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RZvczFxIKyKy6D2excjoW9QSNl/x+SIklQ2YwnPNLtE=; b=hdAwut1kiy7qh2o//h3SQYKYNlJb3R4yLqylVn+HoElHulz0n8ZKAdY8J0J9TYLK1V TXjO28JGlYBN5zoZP+2O/E7BG60689g8MmzQrC58RBdh04GEyw95KgxZf20irLmsLRYA B7BrEkIiG0K7EVyKiJQ+Uq459fA2aPgcCF9/m/u/WCRncpp58nR+0EOYykFgVvFa0okw tGndwctpJFyCIQnhquDXBwP/OnQhID8yHMYYU3VduaEoNXSCcr/lv8kCeQLWe6WRQJIk xJEi1bHuPd69ify2lTv9ov4nLpFTKiMv0wi//ZIX3/jCetVSh+3/egORfyj4ka7/npnc HesQ== X-Gm-Message-State: AOJu0YzRZ/8TjCgcm/J87mHOQzb1TKAByzyM8z8dO06LL0skYuZBLNt5 DqMagMa+FIaznJ6eAUUQeozkP7ZqFCno8BCEcHGwjCTNw/fHWlhFQjroaWbHcDfAqHd8UGQlU9e UB3t+eIrcsnd5xn3Q9j8d4X2VYtKF/6oEvJmia6/r X-Received: by 2002:a05:6358:726:b0:16b:4b12:1842 with SMTP id e38-20020a056358072600b0016b4b121842mr8647509rwj.6.1700498099552; Mon, 20 Nov 2023 08:34:59 -0800 (PST) X-Received: by 2002:a05:6358:726:b0:16b:4b12:1842 with SMTP id e38-20020a056358072600b0016b4b121842mr8647488rwj.6.1700498099328; Mon, 20 Nov 2023 08:34:59 -0800 (PST) MIME-Version: 1.0 References: <20231120105545.1209530-1-cmirabil@redhat.com> <8818a183-84a3-4460-a8ca-73a366ae6153@kernel.dk> In-Reply-To: <8818a183-84a3-4460-a8ca-73a366ae6153@kernel.dk> From: Charles Mirabile Date: Mon, 20 Nov 2023 11:34:48 -0500 Message-ID: Subject: Re: [PATCH] io_uring/fs: consider link->flags when getting path for LINKAT To: Jens Axboe Cc: linux-kernel@vger.kernel.org, asml.silence@gmail.com, io-uring@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 08:35:13 -0800 (PST) On Mon, Nov 20, 2023 at 10:59=E2=80=AFAM Jens Axboe wrote= : > > On 11/20/23 3:55 AM, Charles Mirabile wrote: > > In order for `AT_EMPTY_PATH` to work as expected, the fact > > that the user wants that behavior needs to make it to `getname_flags` > > or it will return ENOENT. > > Looks good - do you have a liburing test case for this too? Yes, see here https://github.com/axboe/liburing/issues/995 and here https://github.com/axboe/liburing/pull/996. > > -- > Jens Axboe > Best - Charlie