Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <a5f86bcf03b2ed809245d57f5971ae42a8b85128.camel@infradead.org> <ZVT+Fq1yVZ9G8pqx@shikoro>
In-Reply-To: <ZVT+Fq1yVZ9G8pqx@shikoro>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 20 Nov 2023 18:01:51 +0100
Message-ID: <CAJZ5v0j=b_k1gnHfPSNGkNm4nTW8Erou=B3KYW5+6Mqy-iTfyQ@mail.gmail.com>
Subject: Re: [PATCH] PM: tools: Fix sleepgraph syntax error
To:     Wolfram Sang <wsa@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Len Brown <lenb@kernel.org>, Xueqin Luo <luoxueqin@kylinos.cn>,
        Todd E Brandt <todd.e.brandt@linux.intel.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-pm <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Wed, Nov 15, 2023 at 6:21 PM Wolfram Sang <wsa@kernel.org> wrote:
>
> On Wed, Nov 15, 2023 at 11:47:51AM -0500, David Woodhouse wrote:
> > From: David Woodhouse <dwmw@amazon.co.uk>
> >
> > The sleepgraph tool currently fails:
> >
> >   File "/usr/bin/sleepgraph", line 4155
> >     or re.match('psci: CPU(?P<cpu>[0-9]*) killed.*', msg)):
> >                                                          ^
> > SyntaxError: unmatched ')'
> >
> > Fixes: 34ea427e01ea ("PM: tools: sleepgraph: Recognize "CPU killed" messages")
> > Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
>
> Had the same issue:
>
> Reviewed-by: Wolfram Sang <wsa@kernel.org>

Applied as 6.7-rc material, thanks!