Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2400383rdb; Mon, 20 Nov 2023 09:43:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGrVT2IW3vkkEExaU9gsk8LseU782c9lHEct7azlTiKtpTbXMyiPHaBfY/+vHnpji4WOhYo X-Received: by 2002:a05:6808:222a:b0:3b6:cb7f:8315 with SMTP id bd42-20020a056808222a00b003b6cb7f8315mr12272058oib.11.1700502225202; Mon, 20 Nov 2023 09:43:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700502225; cv=none; d=google.com; s=arc-20160816; b=ajTMiMNtwuEqT1WOkfc9zjAkBFKy0WJymd/3DlNgQHmSVHDx78fynOjHpn/200CbOs lrBuGvm7LZNSc4z5C0ZRJFw2s2Q63GcPUig9Iptm8lfFSCByQUYNRsaVdhiSvhUhzbRc 29JkaQFr/6qnyLpqsEN8qhVOECVvhElOXsH0u3fIskVJZc8uFFngiD5IDNSCi6e4Aa0S zNit9mzjG/dLeJHdZBZhpJ22KktQOyzdCC5/156pdWsgDGyz5L2Mu5oVGUcffQujd0Sv Y3EtDIVlmWBzaX9ENN8Gw98xUHq6QdKHAOXtR88mBzP4h35LnPoQ6NydxiYzqhfjVeXO mYuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1iNeBwZTFUSzHcSvmN520DszYMA/p9IFmmRLkAmWn8Y=; fh=WMKtlPZnjvHXK4dDze4WMr50owFOJSzPKU/0lEujet0=; b=JO3DI10dy8SJdcyBoYvyb5y8t4W5/15r43BQgr5xXpZ+YLVl+RMVGCCYKlQmEKTjFU xJIzsgitw+6kh13GodezAXn4t3mMhRVD2GGCW1Q3kDnk/rgBB+PxmU3CY839j21iTb6j hyVJS4K37qGVDy+/VNSKaUMmujOD69im+KNY9K/HiP6FT3j9l+Bx7JMWNnnLNOj2aNfv EI74Dt/iodSEBC0lAykZXRbZdTgsefwUNwNsCEjUfrKLZJB+0MIYIKIccMFsOrF0Gslo wvDO/4Va44yb0jqEiP85UeSKx1Wztsjl5wZ1xmpiPc65ciQwrF41QLHEssNfXsHMdxfa Tnww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aRoVhwIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id u3-20020a6540c3000000b005c202f96bbdsi7952686pgp.703.2023.11.20.09.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 09:43:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aRoVhwIZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id D3EE9809ADCF; Mon, 20 Nov 2023 09:43:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233971AbjKTRnA (ORCPT + 99 others); Mon, 20 Nov 2023 12:43:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234445AbjKTRmp (ORCPT ); Mon, 20 Nov 2023 12:42:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4028AD4D for ; Mon, 20 Nov 2023 09:42:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 193BAC433C7; Mon, 20 Nov 2023 17:42:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700502155; bh=VYsVMb7dTZSeGCIvqAHMIHrNGYFSYLbLSCW2ZnJAC2o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aRoVhwIZzsovcUht4xexdrGQy1sY4u1raQytjdoBKYogoR7+Ksy32OmeKkb1yg8iU d7DdalH5URIptKGMKEgvgXuvLVNCA0DqZ8XwO/IgeoA+/qwAg0TuOrsqUCqcKMH3Wf 2dMVb//32yoT65XNhOJiE8NXaNxvu7OWMsRRxnEr4xtLkTtOIJrReh58SdYABbi0ZW KLVlpgSRUNhHIv8UmrqQuFaEpTEwKU4m0WlM0jNMx9m4NOwsBB9V2cyGMPg3zJ32EV NGSflUAmBj/tjylbccffM11JtPeJMT+pPN1fTZgisAmtAQm83ufWaO25XlpFxve5ZS SP8xddyEtuY1Q== Date: Mon, 20 Nov 2023 09:42:34 -0800 From: Jakub Kicinski To: Christian Marangi Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next PATCH] net: phy: correctly check soft_reset ret ONLY if defined for PHY Message-ID: <20231120094234.1aae153e@kernel.org> In-Reply-To: <20231120131540.9442-1-ansuelsmth@gmail.com> References: <20231120131540.9442-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 09:43:16 -0800 (PST) On Mon, 20 Nov 2023 14:15:40 +0100 Christian Marangi wrote: > Luckly nothing was ever added before the soft_reset call so the ret > check (in the case where a PHY didn't had soft_reset defined) although > wrong, never caused problems as ret was init 0 at the start of > phy_init_hw. not currently a bug => no Fixes tag, please -- pw-bot: cr