Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Li, Xin3" <xin3.li@intel.com>
To:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>
CC:     "seanjc@google.com" <seanjc@google.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "kys@microsoft.com" <kys@microsoft.com>,
        "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        "Cui, Dexuan" <decui@microsoft.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>
Subject: RE: [PATCH v1 15/23] KVM: nVMX: Add support for the secondary VM exit
 controls
Thread-Topic: [PATCH v1 15/23] KVM: nVMX: Add support for the secondary VM
 exit controls
Thread-Index: AQHaEnYCzFnG3GUP+kCaRbBMUKVZALCDblcAgAAdo1A=
Date:   Mon, 20 Nov 2023 17:42:21 +0000
Message-ID: <SA1PR11MB67344F9713F27B95454B73C5A8B4A@SA1PR11MB6734.namprd11.prod.outlook.com>
References: <20231108183003.5981-1-xin3.li@intel.com>
 <20231108183003.5981-16-xin3.li@intel.com> <87y1espgkl.fsf@redhat.com>
In-Reply-To: <87y1espgkl.fsf@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2dgxneMFInTJknPm22AOQyOMQKVccgzrPnSb9gO92N52SaSkKM1ceuHim1NM?=
 =?us-ascii?Q?HqJbvyYMTXzO8Tq2IgdBRLNa59Rm0MHwOuuAtd867C9psabvO76i7M8WiNA1?=
 =?us-ascii?Q?X+kRmao4KQQXQscnxGx7/xxXeHS4ZiSdNZSFdfoTl7aHlra1DnMiu+koWSXP?=
 =?us-ascii?Q?OlyJ65OCf0zNlrcSXxXGvqWkAU64y39RrR20ukRPSINrGv8GKKidxXSiBibq?=
 =?us-ascii?Q?hr5jNzEf2A0v9UllqoSjYg5nfXw/UwvLE54EcFKpabQL8V260CpHTk8pBplU?=
 =?us-ascii?Q?AekQHmJkpwGXQjiSdPxCjxI0GOtxrBBKtUJL3wxUHLxSDUOui9/UbNNOFRgT?=
 =?us-ascii?Q?av+X6Breq/c3IjuuwvDWHWUTL4DSU3/LSaD9LMzf0XphXlskD2vvABsqV6+n?=
 =?us-ascii?Q?dP77bvgKCk9vr/mpsuV5vmHTx0FT9ZvcH4EG+BHafrfywkLpDaTdNIytVRVI?=
 =?us-ascii?Q?WnqWHBaL/tm0/jfV4liEyZRXhJAn7/0Un1JkRUB5QbmS+9I+rbd1bhRsFENj?=
 =?us-ascii?Q?O4VQyzKDclZcDxw0EzF7UIuRemuFzdmj3oCjU3xlO6ZKg7vy+FI6Axmn54Ze?=
 =?us-ascii?Q?O+qGA45lfHRMsT64ua8KW2U4T9wKUrnZxMB4M44iP/21iVyckvI9t9cMZIXi?=
 =?us-ascii?Q?1KXbOjpD345OM/aZomFFSoUzBjSqHXsyCoEyFNOTkcmAPKaJbz5GtregZmW0?=
 =?us-ascii?Q?ozbD9oXnxXbh6lABri/eh6rZy5isn5lgY+RWrqVOPlFVwpU2PZPSl4htNtyK?=
 =?us-ascii?Q?TsrOYbXvrsQHga39k4codgwwRMG5ggWKoHhbof5JrV0NIU+SM+4LmhyE12Ek?=
 =?us-ascii?Q?b7zI+zck3IRUf8AUaEz9ltN2cIddw48w9SAu74XHptJA94UcGGLZ5u0iOKTf?=
 =?us-ascii?Q?f1B6TGjpr2kWD6Rx9G1ODzE70VzBYUAezvMg5RLUCGji3qgqOsCrYoofGN2H?=
 =?us-ascii?Q?N5c92QeP59BMbbO8HWcyUVS0Y4NnbhDr6MNZC0qrmQ3gMOthQnhwxfP+amaj?=
 =?us-ascii?Q?gxX3a6Zsib0Q6P3LWYx8JkRHEIhTlkBBe8yxkxJGJ8Pvq9Qp4iE3JlocWSXM?=
 =?us-ascii?Q?HuM8BY3YXX3LRyNe8TXC+lOeCb1lp48p579FLsWGOY0oWTmRTt6YtsQYt4/r?=
 =?us-ascii?Q?XX9SZZf5o5+0v75fl8Uf/OfJ9zJSXvmlF/yC1c+gRCgpmAlAbvQ7aeEmjJd1?=
 =?us-ascii?Q?hLV5FtoBtLJryTrHzJav6WUTbfiu8doWjwjeEgY005QARrWZplVlJ7QU+tDN?=
 =?us-ascii?Q?9OI7aRtmFoAtuRCuIuzrj9pjarKm4zhfr7BnmZtOb+wMEU2fZDL+Ptz07K/9?=
 =?us-ascii?Q?7PFFpzYeroALsP3Do47dOGuILaiM2CO9NERbMJnblB5ZYdeLYxW5YpwRi2Up?=
 =?us-ascii?Q?zj3j+fnfAKcF5pCH0xNsLZPCBPA16jNDYWmwBT5PzAjSLyr5nsangWMMXzYV?=
 =?us-ascii?Q?4Rk1KlRYxYU/lKxTqlIANnBOrwJJvTbbhNqz78ae4ZR1QPE0MOM38Lg2/ZEy?=
 =?us-ascii?Q?qY0rlaspZny8wepGTJ6vMlv4yMB+ihRprCWEfvoX+DdehOG1N3EB/WGN3dF1?=
 =?us-ascii?Q?RTVfPKatuHHImobt604=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6734.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39d7c7fb-1f44-4a74-f149-08dbe9f00c8b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 17:42:21.4488
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jSg53oqSDwS3UL9MSDI+aYp6CmlK/uxaQLWaZNWjCX3cS4Fkyago00e+13Lb6m0bkl0eyGotVvuxMeqLPX5fBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7677
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 20 Nov 2023 09:43:42 -0800 (PST)

> > diff --git a/arch/x86/include/asm/hyperv-tlfs.h
> > b/arch/x86/include/asm/hyperv-tlfs.h
> > index 2ff26f53cd62..299554708e37 100644
> > --- a/arch/x86/include/asm/hyperv-tlfs.h
> > +++ b/arch/x86/include/asm/hyperv-tlfs.h
> > @@ -616,6 +616,7 @@ struct hv_enlightened_vmcs {
> >  	u64 host_ssp;
> >  	u64 host_ia32_int_ssp_table_addr;
> >  	u64 padding64_6;
> > +	u64 secondary_vm_exit_controls;
>=20
> (I think Jeremi has asked a similar question but just to be sure)
>=20
> This doesn't seem to be present in the currently available TLFS version e=
.g. here:
> https://learn.microsoft.com/en-us/virtualization/hyper-v-on-
> windows/tlfs/datatypes/hv_vmx_enlightened_vmcs
>=20
> That wouldn't be the first time when TLFS lags behind but as I don't see =
anyone
> from Microsoft signing this off, let me ask: where did you get this infor=
mation
> and, in case it came from someone @microsoft.com, can we get their sign-o=
ff on
> the patch?

This is being worked on.

> > diff --git a/arch/x86/kvm/vmx/hyperv.c b/arch/x86/kvm/vmx/hyperv.c
> > index 313b8bb5b8a7..b8cd53601a00 100644
> > --- a/arch/x86/kvm/vmx/hyperv.c
> > +++ b/arch/x86/kvm/vmx/hyperv.c
> > @@ -477,6 +483,9 @@ static const u32
> evmcs_supported_ctrls[NR_EVMCS_CTRLS][NR_EVMCS_REVISIONS] =3D {
> >  	[EVMCS_EXIT_CTRLS] =3D {
> >  		[EVMCSv1_LEGACY] =3D EVMCS1_SUPPORTED_VMEXIT_CTRL,
> >  	},
> > +	[EVMCS_2NDEXIT] =3D {
> > +		[EVMCSv1_LEGACY] =3D EVMCS1_SUPPORTED_VMEXIT_CTRL2,
> > +	},
> >  	[EVMCS_ENTRY_CTRLS] =3D {
> >  		[EVMCSv1_LEGACY] =3D EVMCS1_SUPPORTED_VMENTRY_CTRL,
> >  	},
>=20
> What's the desired effect here? I.e. why exposing
> VM_EXIT_ACTIVATE_SECONDARY_CONTROLS when none of the controls are
> going to be exposed?
=20
This is wrong for evmcs v1, I will drop it.