Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231120084300.4368-1-osalvador@suse.de> <40e26ded-a8c2-0e24-6fb0-d96053ae1c32@suse.cz>
In-Reply-To: <40e26ded-a8c2-0e24-6fb0-d96053ae1c32@suse.cz>
From:   Andrey Konovalov <andreyknvl@gmail.com>
Date:   Mon, 20 Nov 2023 18:54:48 +0100
Message-ID: <CA+fCnZcj4=02L9qc9wvr36Tsc-a5Qcd9146qVOva9N6gK_a9HQ@mail.gmail.com>
Subject: Re: [PATCH v6 0/4] page_owner: print stacks and their counter
To:     Oscar Salvador <osalvador@suse.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Michal Hocko <mhocko@suse.com>,
        Waiman Long <longman@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Marco Elver <elver@google.com>,
        Eric Dumazet <edumazet@google.com>,
        Alexander Potapenko <glider@google.com>,
        Vlastimil Babka <vbabka@suse.cz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 20, 2023 at 10:07=E2=80=AFAM Vlastimil Babka <vbabka@suse.cz> w=
rote:
>
> On 11/20/23 09:42, Oscar Salvador wrote:
> > Changes v5 -> v6:
> >      - Rebase on top of v6.7-rc1
>
> Hi,
>
> I think at this point it would be better to rebase on top of
> https://lore.kernel.org/all/cover.1698077459.git.andreyknvl@google.com/
> which already contains the refcount field in stack_record.
> (and maybe help with the review of that series as well? Hopefully it can =
get
> to mm/unstable and -next towards 6.8 soon :)

Yes, please; I just mailed a v4 that is based on v6.7-rc2:
https://lore.kernel.org/linux-mm/cover.1700502145.git.andreyknvl@google.com=
/T/#t

You should also be able to use the new
stack_depot_save_flags(STACK_DEPOT_FLAG_GET)/stack_depot_put API to
keep only the relevant stack traces.

Thank you!