Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <f7500671-812d-42ab-a16e-3325e13324ff@gmail.com>
Date:   Mon, 20 Nov 2023 19:19:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused
 variable 'qcom_scm_qseecom_allowlist'
Content-Language: en-US
To:     Bjorn Andersson <andersson@kernel.org>
Cc:     llvm@lists.linux.dev,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzk@kernel.org>,
        kernel test robot <lkp@intel.com>
References: <202311191654.S4wlVUrz-lkp@intel.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
In-Reply-To: <202311191654.S4wlVUrz-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/19/23 10:13, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   037266a5f7239ead1530266f7d7af153d2a867fa
> commit: bdac188ec3c71800dd8419620224ee74ef37732a firmware: qcom: move Qualcomm code into its own directory
> date:   4 weeks ago
> config: s390-randconfig-002-20231119 (https://download.01.org/0day-ci/archive/20231119/202311191654.S4wlVUrz-lkp@intel.com/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231119/202311191654.S4wlVUrz-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311191654.S4wlVUrz-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):

[...]

>>> drivers/firmware/qcom/qcom_scm.c:1652:34: warning: unused variable 'qcom_scm_qseecom_allowlist' [-Wunused-const-variable]
>      1652 | static const struct of_device_id qcom_scm_qseecom_allowlist[] = {
>           |                                  ^

Any ideas why this is supposedly unused? It should be accessed through
qcom_scm_qseecom_init() and qcom_scm_qseecom_machine_is_allowed().
Especially if CONFIG_QCOM_QSEECOM=y.

>     13 warnings generated.
> 
> 
> vim +/qcom_scm_qseecom_allowlist +1652 drivers/firmware/qcom/qcom_scm.c
> 
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1647
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1648  /*
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1649   * We do not yet support re-entrant calls via the qseecom interface. To prevent
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1650   + any potential issues with this, only allow validated machines for now.
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1651   */
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27 @1652  static const struct of_device_id qcom_scm_qseecom_allowlist[] = {
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1653  	{ .compatible = "lenovo,thinkpad-x13s", },
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1654  	{ }
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1655  };
> 00b1248606ba39 drivers/firmware/qcom_scm.c Maximilian Luz 2023-08-27  1656
> 
> :::::: The code at line 1652 was first introduced by commit
> :::::: 00b1248606ba3979ccae30ed11df8cdc1a84245a firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface
> 
> :::::: TO: Maximilian Luz <luzmaximilian@gmail.com>
> :::::: CC: Bjorn Andersson <andersson@kernel.org>
> 

Regards
Max