Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2459826rdb; Mon, 20 Nov 2023 11:19:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEg9T5m4VpUzgYtlNbioZtkasmQwLwzLMZFYLAEUI2YuA9H5wb1Owa394brxXeY0EM2mZ6A X-Received: by 2002:a17:903:1251:b0:1cc:2dad:7ae9 with SMTP id u17-20020a170903125100b001cc2dad7ae9mr10221015plh.32.1700507966591; Mon, 20 Nov 2023 11:19:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700507966; cv=none; d=google.com; s=arc-20160816; b=trEzxda2VYQ0O1LxykrhdBHRhI0X5nIzi9taxvOSUC6mpMFCMXN6PS2LovO9jjmTt0 yyVNxVrxUWyvcGwI2YrSh18bmOZi8qYEo2qevm5iZ+ORYQJ4SwzECgdXh1zTHdAYibNF 6QsA7yA0WxDN/PZLMtrmlLtLQn6e7i4xwRNX2fPDtJBbgdyhNg53FuZnCpjzLRJpGmEh hYhBMv6tXZMKPDn0Rcck8tvDlQutTplsQsbEsLIID/jHaEsHlVlywiEbLiUs836dvM4s m8qg8ssngf6dqkzUbdrk51n1Q5uEcxBCPblFVNAEXPHai0xPZPhEOAlloF4G4ngoK9Vg p5Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=SaxbRowMAk31FqdZFbOgzj008ErtgPmSCna+TG6JHQU=; fh=zTYSv+37rQqT6NSU46y8MJsny/QLFM4bpdETmF1mdAc=; b=okWEDqqj7D+C0wWLhFVWaG3+7IhOMc/Wpz/jKWkRNl2qdj1BlocNHE6BTHJs0u042b /NZ+lxTAENCZQ0k4vkSuaULncRYTDETwCYyKEwsVnHWHtCXpaizPjA/dUneSqu9sJiF/ aNi2sal64CVz78oPwNlKdAVe/67BuoJ8MpMCYCZvVrlztgXfamOYKQObMa8ibQOCHau+ CSJtTLmS4aKz6A9+m5LxVZc5uJQWgdHpQ3tYYORgcnMf0O9kuU2ziyVP7KD/9/NS6x8Q 5gKvegZXpEMF2oYb5/ahMPnjldhYObDB6BbVyIobGa0CuNPjoFQHxLLEvooYNkOPQJ4P aXxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id m13-20020a170902db0d00b001cf64c06394si1722541plx.556.2023.11.20.11.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 11:19:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id CED168037AA5; Mon, 20 Nov 2023 11:19:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232459AbjKTTTF convert rfc822-to-8bit (ORCPT + 99 others); Mon, 20 Nov 2023 14:19:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231734AbjKTTTC (ORCPT ); Mon, 20 Nov 2023 14:19:02 -0500 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C692DC; Mon, 20 Nov 2023 11:18:58 -0800 (PST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-5ca164bc0bbso16086097b3.3; Mon, 20 Nov 2023 11:18:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700507937; x=1701112737; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GifO7/JOpk0NmY1mNUiYBsJ2MaEkt42xKaLVw+ulB/A=; b=j/X/pu4PsJt1neN8AhYk+mvnpLy3S5NCW/fMYBYEGUGD6YwXWv0JdJLeDTXfgsWm8v ZKO/l4rcY+DN9YWHyHiLBcNCTTI1Bst1+1H3UhJ7Kv2Ce/p2Qf5yTa9QQ/tO587789ni m1s8wjINWe6tPNf/oY3F7jI+dQ2bpJKXGNgKRzqN0IgBMFsq69fs4TGHcVW5hsfvUUI6 kbKVSliKLR8ww+UIjErdUFxw4g2nhZjTkNx/KUBHsor1tqKQbmTLah50DyhcehcqL4pr gw5BzyH2b6WhlT/8rO6aP/KmN05ZVGvdRHeJMjFy3LttoDxurc992p6AkQgFHZfFhtKF TfbQ== X-Gm-Message-State: AOJu0YyJLL0KoJf3mIbDST8xun+fle994yo+g5jd4e9nIRYsLB16MCZ1 w6SHNpnv1AhI4TWwFtwYrkGuKlq7JucuXQ== X-Received: by 2002:a81:7e10:0:b0:5ca:67e8:4fab with SMTP id o16-20020a817e10000000b005ca67e84fabmr3717057ywn.8.1700507937165; Mon, 20 Nov 2023 11:18:57 -0800 (PST) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id z126-20020a816584000000b0059b50f126fbsm2527313ywb.114.2023.11.20.11.18.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 11:18:55 -0800 (PST) Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-d9a518d66a1so4334191276.0; Mon, 20 Nov 2023 11:18:54 -0800 (PST) X-Received: by 2002:a5b:f4a:0:b0:da0:c49a:5103 with SMTP id y10-20020a5b0f4a000000b00da0c49a5103mr7300082ybr.47.1700507934171; Mon, 20 Nov 2023 11:18:54 -0800 (PST) MIME-Version: 1.0 References: <20231120084044.23838-1-krzysztof.kozlowski@linaro.org> <19358871-009d-4498-9c13-90d5338b1e9f@amd.com> <76fa8f61-fe31-4040-a38d-cc05be3f4f17@linaro.org> In-Reply-To: <76fa8f61-fe31-4040-a38d-cc05be3f4f17@linaro.org> From: Geert Uytterhoeven Date: Mon, 20 Nov 2023 20:18:42 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] docs: dt-bindings: add DTS Coding Style document To: Krzysztof Kozlowski Cc: Michal Simek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Arnd Bergmann , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Konrad Dybcio , Neil Armstrong , Nishanth Menon , Olof Johansson , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 20 Nov 2023 11:19:24 -0800 (PST) Hi Krzysztof, On Mon, Nov 20, 2023 at 3:53 PM Krzysztof Kozlowski wrote: > On 20/11/2023 15:01, Michal Simek wrote:> > > > On 11/20/23 09:40, Krzysztof Kozlowski wrote: > >> Document preferred coding style for Devicetree sources (DTS and DTSI), > >> to bring consistency among all (sub)architectures and ease in reviews. > >> +Organizing DTSI and DTS > >> +----------------------- > >> + > >> +The DTSI and DTS files should be organized in a way representing the common > >> +(and re-usable) parts of the hardware. Typically this means organizing DTSI > >> +and DTS files into several files: > >> + > >> +1. DTSI with contents of the entire SoC (without nodes for hardware not present > >> + on the SoC). > >> +2. If applicable: DTSI with common or re-usable parts of the hardware (e.g. > >> + entire System-on-Module). > > > > DTS/DTSI - SOMs can actually run as they are that's why it is fair to say that > > there doesn't need to be DTS representing the board. > > I have never seen a SoM which can run without elaborate hardware-hacking > (e.g. connecting multiple wires to the SoM pins). The definition of the > SoM is that it is a module. Module can be re-used, just like SoC. /me looks at his board farm... The Renesas White-Hawk CPU board can be used standalone, and has a separate power input connector for this operation mode. As it has RAM, Ethernet, serial console, eMMC, and even mini-DP, it can serve useful purposes on its own. I agree it's not a super-good example, as the board is not really a "SoM", and we currently don't have r8a779g0-white-hawk-cpu.dts, only r8a779g0-white-hawk-cpu.dtsi. The RZ/A2M CPU Board is a real SoM, which can be powered over USB. It has less standard connectors (microSD, USB, MIPI CSI-2), but still sufficient features to be usable on its own. Again, we're doing a bad job, as we only have a DTS for the full eval board (r7s9210-rza2mevb.dts). I guess there are (many) other examples... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds