Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231120153419.3045-1-ubizjak@gmail.com> <20231120171507.GGZVuUG9aSLyF52jHd@fat_crate.local>
In-Reply-To: <20231120171507.GGZVuUG9aSLyF52jHd@fat_crate.local>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Mon, 20 Nov 2023 20:58:29 +0100
Message-ID: <CAFULd4aYe=B_Jiag1S4hO0XRXB-Y4UKh2Lat79JOLOB1h8ev4A@mail.gmail.com>
Subject: Re: [PATCH] x86/mm/encrypt: Use %a asm operand modifier to obtain
 %rip-relative address
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86@kernel.org, linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 20, 2023 at 6:15=E2=80=AFPM Borislav Petkov <bp@alien8.de> wrot=
e:
>
> On Mon, Nov 20, 2023 at 04:33:50PM +0100, Uros Bizjak wrote:
> > The "a" asm operand modifier substitutes a memory reference, with the
> > actual operand treated as address.  For x86_64, when a symbol is
> > provided, the "a" modifier emits "sym(%rip)" instead of "sym".
> >
> > Clang allows only "i" and "r" operand constraints with an "a" modifier,
> > so the patch normalizes the modifier/constraint pair to "a"/"i"
>
> s/the patch normalizes/normalize/
>
> > which is consistent between both compilers.
> >
> > No functional change intended.
> >
> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: Andy Lutomirski <luto@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> > ---
> >  arch/x86/mm/mem_encrypt_identity.c | 16 ++++------------
> >  1 file changed, 4 insertions(+), 12 deletions(-)
> >
> > diff --git a/arch/x86/mm/mem_encrypt_identity.c b/arch/x86/mm/mem_encry=
pt_identity.c
> > index d73aeb16417f..6a351fdd1b39 100644
> > --- a/arch/x86/mm/mem_encrypt_identity.c
> > +++ b/arch/x86/mm/mem_encrypt_identity.c
> > @@ -346,9 +346,7 @@ void __init sme_encrypt_kernel(struct boot_params *=
bp)
> >        * We're running identity mapped, so we must obtain the address t=
o the
> >        * SME encryption workarea using rip-relative addressing.
> >        */
> > -     asm ("lea sme_workarea(%%rip), %0"
> > -          : "=3Dr" (workarea_start)
> > -          : "p" (sme_workarea));
> > +     asm ("lea %a1, %0" : "=3Dr" (workarea_start) : "i" (sme_workarea)=
);
>
> Yeah, I saw that particular subthread today.
>
> Are you sure this "a" modifier DTRT with all gcc version we support?
>
> I.e., from 5.1 onwards...

Yes [1].

[1] https://godbolt.org/z/aWe7b16rT

Thanks,
Uros.