Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2490802rdb; Mon, 20 Nov 2023 12:16:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzprXc6GP5PaY5nxh/M6iI2Y1g2RX0TohjqOqLlH69xUS5PsiK0AtAOt0MsHI0jiYeRJr1 X-Received: by 2002:a05:6808:354:b0:3b6:a7c7:5760 with SMTP id j20-20020a056808035400b003b6a7c75760mr9070947oie.51.1700511394994; Mon, 20 Nov 2023 12:16:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700511394; cv=none; d=google.com; s=arc-20160816; b=ueMW1kPOCqsMaReHnOTOMYTHieDKLdfI2zO6rH32q/jB1fMmZlNyAgRXnwNCEPq3TI Ajw9JPFbak9Fv9WaaxCC+omR5HQ+fXPhdZ0NEjPxZwkS+GaHyU9z8wdMSoDkDLPrFffa r9hEpvVwoyRpJBpF5cOagMzKie1smBNbAzqh+GR0tgBTuZJe1jcu8A2wo/krHp/VZco1 UnVIF9XK9XJUbD3vaCByR/YqM0PT4gpZENSV0d5NeIhv3nx/9daBz7iDSIBUaDUVYUfO CHfdcgHvq/uT1v/dux0R07gU3x6Uutff2WPArjpX2k+bgWUNKYw1bou0kiLb8TsmmnPL nzcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=UN/JaGs58VC/59LNr+VTcKEJIUnlEUBkYK0zXNn4XiM=; fh=ZG21I1fo/Lt0ZpJ3UDgOUbjMPf62qQruwJSfZpZYFHI=; b=x8gM4xRCdun+/MpKDGG++m/v2aUAISJXP14umrkk15SnB/LA/xBLtWHTNE8bwyylwz 4in/5kcWB+kFEzOaZhPRPBfc8YGOF9Pt/krzTp5T27pVW4vDfPIdkrHRC3QxPRTIM4Og st8WvigEMdKkwohNHZzWwqd9dU/Ltm57BBiRRcXVjaqVFiAUld8+UQjrJkd7TJaD6ZYA IIoIesKjSSfewKTht/UU7jYxqyim2eAB2sXJB7zV7h82u2qyZJAm0j44l3T4Q1FN9Pr3 Egz/Fbtt5Y7SFuX/46fSI5zT9pBHxZGWDvbFNURo0G+0MQLAyG70heHG75bd4lj5cFbH 42jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20230601 header.b=RgP6LbXN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id n26-20020a6563da000000b005bd28c9bb23si8783237pgv.308.2023.11.20.12.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 12:16:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20230601 header.b=RgP6LbXN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9FC3D8072A21; Mon, 20 Nov 2023 12:16:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbjKTUQH (ORCPT + 99 others); Mon, 20 Nov 2023 15:16:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjKTUQF (ORCPT ); Mon, 20 Nov 2023 15:16:05 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21730C7; Mon, 20 Nov 2023 12:16:02 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c88750e7d1so10141321fa.3; Mon, 20 Nov 2023 12:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1700511360; x=1701116160; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UN/JaGs58VC/59LNr+VTcKEJIUnlEUBkYK0zXNn4XiM=; b=RgP6LbXNj8T/rWOEBj+R++Mu7IMJuqWdFn6TUIlD6NNy3Kks8f2op+6RUbhjlIasDz Itt33d2X0W/SO8vvbx7Jh39rK0Mv85+gvMWw/k8hqNER3biUd8zkM3XnbM7sodxGZS27 I60kvj+d/iARZWLGQx1T6KsJnwBm7PVSXXdJFeSETX6NvUfygsX1AYU+ORb6wZ6mSsoB GtS0Lgdsa7PnzHcAAHZXT/K4EX8EF6699iCQvKFWYpZXer1gTeVPNpi84VRK1m+YY+8Q FxZcrq2fuRFuHNf1GUX4HQgnB7661+Rfgb0J+qyuftVLzqEbKt6aLazdOcxIe+lEMCQM Qi4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700511360; x=1701116160; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UN/JaGs58VC/59LNr+VTcKEJIUnlEUBkYK0zXNn4XiM=; b=W/S+c20oGZXInKuQZfjBzr7fHBXcuKRvftCmkZRtxVo/ZTrKVjsiIPoBmXp42W5qx8 oPEE7BGzbKAGOJnYkn+GSzRb7IyJEGXHCscCjpa/L2aV1lh5eFOGzT1rR8lbUEvHUV86 IQAZm9+1Mt2y66m/q7bLEGGxMkuWwIhL659sV1xBQIc8K3sSATIGHmc6GYYEvZCKgqXO ihqLmZkljz8tVHYO3/gMj0NMCruMSaEnNJ5MDwmQV9GuBlRDsZB5RIdC3mduvp4/LuGT 7Phhe31SdKvyGYW0uiGBJgb405QOUPwc09FvB1eZ8uQfcd8Ra3ZtGpsvNB5pSLan+A5e Z3Ag== X-Gm-Message-State: AOJu0Ywh+LKRwUpT3HtgMCk+7IW4hXKxsDovGWIvhLX8KegALgxhHsKt egBWjwLEGeK6lYGtnmwOKrG5RCXgTT+j/MgFHGg= X-Received: by 2002:a2e:a30c:0:b0:2c5:ab3b:d676 with SMTP id l12-20020a2ea30c000000b002c5ab3bd676mr6035262lje.9.1700511359989; Mon, 20 Nov 2023 12:15:59 -0800 (PST) MIME-Version: 1.0 References: <20231114-topic-amlogic-upstream-isp-pmdomain-v1-0-f01e6fca67a0@linaro.org> <20231114-topic-amlogic-upstream-isp-pmdomain-v1-2-f01e6fca67a0@linaro.org> In-Reply-To: <20231114-topic-amlogic-upstream-isp-pmdomain-v1-2-f01e6fca67a0@linaro.org> From: Martin Blumenstingl Date: Mon, 20 Nov 2023 21:15:49 +0100 Message-ID: Subject: Re: [PATCH 2/2] pmdomain: amlogic: meson-ee-pwrc: add support for G12A ISP power domain To: Neil Armstrong Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Ulf Hansson , Daniel Scally , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 12:16:17 -0800 (PST) Hi Neil, On Tue, Nov 14, 2023 at 11:19=E2=80=AFAM Neil Armstrong wrote: [...] > +static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_isp[] =3D { > + { G12A_HHI_ISP_MEM_PD_REG0, GENMASK(31, 0) }, > + { G12A_HHI_ISP_MEM_PD_REG0, GENMASK(31, 0) }, I expected this second line to use G12A_HHI_ISP_MEM_PD_REG1 (note the number at the end: 0 vs 1) Is this correct? Best regards, Martin