Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2497894rdb; Mon, 20 Nov 2023 12:29:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHOEWLcmGZJAAsE41iH/CLoRlngYvuT8BvTzAl94qW8UmP2CoOw4ZxuqWVaxzUUFl8MKYL0 X-Received: by 2002:a17:902:e88a:b0:1cc:5dd4:7ce5 with SMTP id w10-20020a170902e88a00b001cc5dd47ce5mr8835147plg.19.1700512156763; Mon, 20 Nov 2023 12:29:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700512156; cv=none; d=google.com; s=arc-20160816; b=trVWRYbIPoTOsgmpSTgzybDm8H/dXr6TyXIURDcDEOx9akCBbvzgi3jw3/q+GLn86x m4oNmMf0vZFSuCm/p8Z8C7Si5r9UrluZHAsKQBOzhVMjssXNpsqJYP1ZqrcBo/HRt7De bIf/7mIAK1oJ7sf5w96lq3Q1aiZf99tYT7JT2XVZoJ5TthH8hVO+VfSa9NITfi3CMBCT 7w8a1fL886r7fV18j4tJt1jw8Ny+nbcHnsbvLoR3m9gjqG7VQGUwOUoPs+T592qMsG+J MbBDXQKFMcTchfCt/brno+PjjLm5F8+fIX9cUWlraWWVao7+On3FPnJ+rPuK1brGa4lX dt9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Hja1MQss1Gr+UnRtsMlNn4zuJhGTC9iFvbiWNu8UfhM=; fh=TvWjZoqja2JadgDJEvKA1fuBi4k/dCJvs1hv5tV8aA8=; b=lC7W7aVpQXC+MZZ1hYz30wW0OAieIdarF17Fi2sPlsBE/nJzuRptDN0Sj/r4Pf5NVl TP5YJtfsIbk8AGtI2xJMxhd/0azNSNtqM5ZXOns0A03VrZzEs8ox0iHiVKXJLQydElGK LsUDjj6AItBm34YNQAxdDMTwKvdY+mgVkabUnJLUJduJOzFmdGzblQ10tYrQVWUsEdMc qYKwCtSoWyLFiliXxrUiBCFvh3iUmAbqsYQA+FG+QLxBxGIPY+N+u8K7y+nrmFIdfrBg igOGtvZ6zrI9EiVhNjhWSSUj/91GSWDWkfCPPenWOdLTAH3t/5KkUoHmPxh1D/qLf097 KhGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=k3n50MQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id l9-20020a170902d34900b001c62e8c0a38si8566238plk.256.2023.11.20.12.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 12:29:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=k3n50MQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EB8608056A3F; Mon, 20 Nov 2023 12:29:13 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230170AbjKTU2u (ORCPT + 99 others); Mon, 20 Nov 2023 15:28:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjKTU2s (ORCPT ); Mon, 20 Nov 2023 15:28:48 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66F4EC3 for ; Mon, 20 Nov 2023 12:28:45 -0800 (PST) Received: from notapiano.myfiosgateway.com (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 518FF66071D4; Mon, 20 Nov 2023 20:28:41 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1700512123; bh=gCwZgV8zJpLMsi8EPwsQoJVBIyq0juJd2X+ekA2F1+c=; h=From:To:Cc:Subject:Date:From; b=k3n50MQVYemXDQ0xWa4l3ho2D1Rr1/II7hG+Mr9k6DjxufxpvNbu3Jw5PdYW30po7 WxZHls2gEskNN9O7Qd9Iee1qJomMXTpRzebEaohbQa+xnOrtdJIbbUMBuorWwCJrgU 38PcqzeJjnGYVMttzXfA5X2hBA/KtL4YPRX0mN9SP6TWLujUK+k8XuyOvuFpKgC73p JItG09o7yRrL2mYHXhJCzeKqn3q52whMXhQb99ktIu0mOav1dFmhBm7HnuftMjjuOU AlCNpMHAPDKecVjzImr7btHiHQZtBeTe15yIplqN5dYq++dqqjU3utHgWUd7G4rl19 HdLZiMdPFgPSQ== From: =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= To: Chun-Kuang Hu Cc: AngeloGioacchino Del Regno , kernel@collabora.com, =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Bo-Chen Chen , CK Hu , Daniel Vetter , David Airlie , Dmitry Osipenko , Guillaume Ranquet , Markus Schneider-Pargmann , Matthias Brugger , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH] drm/mediatek: dp: Add phy_mtk_dp module as pre-dependency Date: Mon, 20 Nov 2023 15:28:16 -0500 Message-ID: <20231120202837.396760-1-nfraprado@collabora.com> X-Mailer: git-send-email 2.42.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 12:29:14 -0800 (PST) The mtk_dp driver registers a phy device which is handled by the phy_mtk_dp driver and assumes that the phy probe will complete synchronously, proceeding to make use of functionality exposed by that driver right away. This assumption however is false when the phy driver is built as a module, causing the mtk_dp driver to fail probe in this case. Add the phy_mtk_dp module as a pre-dependency to the mtk_dp module to ensure the phy module has been loaded before the dp, so that the phy probe happens synchrounously and the mtk_dp driver can probe successfully even with the phy driver built as a module. Fixes: f70ac097a2cf ("drm/mediatek: Add MT8195 Embedded DisplayPort driver") Signed-off-by: NĂ­colas F. R. A. Prado --- drivers/gpu/drm/mediatek/mtk_dp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c index e4c16ba9902d..2136a596efa1 100644 --- a/drivers/gpu/drm/mediatek/mtk_dp.c +++ b/drivers/gpu/drm/mediatek/mtk_dp.c @@ -2818,3 +2818,4 @@ MODULE_AUTHOR("Markus Schneider-Pargmann "); MODULE_AUTHOR("Bo-Chen Chen "); MODULE_DESCRIPTION("MediaTek DisplayPort Driver"); MODULE_LICENSE("GPL"); +MODULE_SOFTDEP("pre: phy_mtk_dp"); -- 2.42.1