Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231113102327.695386-1-james.clark@arm.com>
In-Reply-To: <20231113102327.695386-1-james.clark@arm.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 20 Nov 2023 12:48:38 -0800
Message-ID: <CAM9d7cj=nF_Vq7dPkOGvYd1G0nFOffiCoyZQ=hx1hco-0_ZMBw@mail.gmail.com>
Subject: Re: [PATCH] perf test: Use existing config value for objdump path
To:     James Clark <james.clark@arm.com>
Cc:     linux-perf-users@vger.kernel.org, irogers@google.com,
        acme@kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Yonghong Song <yhs@fb.com>, Fangrui Song <maskray@google.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Yang Jihong <yangjihong1@huawei.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

On Mon, Nov 13, 2023 at 2:23 AM James Clark <james.clark@arm.com> wrote:
>
> There is already an existing config value for changing the objdump path,
> so instead of having two values that do the same thing, make perf test
> use annotate.objdump as well.
>
> Signed-off-by: James Clark <james.clark@arm.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
>  tools/perf/Documentation/perf-config.txt | 8 ++------
>  tools/perf/tests/builtin-test.c          | 2 +-
>  2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
> index 16398babd1ef..379f9d7a8ab1 100644
> --- a/tools/perf/Documentation/perf-config.txt
> +++ b/tools/perf/Documentation/perf-config.txt
> @@ -251,7 +251,8 @@ annotate.*::
>                 addr2line binary to use for file names and line numbers.
>
>         annotate.objdump::
> -               objdump binary to use for disassembly and annotations.
> +               objdump binary to use for disassembly and annotations,
> +               including in the 'perf test' command.
>
>         annotate.disassembler_style::
>                 Use this to change the default disassembler style to some other value
> @@ -722,11 +723,6 @@ session-<NAME>.*::
>                 Defines new record session for daemon. The value is record's
>                 command line without the 'record' keyword.
>
> -test.*::
> -
> -       test.objdump::
> -               objdump binary to use for disassembly and annotations.
> -
>  SEE ALSO
>  --------
>  linkperf:perf[1]
> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 113e92119e1d..b8c21e81a021 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c
> @@ -518,7 +518,7 @@ static int run_workload(const char *work, int argc, const char **argv)
>  static int perf_test__config(const char *var, const char *value,
>                              void *data __maybe_unused)
>  {
> -       if (!strcmp(var, "test.objdump"))
> +       if (!strcmp(var, "annotate.objdump"))
>                 test_objdump_path = value;
>
>         return 0;
> --
> 2.34.1
>