Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 20 Nov 2023 13:53:03 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH] net: phy: correctly check soft_reset ret ONLY
 if defined for PHY
Message-ID: <20231120135303.0e64bc81@kernel.org>
In-Reply-To: <655bb7e5.5d0a0220.59243.9a2c@mx.google.com>
References: <20231120131540.9442-1-ansuelsmth@gmail.com>
        <20231120094234.1aae153e@kernel.org>
        <655bb7e5.5d0a0220.59243.9a2c@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 20 Nov 2023 17:50:53 +0100 Christian Marangi wrote:
> On Mon, Nov 20, 2023 at 09:42:34AM -0800, Jakub Kicinski wrote:
> > On Mon, 20 Nov 2023 14:15:40 +0100 Christian Marangi wrote:  
> > > Luckly nothing was ever added before the soft_reset call so the ret
> > > check (in the case where a PHY didn't had soft_reset defined) although
> > > wrong, never caused problems as ret was init 0 at the start of
> > > phy_init_hw.  
> > 
> > not currently a bug => no Fixes tag, please  
> 
> I know it's not a bug but still the referenced commit was wrong. Can I
> at least use Ref to reference it?

Not sure what you mean by "Ref"

> Due to the changes done to this function, it's hard to catch where the
> problem arised with a git blame.

Right, and you already quote the commit in the body. No objections to
repeating that if you want, maybe:

Introduced by commit 6e2d85ec0559 ("net: phy: Stop with excessive soft
reset").

but as a part of the "body" of the commit message, not tags.