Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <ea33eeed-e3a7-47bc-88f2-b7ab46be0aaf@intel.com>
Date:   Mon, 20 Nov 2023 14:19:17 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 4/8] x86/resctrl: Split the rdt_domain and
 rdt_hw_domain structures
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Shuah Khan" <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20231031211708.37390-1-tony.luck@intel.com>
 <20231109230915.73600-1-tony.luck@intel.com>
 <20231109230915.73600-5-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231109230915.73600-5-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wkk5QnFIdUNyc3JQNUVIbXc4MXlIaWp3TGl5Y1AzT040dlJCcDFzWkp2NUlN?=
 =?utf-8?B?WFRxdEhNUVd1VDgwS3pLOWJ2VlpYZDVNdVFVWFZyQXNpOVNXZ0RVVkwrd05i?=
 =?utf-8?B?Und2NUZ1c1lvWnpPUXQ1dGVTQlVQaHVNUjRodjQ1WVRlSzRsalR4LzVlNStv?=
 =?utf-8?B?b1AzbjZPZ05kM29SZCt4YnJQV244dll3dTN0QkZQckFNWmJiZUZuWXdJMjNM?=
 =?utf-8?B?T0hjRTZhV1Vwb1QrZEhNdFlzVjFBK1hudDFEcWYwblh5VE45M2lkVWdWWW5N?=
 =?utf-8?B?NDVYT3VrSlBuSVo0ekxVNHBQb3h3aDFJVG9mNUxiWWsxWlV4dmk3WUQwWVNU?=
 =?utf-8?B?TUNIbVJYTDdnWmpHQlplQmYrNWs5YXlpcFMvWHFFaXkvcDBrQktKZFdEdSsr?=
 =?utf-8?B?dVVIUEEvbDh0bFB0aWp3aXdMTzZTeWJCYmoxR1M2NVNTOEd6OEYzdVJKUzY5?=
 =?utf-8?B?dm4rVXZCWjJ5UDIxMDZwNHN2YzNvRFFZeDRpUUI2ODI3bXl5TmVJS2xEN2RE?=
 =?utf-8?B?c3lPcmFhWGdqbDdJSUdabDFqU0ZqOGdCRHBQUHYybUNweEhGTHM0NkpzVFJH?=
 =?utf-8?B?YmdZeXRJS2NkZXNzWFltN0d3RUJBV1hIRm5aYlRJSFV4Ym9FR2YxKzN1Nlh5?=
 =?utf-8?B?TU5yUXNWMXNzNWNyV2NVTDh2NnJ5MDllaUozRFliRUJnWUxzTkdVejhGRmdL?=
 =?utf-8?B?YWYxc1ZHbS9yMDFrMmZXc2M1cU1TeEIvSXNURlE0NjFiVnZFRHJlTU9BMm1Y?=
 =?utf-8?B?bTVWVzRWbmVIcjdYSW9CZzE5NTVBTUNQckVGampJWXdYcWE0dDdyUS82Q2g0?=
 =?utf-8?B?Z1NaYUJLY3hvTk1VWXBpVHB5MDY3dDNqMXpGQVBuUmxLWVF6QnpKcjBqM1Ey?=
 =?utf-8?B?K3Y5RTRuWEVQK2tLS2pLYzNtYkc4YmdnQVVORTVSMzVxRkVzamF0OFl5UGhl?=
 =?utf-8?B?ZGJ1ZkN0ZFB1U1c4Rlh4K25CeU9kTkM3N25xSUxkZEVsci8rTXVQcTE2WHgr?=
 =?utf-8?B?WGNCVURjL0pnM2UvSDJZMGtxUldkWUJaaG5aRFI1b2sxbVdLM3REZ1Nhdzcx?=
 =?utf-8?B?eldJRnhieUs5NU95R2tDNUxNS2dWb2NZSlE0S1FXakJRM04yNHBGUUhjMVNy?=
 =?utf-8?B?S25YSWRaSFJId2E2cG8xaVJZeTdpeDZKUW1EOHY1QjVvYnRsRnpyVjI2bCs1?=
 =?utf-8?B?SGhkNFhTbk1qNGxzWlFZblI5bWZadVZ6TVYyd1V2VFBBaG9ubk1yYmZmdnNR?=
 =?utf-8?B?NTFjUzhCK1oxdG5WUlpWaTBhQituN1BIUVFyOTNPaUFzWnpZZWRRUHhiYTFx?=
 =?utf-8?B?UDlRSHBwRmE4ZlQ5YU05UTd4TWR2YkI5cERGZEUzQ1dHeHBTYW5wZkxrYzRl?=
 =?utf-8?B?Q2tGbFIzbktKTHdITVkxUzBYSmw4UzFJdTJCcC9zNnltdXdWcm5JTFpRT3JH?=
 =?utf-8?B?SFFnazF4NkhXaTFvREJhdjBOVFloYTgwVWxZRWJPV1lwMXFWcFFyRkxWd09Q?=
 =?utf-8?B?eWpta200V3dEWXpDZXhvZm1tS3ZxUjNOSEc2OUpNSStRWjQ0NGlzYmplelNi?=
 =?utf-8?B?cTg3TkMxbU5XNFROYTY3TjBRTW41ektiNWxpZmVsaVcwcUVNdWF2QUNnQ3B6?=
 =?utf-8?B?dm5kQzE2Mzhzdy9mSWEzU1lDdUFOMlk4bFFNc1pqdTVWejdXR1FHemp1V0t4?=
 =?utf-8?B?ZG1lZjBySmN3Z2ZjMktZc1JBeXZrQ0pjdDZnVXJRN0JNb05uY01OejZTbDg3?=
 =?utf-8?B?WEtpYTZBby9RM1BOL1VBSWJ3RmhkeE1tT2E1WVN1T3U1ZmVwaXZnL2FYbUt2?=
 =?utf-8?B?bDQ3N1V5MnVjdWdWUzdsTitoT3R3RlhWK2ZQWVNzdzBCTWFrSDNTd2taSm5Y?=
 =?utf-8?B?MlJmc0gyblByVkVmem5QYndxaG56aWtnenBjZnNXYTBsRHNtRys3REtCSFpE?=
 =?utf-8?B?Q1FkcmRDOTQyV1RXV2QxaVlQNEJEaVU5Ym44R0RVYnZieFZSNWlVV1BKZTRZ?=
 =?utf-8?B?ZGtYUWg2MVE2OC9BemphT0dJSUhKai91OWlQL0Y5dTdQMXFlcXM2T2ZwOVpk?=
 =?utf-8?B?SGkwUVJjaUFpcmJNd05OaDFPQloxN2hrcllkVXJ0aUd1R3dvMytrVTRhd2ZF?=
 =?utf-8?B?ZzYyaVJsVUlrNzcyRjZNTjg1ckFjUVZ1d2xVMVZNQldWcnM4ZXZES0tQYUsz?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 788f78e8-6e5e-4469-d7b5-08dbea16bd2b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 22:19:18.8127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7bEdQHJOCKn8W9RPbWwZ9KDG80+7i1G3cYFxAdWeQStBk8yvGGwW7ZLPnSB/QnTesjg5glfnxPO6FkRRoToc0iB9RsaS048kDFBePEXn8ig=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4678
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 14:19:42 -0800 (PST)

Hi Tony,

On 11/9/2023 3:09 PM, Tony Luck wrote:
> The same rdt_domain structure is used for both control and monitor
> functions. But this results in wasted memory as some of the fields are
> only used by control functions, while most are only used for monitor
> functions.
> 
> Split into separate rdt_ctrl_domain and rdt_mon_domain structures with
> just the fields required for control and monitoring respectively.
> 
> Similar split of the rdt_hw_domain structure into rdt_hw_ctrl_domain
> and rdt_hw_mon_domain.
> 
> Reviewed-by: Peter Newman <peternewman@google.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette