Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <c6982c26-738b-43fc-a2d6-35fa7cf2c70c@intel.com>
Date:   Mon, 20 Nov 2023 14:24:15 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v11 7/8] x86/resctrl: Sub NUMA Cluster detection and
 enable
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "Shuah Khan" <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20231031211708.37390-1-tony.luck@intel.com>
 <20231109230915.73600-1-tony.luck@intel.com>
 <20231109230915.73600-8-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20231109230915.73600-8-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmNsZkprWnBNdDlBUjYzamRQcHhhZFhrNHRvMTBpb1pnVUV4VTB4cFlMK2tX?=
 =?utf-8?B?OEw4RHEvS0RIR3BEYlYrZEhXVlZ2SFN6dUNUM2tiTFJyUkp0ZFkveVp0ZWhn?=
 =?utf-8?B?eG04ZzQ1MjM1S0MwOHBGTEQ0K0ZYZEN4SEs3M3BOSWFtMDl1Tjh6RGlBVW8v?=
 =?utf-8?B?TXZCR1pNKzFBMm8wa0Y3M0FwTkJDWlhEYVo4d2haWDZGK2hGdEs4bGZlT2xI?=
 =?utf-8?B?YWhkZHZFNUtXeEEwNnd4SWJjUzYreTR4TGNyZGhsbmJsbEducG5UaG1JWmUv?=
 =?utf-8?B?NDlJWWthNjdtcnlMdTYzS1cxTWVDdHRndDlUYjQ4TmluZzRuejdrUUVSczF6?=
 =?utf-8?B?b1daSFY1TkFGZWI5WVJhZWhCWC85MXpqWHpadldQcTlaSk1kMFpRMWd0T2p0?=
 =?utf-8?B?WGZ6Y1lZUTRCYmtNQUxDZjNMeUlWZmY2bTAybi9nNzR1S0lqKzFIVXlzcHFh?=
 =?utf-8?B?b3dnNlRhR1MyR2JrZ0lUZU5pZ0o0QnVEbXFaUldjWDAvVTRVbDZXSnhzdG9D?=
 =?utf-8?B?emttemswdkloUXNvYy9Zd25hNy9ZWkFrdU9GL0ozdVdBQ09PMklHZzVUcG9W?=
 =?utf-8?B?V3RCb09oekJLRGV6RTArTkJxL0ZYeURWWkhWTmxlaGI5TVZHLy9SQ0dsb2xh?=
 =?utf-8?B?TW1LTERpTUJVMUNPRUZPLzZDU05YYVIyQXZ0bE9xbGw0NDZWdGxKY3lJQlpa?=
 =?utf-8?B?V1RZSWVaNmp2cFpucDc4TktpcUJ5UGlzL3FGOHhObGNOdDd1S1Z4Sk9LVkFk?=
 =?utf-8?B?d1BEUTRmVG9lblZlOHpueWwraFZLRDJhNEpTNVdaK0pEM1Y2UnNuc0VHeGxS?=
 =?utf-8?B?M1g0TWJwRnkyY3hkOVFEQzVNU3V4dDB1bFlnVURzZDRqSGVVYVY5dUQ2eW4r?=
 =?utf-8?B?MENJMWQzaEV2VEsyNzZOOGtHMXdlWWlnN0U0T1BCQVBjM0dHeVkvU2ZiMWk5?=
 =?utf-8?B?ZjlqYTBaUmxrUWFuOVQ3N04wZ3BQYWZHMnVxaDk5TXZWejNZNXdKQWR6UDh5?=
 =?utf-8?B?NWlWaVBTR2RwdGt6NXpEUkx2cUI5RGhJOFVSaFc3dHNqTXFwWFFtbWJZb1Z2?=
 =?utf-8?B?U2R3R216WkFLaDJEWmRxN00zN0tUSE9XTGFxNzB0SCtPeUVQekdTZDIrNlYx?=
 =?utf-8?B?aWdxNzE1L1B2UjNxMzU4aXRRalFvL0dSUFRxVHh3QVBCNENTM3M2SHRVRVFl?=
 =?utf-8?B?Z2xyY3JLN1Nzc3NpOXQ0cHRJeiszYXREdXZoMldhMmV1dGZaVVdaVG5TNE9E?=
 =?utf-8?B?VTR1SXhYVVZNNkJLUGIzY2ZXNkNrK1EwbUUyN1VKZldTdzkxQzNYNG1wWFNI?=
 =?utf-8?B?L3hldTVFb0NCSzFBdFA3dy9JRkxMUFhhbkpnOUVzZmRSaS9vWFEvbXFhMlk2?=
 =?utf-8?B?SFAxRHhoZjdIYkIvMVNsQXRXRjNIeFJjZ1dOMlhLa2l1ZEFkR0ZpNnhlaDhO?=
 =?utf-8?B?a0x3ejlHR0QzOTZHQ2EvSXdrUlBLd25RWGNrRElmVzRhSW5NWDRtNVYxMFB4?=
 =?utf-8?B?dHp2bk45Vm14OEFudU5HbUZ4QTZTa2NJZUdoTWs2QmY1c3J0dEs0VVpHOGQ5?=
 =?utf-8?B?RXo2dzlRZ1hDZ0ZaNzdjcG9BMWE3NnJrdG41WVNKRVA3UEZ6dkV5TFVYeFo0?=
 =?utf-8?B?emNSaXA1QytTOVJaazd5Yjl3VHNzSTloMmJ2cFZJZ2NkNVRVQ0tkUGFEVEhY?=
 =?utf-8?B?YUxmczhrVUc0OCtmWkt6QlVSTStzb25qMmlSUVRyZzJqNXpVRCthaEl0dDdU?=
 =?utf-8?B?UzZVNURGQWtxcUtuWWw2dVFINU8yMFo4c3Q4SGp4RnJobU9WZEJMaTJ3OTZ3?=
 =?utf-8?B?WTVoemdtdWFKc2F5MEVQYnp2blhta1htK2tacnF1ZEQwanJYenBtTHRIemda?=
 =?utf-8?B?REU4bHE4YUhJMS9pM1VVUTR0SFVIc0pIZkR0MDY1OEttSlU2TDNkMVFuMm5T?=
 =?utf-8?B?ODlKVnYwaktiREVUMHliTmZjZEN0SlZBTmg0Tngwc2owNmUrQXpmdUphckQx?=
 =?utf-8?B?dEpUVzl5S2QvTmRQMUNVdWhKWE9YOHpQUlFCOWJTK01EbG1rNEY3STdOU2xS?=
 =?utf-8?B?RzFFTWZLUHBNU0FzdnZxTmovMGF4ZWUxOUxtZnBkL0gwbUFvaTd5T3piZUcx?=
 =?utf-8?B?enB6VVIwek9IelozM1h1VXY4YWJxWVU2c2xZZFZSR0U0VHdBSUsvcG5zYm5t?=
 =?utf-8?B?UXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 96bd34ae-042c-4262-8f23-08dbea176ebf
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 22:24:16.7641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vA0vEVhNg2z+KYo7o9hs2mCKV+iBJFyAtZp8MnvvNhWDqj0Lyex8pqBSQGeuvz4adCdqQonp2eEZ4WSYdhU9HUW5nldrQ7SomRSZgG68AnU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6031
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 14:24:37 -0800 (PST)

Hi Tony,

On 11/9/2023 3:09 PM, Tony Luck wrote:
> There isn't a simple hardware bit that indicates whether a CPU is
> running in Sub NUMA Cluster (SNC) mode. Infer the state by comparing
> the ratio of NUMA nodes to L3 cache instances.
> 
> When SNC mode is detected, reconfigure the RMID counters by updating
> the MSR_RMID_SNC_CONFIG MSR on each socket as CPUs are seen.
> 
> Clearing bit zero of the MSR divides the RMIDs and renumbers the ones
> on the second SNC node to start from zero.
> 
> Reviewed-by: Peter Newman <peternewman@google.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---

(note ordering of commit tags)

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette