Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Date:   Tue, 21 Nov 2023 00:56:48 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, s-vadapalli@ti.com, r-gunasekaran@ti.com,
        vigneshr@ti.com, srk@ti.com, horms@kernel.org, p-varis@ti.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 net-next 2/7] net: ethernet: am65-cpsw: cleanup TAPRIO
 handling
Message-ID: <20231120225648.pgvzd2jejg5jll2t@skbuf>
References: <20231120140147.78726-1-rogerq@kernel.org>
 <20231120140147.78726-1-rogerq@kernel.org>
 <20231120140147.78726-3-rogerq@kernel.org>
 <20231120140147.78726-3-rogerq@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231120140147.78726-3-rogerq@kernel.org>
 <20231120140147.78726-3-rogerq@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?d6XpERhdQ0JGDkfAcYqqole2G46Z97Ud42lSc21g5wDSBZQngVOn1N9n1MeN?=
 =?us-ascii?Q?hE5iLEubz8pf+4jqXh1MYK+e6/Em8sgHudJb9nL2/laGuU0C39jvmeiiePt1?=
 =?us-ascii?Q?ZTHdnIyLjLet++E3u6doO19hQsOkJhnkatBhKfDIvW4yUo6369qNFIhJsGp6?=
 =?us-ascii?Q?L7iZJ+gV11K4KKZiAcvnaixj2FAyQ6Q1eL015XVHXY/t/OHcsxQORUrybPfl?=
 =?us-ascii?Q?hIHQu6sGXkWyoNTXT/LTVFCSACrOq9al4YIOAhPel1/G65/L4A57sKSMYs1C?=
 =?us-ascii?Q?TY66yaOWRIpYbXJ6lZ4BxDZRdA/CswFUOajhAIl/VluBCiWF02kaP8GC07fc?=
 =?us-ascii?Q?2Afht4JRMuOlaib1pRkX7JEeqIfTle44LOY140zkVE/ADjk07D2OfQVd09zX?=
 =?us-ascii?Q?QpEu7CyofjF9wnAy51A776jBRL82l8m/PHZcar2VGiOTEuZbkCQ24OdYrwRi?=
 =?us-ascii?Q?7UnZD4gn/hfqEI97E+DbBDJEzn0tYIVJEgHG/MXQCW3Mnkt+oCDUv2ZHjRh8?=
 =?us-ascii?Q?DxZlmSxESwc7zLzMJwXqCsI1Abv0qbuHnI1xKiKJyRcP0wXbjPcpJXW/cdJc?=
 =?us-ascii?Q?M7eRbVl+Mub6R0aPEK3eZr50XqyRwkVrfosCrxKcc8o6ckKcDUkJrRmTSmsH?=
 =?us-ascii?Q?DZLl+rxDrMmfhOd9C6+KzvJMMbv1YLMgthyQTNrIIGR9cpx82LnMwMoiYTBk?=
 =?us-ascii?Q?F0Mfp5hiOXc/pNaSz3HzJu7+4iGLjF2054iKX2WjvWOrSIdHH891wR+1jYHE?=
 =?us-ascii?Q?9OaTxYMW3emtwXhMO95BP+iT1vDPXAhQdUjhZZae6BRmPu1mMBSIhZBYIybc?=
 =?us-ascii?Q?K4u4QEthgndkTQFCVUnDMs3mEIiXB1UOwZhnAmM79pfCSG+jYGl+75VaYI7N?=
 =?us-ascii?Q?h8i6hbhVnP51JxAByOiQAx6GaGMI6yo+OV+Q5Yz6m7VGK7SQ01zbhBuVO/Ky?=
 =?us-ascii?Q?b9cVUILVOiQe8FmRc/7rp/jm59n0+82RHSWhHPIea3vv44Jk5RKwIPB2as5T?=
 =?us-ascii?Q?jMmF8pwupVWatT6GFCUzipt1IoNLCYnLc/m66vK433ZAYufhXFWeNllyomFW?=
 =?us-ascii?Q?PaisQyQSYhR+rSNW1/RM9Fv/PvR5sBivDpOFW5AOpUNGUcl7+wtdxmNQJlMJ?=
 =?us-ascii?Q?VwrqYPVGejl98x/fr2Ob4V7TfCNNqnQja03S02VkyRITLYOG5gCInDiC5SIs?=
 =?us-ascii?Q?MVSV+Q25nAj/AKPXxrxclQIpkSX/HVmOM6KoOBuyfwJeyo3DyxNzW8st91qP?=
 =?us-ascii?Q?Iewn4JlY00PYGrVusEE1J0Z3WJ1wcyPArqcHAKzfECMpv3H1m4aR7L8VmPbt?=
 =?us-ascii?Q?p6G0NeKTSuNzlJnNnPW8NY0OKodoyw8zd1OsyN4Jg9tH2eksl1DopaBXxd8o?=
 =?us-ascii?Q?5arqPxcVgcih5OfArpCQd4syCAjyKcsI4FBOGvBX4eW3Jr1kjZ0AvFkOM9h+?=
 =?us-ascii?Q?cyCIggQSMD6/aDwnH/NDy6sO+6XuEXC92ak1Fb+Kn6nr8jfGu8dL0AWJiTwb?=
 =?us-ascii?Q?P6/2OYKsqiOJojq11epGMHIZOjyJ1QIPYfDemhiHDPmAItJFXiUkax6KweLw?=
 =?us-ascii?Q?MYwsgVK+TiFX8Gw4AcYnMkXBrPQhHGkKHKnjJYepmhcu3KTnAMbYu9YxvvG7?=
 =?us-ascii?Q?jA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b2dc0ae-fc59-4a82-3156-08dbea1bfc9c
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 22:56:52.8029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8OD4pN35qfGuAf8tfN2iUt7n09XVtBAPaU+A+TkHLmJ0wbQYhgDzyWiU1drdefkOrbQLocAXbo7SYSOcywl+jQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8153
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 14:57:13 -0800 (PST)

On Mon, Nov 20, 2023 at 04:01:42PM +0200, Roger Quadros wrote:
> -static int am65_cpsw_configure_taprio(struct net_device *ndev,
> -				      struct am65_cpsw_est *est_new)
> +static void am65_cpsw_cp_taprio(struct tc_taprio_qopt_offload *from,
> +				struct tc_taprio_qopt_offload *to)
> +{
> +	int i;
> +
> +	*to = *from;
> +	for (i = 0; i < from->num_entries; i++)
> +		to->entries[i] = from->entries[i];
> +}

I think I mentioned this before: have you looked at taprio_offload_get()
and taprio_offload_put()?

> +
> +static int am65_cpsw_taprio_replace(struct net_device *ndev,
> +				    struct tc_taprio_qopt_offload *taprio)
>  {
>  	struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> +	struct netlink_ext_ack *extack = taprio->mqprio.extack;
> +	struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
>  	struct am65_cpts *cpts = common->cpts;
>  	int ret = 0, tact = TACT_PROG;
> +	struct am65_cpsw_est *est_new;
>  
> -	am65_cpsw_est_update_state(ndev);
> +	if (!netif_running(ndev)) {
> +		NL_SET_ERR_MSG_MOD(extack, "interface is down, link speed unknown\n");

The extack message doesn't need a \n.

> +		return -ENETDOWN;
> +	}
>  
> -	if (est_new->taprio.cmd == TAPRIO_CMD_DESTROY) {
> -		am65_cpsw_stop_est(ndev);
> -		return ret;
> +	if (common->pf_p0_rx_ptype_rrobin) {
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "p0-rx-ptype-rrobin flag conflicts with taprio qdisc\n");

Also here.

> +		return -EINVAL;
> +	}
> +
> +	if (port->qos.link_speed == SPEED_UNKNOWN)
> +		return -ENOLINK;
> +
> +	if (taprio->cycle_time_extension) {
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "cycle time extension not supported");

Here it's ok.

> +		return -EOPNOTSUPP;
>  	}