Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
MIME-Version: 1.0
References: <20231115071109.11511-1-zhujun2@cmss.chinamobile.com>
In-Reply-To: <20231115071109.11511-1-zhujun2@cmss.chinamobile.com>
From:   Ian Rogers <irogers@google.com>
Date:   Mon, 20 Nov 2023 14:57:26 -0800
Message-ID: <CAP-5=fWvnEaNSMRRNEF1ijX_AcuP-AM0rfPnRZ9kr7iYeKzeTA@mail.gmail.com>
Subject: Re: [PATCH] toos:leds: Fix printf format string in uledmon.c
To:     zhujun2 <zhujun2@cmss.chinamobile.com>, david@lechnology.com
Cc:     acme@kernel.org, ast@kernel.org, namhyung@kernel.org,
        kuba@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Nit in the subject: toos:leds: -> tools/leds:

On Tue, Nov 14, 2023 at 11:11=E2=80=AFPM zhujun2 <zhujun2@cmss.chinamobile.=
com> wrote:
>
> When the argument type is 'int',printf '%d'
> in format string.Problem found during code reading.
>
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/leds/uledmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/leds/uledmon.c b/tools/leds/uledmon.c
> index c15a39c1f271..62befe06eab5 100644
> --- a/tools/leds/uledmon.c
> +++ b/tools/leds/uledmon.c
> @@ -55,7 +55,7 @@ int main(int argc, char const *argv[])
>                         return 1;
>                 }
>                 clock_gettime(CLOCK_MONOTONIC, &ts);
> -               printf("[%ld.%09ld] %u\n", ts.tv_sec, ts.tv_nsec, brightn=
ess);
> +               printf("[%ld.%09ld] %d\n", ts.tv_sec, ts.tv_nsec, brightn=
ess);
>         }
>
>         close(fd);
> --
> 2.17.1
>
>
>