Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 21 Nov 2023 01:44:03 +0200
Message-Id: <CX41E533XH4S.1B6IZCU0PKPL2@kernel.org>
Cc:     <keyrings@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>
Subject: Re: [RESEND PATCH v2] sign-file: Fix incorrect return values check
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Yusong Gao" <a869920004@gmail.com>, <davem@davemloft.net>,
        <dhowells@redhat.com>, <dwmw2@infradead.org>,
        <zohar@linux.ibm.com>, <herbert@gondor.apana.org.au>,
        <lists@sapience.com>, <dimitri.ledkov@canonical.com>
References: <20231120013359.814059-1-a869920004@gmail.com>
In-Reply-To: <20231120013359.814059-1-a869920004@gmail.com>
Precedence: bulk

On Mon Nov 20, 2023 at 3:33 AM EET, Yusong Gao wrote:
> There are some wrong return values check in sign-file when call OpenSSL
> API. For example the CMS_final() return 1 for success or 0 for failure.

Why not make it a closed sentence and list the functions that need to be
changed?

> The ERR() check cond is wrong because of the program only check the
> return value is < 0 instead of <=3D 0.
>

Lacking Fixes tag(s). See: ttps://www.kernel.org/doc/html/latest/process/su=
bmitting-patches.html

> Link:
> https://www.openssl.org/docs/manmaster/man3/CMS_final.html
> https://www.openssl.org/docs/manmaster/man3/i2d_CMS_bio_stream.html
> https://www.openssl.org/docs/manmaster/man3/i2d_PKCS7_bio.html
> https://www.openssl.org/docs/manmaster/man3/BIO_free.html

Replace with

Link: https://www.openssl.org/docs/manmaster/man3/

BR, Jarkko