Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp89174rdf; Mon, 20 Nov 2023 17:32:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWcARjHkzPm24wmfRpTgaslPUl3b0aOJiql145jAPbhow9nElLG4OXJ1v0/J9t3SgsU6aC X-Received: by 2002:a05:6808:487:b0:3a8:83df:d5a4 with SMTP id z7-20020a056808048700b003a883dfd5a4mr9956398oid.59.1700530328009; Mon, 20 Nov 2023 17:32:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700530327; cv=none; d=google.com; s=arc-20160816; b=b8SHID+MdqDdOxeJucDQ3Mm5Qv4T59ztFFvnEk3VNHB8r/wvvTaB2mVITSaTjMinQh UNwpc5pn5Ux/IPPL/RZAXv7tIAlKCNOdO33KXi0rHN7zSnt6bitaYllnGENc0uvpB3a8 xroqaplAuH+BFo/vapQbsdzASkvjC2Oq9n/uCD8sdPQJ++N6EL4BoWbJ4EzsWF3mEi3g cINQmUAPyv9264KTqiAzkHOdC6IZ4ZYwzz54yUnOrLLeAKG/cBihgxRrr0QCNrQYenq4 mCwZSxkBlKE972q8q3lPihN2WCWIBmru8FZxdn8FXJUFy3JYBnFulMhdDzTNM45Vs9JS ofVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:date:message-id:in-reply-to:cc:to:from :sender:reply-to:subject:mime-version:dkim-signature:dkim-filter; bh=r7FUgwAb5MWY8DmPizGyFQBrKuzR2qlvMD2L01WpRUU=; fh=W5CqwNd4uWcuFWotDa1QNpP4P08sMCm7legHQCfOiy0=; b=TGqPiFNfIU6N2N4NPE99ZMPreI1pS2+N0sePXZXlR+wszcODUeCm3L3t2Y+Bgy17bW O+0UDlE1DWWp92o/XiGACLhgdpTlYveByhgtgSSxx74IK31xVx4TNppr+oGBIVWTCgGN E5FiWaGorXVXd4uGPaHhra/bZbV9TllZkVkwpgrPhzZ5+Cvx0G9m1ni+1bs/Dpsb4hOa fv9MdaGsDBtQX2uCNaghx+HWIVU914m+6RPpMDwGE/keidtbpz2XIc3urXhgNBjyyo7A LZunNm+IaAweo7R86lr3Y6nLQ3SJFUN9EXqlBcGzqUFYVg9ERHQdsjviNUAA1ki72X9w XAZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=rOdNLa5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id bz14-20020a056a02060e00b005bce8cfb592si10364542pgb.245.2023.11.20.17.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 17:32:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=rOdNLa5+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3748D8078294; Mon, 20 Nov 2023 17:32:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjKUBb5 (ORCPT + 99 others); Mon, 20 Nov 2023 20:31:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjKUBb4 (ORCPT ); Mon, 20 Nov 2023 20:31:56 -0500 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FE30A2 for ; Mon, 20 Nov 2023 17:31:52 -0800 (PST) Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20231121013148epoutp0114b194f19a3f34ef1e7004b401576d53~Zf0402WYL2917729177epoutp013 for ; Tue, 21 Nov 2023 01:31:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20231121013148epoutp0114b194f19a3f34ef1e7004b401576d53~Zf0402WYL2917729177epoutp013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1700530308; bh=r7FUgwAb5MWY8DmPizGyFQBrKuzR2qlvMD2L01WpRUU=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=rOdNLa5+qmIMPep1oXJSbiw4L7VJfSwZ2d2Y2DIJhS1qp/B2//B0BMctafTNqp/rx iMyk+Q/1tAjmAyiuKAMQQq5HEQCJjkzwcwqC3pleGLYQapJ2Ug1cDUmd2vRTEW3kkk XljQMOOcTxw/o520eqX9gCCdlOcD/ZxkkJhDPXqA= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20231121013147epcas2p4287f4c07f8f51285a02e63583d91304d~Zf04b9Buo1419714197epcas2p4V; Tue, 21 Nov 2023 01:31:47 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.90]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4SZ6Kv1LX2z4x9QH; Tue, 21 Nov 2023 01:31:47 +0000 (GMT) X-AuditID: b6c32a48-bcdfd70000002587-cc-655c08834f57 Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 5D.23.09607.3880C556; Tue, 21 Nov 2023 10:31:47 +0900 (KST) Mime-Version: 1.0 Subject: Re: [PATCH] nfc: virtual_ncidev: Add variable to check if ndev is running Reply-To: bongsu.jeon@samsung.com Sender: Bongsu Jeon From: Bongsu Jeon To: Krzysztof Kozlowski , Nguyen Dinh Phi , Bongsu Jeon CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "syzbot+6eb09d75211863f15e3e@syzkaller.appspotmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20231121013146epcms2p1587bebc341f17406625e8b0490b6ab1a@epcms2p1> Date: Tue, 21 Nov 2023 10:31:46 +0900 X-CMS-MailID: 20231121013146epcms2p1587bebc341f17406625e8b0490b6ab1a Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHKsWRmVeSWpSXmKPExsWy7bCmhW4zR0yqwdarnBZbmiexW+x9vZXd 4vKuOWwWxxaIWcx78ZrJYvOcO0wObB47Z91l97hzbQ+bR9+WVYweM9+qeXzeJBfAGpVtk5Ga mJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0X0mhLDGnFCgU kFhcrKRvZ1OUX1qSqpCRX1xiq5RakJJTYF6gV5yYW1yal66Xl1piZWhgYGQKVJiQnbH/31mm gh1sFe+/qjYwzmDtYuTkkBAwkZi5aBJzFyMXh5DADkaJI9+Ws3cxcnDwCghK/N0hDFIjLBAi MWP/YxYQW0hAUeJ/xzk2iLiuxIu/R8FsNgFtibVHG5lA5ogIdDBKbNj0DcxhFnjNKHGu5Rwz xDZeiRntT1kgbGmJ7cu3MoIs4xSwk7iyTQYirCHxY1kvVLmoxM3Vb9lh7PfH5jNC2CISrffO QtUISjz4uRsqLiXx6eEZVpCREgLZEt/72EBOkBBoYJS48/Yu1Fp9iWn3FoDZvAK+Eu82LgOb wyKgKjH35gYmiBoXifnvXoLNZBaQl9j+dg4zyExmAU2J9bv0IcYrSxy5xQJRwSfRcfgvO8yD O+Y9gZqiKtHb/IUJ5tnJs1ugrvSQWLptAdsERsVZiICehWTXLIRdCxiZVzGKpRYU56anFhsV mMCjNjk/dxMjOCFqeexgnP32g94hRiYOxkOMEhzMSiK8W9hjUoV4UxIrq1KL8uOLSnNSiw8x mgJ9OZFZSjQ5H5iS80riDU0sDUzMzAzNjUwNzJXEee+1zk0REkhPLEnNTk0tSC2C6WPi4JRq YAoTb9JIunzx0VkrPq23bzayVjeGG56Xub9A1fzc5et/2JkzGmQC7fMPTlx6JOP5Zw45x1tL 3WavTbyp65q/2PaR3u2ejckrBJSeVh9q0P06I4/v9Lf3rg81lpskLD8u8O15f/imsOB+04OV q/8u+K+wd88O7R7dNZoHfzLdeFooPv2ptX6NxvL4OL4J+6UKrzl3TQgJ0SnUqb6Rdn1+R5Dy Pa/LP7/71EhNnuD+3Dme5dO7z/wdscvYgn54393X+lHT6HBe0/1DlUcrmw5ez5WVeDwnzca4 w0JfM+92m56oON+8NDO3uwXCO19vytrMknFwgX95m3PldF+G896xBuo/Uq69jmjXsXv5Ytms eiWW4oxEQy3mouJEALyijjMRBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20231120184433epcas2p23e9f5db776d46ad8dd77a16dd326c1bc References: <20231119164705.1991375-1-phind.uet@gmail.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 17:32:05 -0800 (PST) On 20/11/2023 19:23, Phi Nguyen wrote: > The issue arises when an skb is added to the send_buff after invoking > ndev->ops->close() but before unregistering the device. In such cases, > the virtual device will generate a copy of skb, but with no consumer > thereafter. Consequently, this object persists indefinitely. > > This problem seems to stem from the existence of time gaps between > ops->close() and the destruction of the workqueue. During this interval, > incoming requests continue to trigger the send function. Dear Krzysztof, Even though i agree on this patch, i think that NFC subsystem could handle this scenario not to trigger the send function after close. Do you think it would be better that each nci driver has the responsibility to handle this scenario? Best regards, Bongsu