Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231115004932.650702-1-ak@linux.intel.com> <CAK7LNASS1YWdqW5TUXQ0iC3vgoDbUf-M-cRX0BvrkOV8HPyjxg@mail.gmail.com>
 <ZVu8u+oofXO8iwyf@tassilo>
In-Reply-To: <ZVu8u+oofXO8iwyf@tassilo>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 21 Nov 2023 11:20:50 +0900
Message-ID: <CAK7LNATFPWRaQb876p4=5K0H-Uc7KCLsVNnYVdxSypzmmfSv9A@mail.gmail.com>
Subject: Re: [PATCH v2] kbuild: Add inline-account tool
To:     Andi Kleen <ak@linux.intel.com>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 21, 2023 at 5:08=E2=80=AFAM Andi Kleen <ak@linux.intel.com> wro=
te:
>
> >
> > > +    sym_sizes =3D [syms[x + 1] - syms[x] for x, _ in enumerate(syms[=
:-1])]
> > > +    sym_total =3D sum(sym_sizes)
> >
> >
> > This is equivalent to
> >
> >       sym_total =3D syms[-1] - syms[0]
> >
> > isn't it?
>
> No it's not when there are gaps in the symbols, which always happens in
> the kernel.  The previous version used the range but that led to inbalanc=
es.


I do not understand because there is nothing to handle gaps
in your code.


get_syms() appends only 'pc' into the list.


Then,

  sym_sizes =3D [syms[x + 1] - syms[x] for x, _ in enumerate(syms[:-1])]


computes each symbol size by:

   (address of the next symbol) - (address of the current symbol).


So, your code is equivalent to:

   sym_total =3D syms[-1] - syms[0]


> > def get_ranges(syms, threads):
> >
> >     ranges =3D []
> >     prev =3D syms[0]
> >     i =3D 1
> >
> >     while threads > 0:
> >
> >         boundary =3D prev + 1 + (syms[-1] - prev - 1) // threads
> >
> >         while syms[i] < boundary:
> >             i +=3D 1
>
>
> Note the boundary is not the address, but the sum of symbol sizes
>
>
> -Andi

--
Best Regards
Masahiro Yamada