Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: RE: [PATCH v6 3/6] iommu: Add iommu_copy_struct_from_user_array
 helper
Thread-Topic: [PATCH v6 3/6] iommu: Add iommu_copy_struct_from_user_array
 helper
Thread-Index: AQHaGVcISf8BaZEQJUSSGRR/7aBQN7CC4RvAgACZOwCAAJ1hAA==
Date:   Tue, 21 Nov 2023 02:48:40 +0000
Message-ID: <BN9PR11MB5276B273F59D66A757B178AB8CBBA@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231117130717.19875-1-yi.l.liu@intel.com>
 <20231117130717.19875-4-yi.l.liu@intel.com>
 <BN9PR11MB52763299F886D4A534D6E0BA8CB4A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <ZVuWdEwYw+9uAaUz@Asurada-Nvidia>
In-Reply-To: <ZVuWdEwYw+9uAaUz@Asurada-Nvidia>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n0rVZN2KLNh3JsPz/wc5sRXGuQxYFcOAClSffj/WUkVULYJ4oinIFLba/lJs?=
 =?us-ascii?Q?8xh/F+YiUfHj5aD1FiLUwG6yscMgUggASinpypZYRvL3zWmOe5EQchfIEq8q?=
 =?us-ascii?Q?fR9i3SZBmmOvdM5HvpO8RmZXBwL38Iw7YQiFUMkOuRohIoH2ntlvsQl6SWVJ?=
 =?us-ascii?Q?F+WuVXo84VjQHMfMfG5WLtS7kUwH0hLmSn6F5fjIO4bthTZ8nMnh24rRknj8?=
 =?us-ascii?Q?Uf3cDiFxHX3XOgXSXWYc89aXK7QNil3KSfNNXb87EyGQY5fFd0IblCCY61eD?=
 =?us-ascii?Q?iYgY5VQc67qjh5bzzO7cfTQ4edkq22tSFhM2WPRtt0xFBOs4RSqtU6x6W8b7?=
 =?us-ascii?Q?+6GjL4YaV0pj2f0OyFzm4qBBuWFnSeROA9kaU1DSCGGrOszNEzIG+NYBq2yL?=
 =?us-ascii?Q?naCAROracVN3ijw7ce/urVNTzmmhPKxl1T0/2DG6SxvIbMYvt883y8CSpJpw?=
 =?us-ascii?Q?GYKTVrKe4vB+2ZaGbt0vqnQQIsm5gcrPz/foljCFqprcbrccqxxk2FJQHZhJ?=
 =?us-ascii?Q?rgyP4zT0ba0No/AjYPV1UAGs74vwzadyFBRtaCex8dSy3k1qGXiHeShE2lKx?=
 =?us-ascii?Q?+BecbqyzF2yq4vP2sVu1foBdybxAvxY4BeVpNXbofDCYHwsgMU0SpPsJMJll?=
 =?us-ascii?Q?Ty080S6+pSP5Se/HlcdjZP9bRxvBJHhHYPrMZ7iqnQ+j4gyeCNznUT2v2aiP?=
 =?us-ascii?Q?lKXq2MXRxKGbNqNuUu74Xhq6PzIfS02IGIAQ4et+30eQsMrKzHQ2CDVoujEK?=
 =?us-ascii?Q?3E+W6bQqCyo/XvVRTxkJfrVZ3jRvVRveZFH1BTnBSoqqPb16NZpV1AM4bcXt?=
 =?us-ascii?Q?C5yj0cpiFDrXOOcEA3v6ZBGeoGhD8N7CPavvse95m6RCdh4dD2VXEGVZn1ni?=
 =?us-ascii?Q?oxLNFiOdWnX0YS6UqZBre96iVjW8V3FZKoMD4O2nT3d0hzB/5/YMavPC9x49?=
 =?us-ascii?Q?P9gjVykmNl7wwf5GbBgWcVhOtmI1EipwL6BWCb69ipkqtrRCOaUuAa5lTHai?=
 =?us-ascii?Q?jBjbDPmi+cE9fOXsXxWto+TstTErTXzvQdejgB3A5p2YZZm6IiVg8wjDsLyJ?=
 =?us-ascii?Q?eCwkvkb/QVpGJQJ+Uqss4T3MebjPHtxXGRTiNPA73ESK2k11/C8SxNWQE9Qy?=
 =?us-ascii?Q?s80XNVYSwPpft+8L6GWP5qLuaim60kyBzR8qDQbGN0+qMiSNHdyW3Ni4jG6R?=
 =?us-ascii?Q?tDT2vgVSklmvQS6p5Juq2GGMkTWH+by+Sqov1ldkpyqBfHD4pOKEEBcgjwJv?=
 =?us-ascii?Q?fJSMcgjIWbJxBlNuDgjClTRmwEfwcjBsGkODRIw1oYwqjD4z3dcJk7DoUy1e?=
 =?us-ascii?Q?HvWdkDiTwynUNiO/Kj6+SH+3gATP7VKPXBEIn4AgF0LXC3VgTkd85/sSgmsn?=
 =?us-ascii?Q?vAqXH4OWqoEtJT2pg7210bUN+uddvNrh1hPqX1YoOCb3Nc1CU14l104MV9Jp?=
 =?us-ascii?Q?xhFhYk0UiISxWzcXzW0SP+d5nebCaqaN0SA/0ItHLpaCE6HDiykPSZQgyqEt?=
 =?us-ascii?Q?/7Miazgz2RGOSCe9MVEshXwqtmfgjfAbvnsqMR0fRFpWQMXrM9pnQ32XzDpn?=
 =?us-ascii?Q?5Jekj/WnsgJzGI1Inv7caf/OoEIqhGkXJo8Ff/mE?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e7bb829c-de4a-4356-a99e-08dbea3c5e13
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 02:48:40.0338
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OOnw/pYQaA590/zFldq2xoRkRb0kTv3RzJCNdPcgIKKJHsqUzaO5p5+38k7h6T1iVzYImaUATNFSIytaOgBm9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4612
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 18:49:00 -0800 (PST)

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Tuesday, November 21, 2023 1:25 AM
>=20
> On Mon, Nov 20, 2023 at 08:17:47AM +0000, Tian, Kevin wrote:
> > > From: Liu, Yi L <yi.l.liu@intel.com>
> > > Sent: Friday, November 17, 2023 9:07 PM
> > >
> > > +/**
> > > + * __iommu_copy_struct_from_user_array - Copy iommu driver specific
> >
> > __iommu_copy_entry_from_user_array?
>=20
> I think "struct" and "entry" are interchangeable. Yet, aligning
> with the {__}iommu_copy_struct_from_user seems to be nicer?

ok