Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Tue, 21 Nov 2023 11:20:05 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH 1/9] KVM: x86: Rename "governed features" helpers to use
 "guest_cpu_cap"
Message-ID: <ZVwh5TO7ANpfjpzV@chao-email>
References: <20231110235528.1561679-1-seanjc@google.com>
 <20231110235528.1561679-2-seanjc@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231110235528.1561679-2-seanjc@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vetYOmj2NzKPKRPvSxhsPHPQsOmauYV9qXHg37HHZ+1KcUNRLIEiX+B78IEO?=
 =?us-ascii?Q?QS5SSW0ySyBs86w5pmb8ku+w3hlG4udNNkQMDFGxd2axaZN6vL/qJvP9zvBW?=
 =?us-ascii?Q?+N1qK9i7mxk7cXE4AM9pwhlWBUW5WxreLgTZHvLSrukDuF8nCG1fFmeA6/mJ?=
 =?us-ascii?Q?SQS+5MuLpbRrdNWL6EZXxWvmRk/ERhqAIzz4dHK0Fmyg4Oeps6mWJpvKwmuL?=
 =?us-ascii?Q?YMPyqnhW3caNOc9XoM/hmY7KILTM1/v0WFPxwJQ2/Fa+FTSMmPDm+vXXekRv?=
 =?us-ascii?Q?PgePKX1h7EqRE8do6dN878txxs+WkAV9J9p+pCdKvSG27ayeszG8Qj0TWJoJ?=
 =?us-ascii?Q?KrKPXQLIXZp+QWrHLS3RSkq7/Q3u5S3WTNaaUvcKcme2v8BZiNEsM/3Xbnkr?=
 =?us-ascii?Q?T7attbfxWUrkgF1TkY33hfJ+OcvUoN+lcN34dCeaSwrikEFyr/ltZfLpV/MO?=
 =?us-ascii?Q?D11ERpasw4IMZ0VxHghrhAFRmKlwHN0k4RbMNZwElKXdIJR0b3yTIKxUrnVC?=
 =?us-ascii?Q?PBHZzqBvtQPm8oOQnj6aObbWJLaztv9CMd2p+lwEV0Fq/NX9Efj6+bHBk6rp?=
 =?us-ascii?Q?jmHShycpUCbPgH4prRNpUJJQFKnpACHzqZSt9OemuzWn+t6fSGCRLqrN1x1+?=
 =?us-ascii?Q?fmhUA1dEO3v46lraxXTeX3IRgLNTo5qK3DH+fMf9UBKoUmZlGTFzeUJg+aah?=
 =?us-ascii?Q?NsAfExg8Sb9Kv//d4aY/Cv/BvmHlOz5MxCCz8sPSeFdpjsO3XdAJde7juvzz?=
 =?us-ascii?Q?BMUNpod0yz78ppp38pJQ5ubAwwT1znVUjZaTDE7jQ0ep3B9iY6W5ujBeU2cy?=
 =?us-ascii?Q?VX5b44vv3PoPPdy9THfcZz0iR4grz0OfAx1X285LT9++0ga6PutK8nnHPTDg?=
 =?us-ascii?Q?n+fYwHt2ZayeZ9cWc8F8RaNWEOGs3ptep7nSphHHxNTklEq2SSG+PwyxegCt?=
 =?us-ascii?Q?Mps8EG12DqChXz4e9z3ONuhtsk8R+aWqQk5uqoftlcsQOhgs3MpwjS0dB/XA?=
 =?us-ascii?Q?wE1qvfA5XajrUYpU74ZZ6C2CqXG2M2BnQL5douEdndPFrSOGzGv9Kl/Nk+Kz?=
 =?us-ascii?Q?DS8hkBeUEtmbyvdqyJSsYmzrcZu3YAZyQx0+gV0Geiik30c8nnb1NsunNo2V?=
 =?us-ascii?Q?D6koTq7b0cudJ8TcnkvybNQ1LkydTTK2Ff+tOvoGeDFcQR3kikDIT/iXEsS7?=
 =?us-ascii?Q?yJdjH2Ejiqz4H0AOtgThhiZO+Bi+ALkAjY+4nbDy6VM7PvLBgiX9pM4IV35r?=
 =?us-ascii?Q?tBeG0itBJq4Lwbl6N0RXHtTP1GZ8dilyIFbWOAQRSV/bcb/107GYg3tBDZua?=
 =?us-ascii?Q?hqnFJjsMdM2yaSoWX+6ulGOSJwWfm/R+WdaZX/qtTwGwXlnXrGDal10i4wbM?=
 =?us-ascii?Q?kcqELSSJjXulEXWdKp7fNbxtAHXpLPKwlstC0l3tRolOvsWEFq06Ky4EBKyY?=
 =?us-ascii?Q?ExivlWEL8VmTlAwlcikOHAVIrF0rljqQLP2Bdjf05fQMpC7f996+RCAiJdsv?=
 =?us-ascii?Q?FetX5JJU50y9ESkswDz4/30OIj7OVcMc2NyGXdo5ddj56r0hZH5DZ7IIBuli?=
 =?us-ascii?Q?Sx4xzHlgnfyGLy+RNDtS72BPtnf8P5dXljED1hZu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3647789b-1056-4cbc-de51-08dbea40c6b5
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 03:20:14.4454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1sGSjpO6ocd5Yd7qfYsyrZ0ZZlkaQa8AtN/bq+oGXqo7CBLhV1Ixf32ROfMHrD9+CHkjlntivV9XFU321z0FgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6740
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 19:24:22 -0800 (PST)

On Fri, Nov 10, 2023 at 03:55:20PM -0800, Sean Christopherson wrote:
>As the first step toward replacing KVM's so-called "governed features"
>framework with a more comprehensive, less poorly named implementation,
>replace the "kvm_governed_feature" function prefix with "guest_cpu_cap"
>and rename guest_can_use() to guest_cpu_cap_has().
>
>The "guest_cpu_cap" naming scheme mirrors that of "kvm_cpu_cap", and
>provides a more clear distinction between guest capabilities, which are
>KVM controlled (heh, or one might say "governed"), and guest CPUID, which
>with few exceptions is fully userspace controlled.
>
>No functional change intended.
>
>Signed-off-by: Sean Christopherson <seanjc@google.com>
>---
> arch/x86/kvm/cpuid.c      |  2 +-
> arch/x86/kvm/cpuid.h      | 12 ++++++------
> arch/x86/kvm/mmu/mmu.c    |  4 ++--
> arch/x86/kvm/svm/nested.c | 22 +++++++++++-----------
> arch/x86/kvm/svm/svm.c    | 26 +++++++++++++-------------
> arch/x86/kvm/svm/svm.h    |  4 ++--
> arch/x86/kvm/vmx/nested.c |  6 +++---
> arch/x86/kvm/vmx/vmx.c    | 14 +++++++-------
> arch/x86/kvm/x86.c        |  4 ++--
> 9 files changed, 47 insertions(+), 47 deletions(-)
>
>diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
>index dda6fc4cfae8..4f464187b063 100644
>--- a/arch/x86/kvm/cpuid.c
>+++ b/arch/x86/kvm/cpuid.c
>@@ -345,7 +345,7 @@ static void kvm_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
> 	allow_gbpages = tdp_enabled ? boot_cpu_has(X86_FEATURE_GBPAGES) :
> 				      guest_cpuid_has(vcpu, X86_FEATURE_GBPAGES);
> 	if (allow_gbpages)
>-		kvm_governed_feature_set(vcpu, X86_FEATURE_GBPAGES);
>+		guest_cpu_cap_set(vcpu, X86_FEATURE_GBPAGES);
> 
> 	best = kvm_find_cpuid_entry(vcpu, 1);
> 	if (best && apic) {
>diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h
>index 0b90532b6e26..245416ffa34c 100644
>--- a/arch/x86/kvm/cpuid.h
>+++ b/arch/x86/kvm/cpuid.h
>@@ -254,7 +254,7 @@ static __always_inline bool kvm_is_governed_feature(unsigned int x86_feature)
> 	return kvm_governed_feature_index(x86_feature) >= 0;
> }
> 
>-static __always_inline void kvm_governed_feature_set(struct kvm_vcpu *vcpu,
>+static __always_inline void guest_cpu_cap_set(struct kvm_vcpu *vcpu,
> 						     unsigned int x86_feature)

nit: wrong indentation.