Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp162033rdf; Mon, 20 Nov 2023 21:20:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwYo7ulxWCRijJVk0GyWESgfFGYaA781tVlNhnuHOM6pdhwVkbsp8uktHZCq5R5rFsjXfi X-Received: by 2002:a05:6a20:244d:b0:187:9ff3:98ac with SMTP id t13-20020a056a20244d00b001879ff398acmr8391563pzc.4.1700544058084; Mon, 20 Nov 2023 21:20:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700544058; cv=none; d=google.com; s=arc-20160816; b=IEOd6v9paw+gtiRCir3NZyMCkJmOVPpSA1bKtujOdfy3fFgrHKZ4LtZ4uysfC+2ctj cHtp2BsywkHJ3DK/pHo9UOUt1/0qBKDX9Mjeg/pyXtQR0oOt6S3t9SFDDjOA0tXIgvX7 HaPKI0dAT3ShSTIdkjGsqgMCjUE90sb6crXIg/oTnEkL4EPQSsTgKE5sBkOhEk7AZi2R XFgvwnnnGKPZ4P3ZcNbPwgHNgdVl2VQ13g1EGcyjp+uxIBcIY2NDdlntlHaCBmf86ldf gbvePtj7dPImhD2h891oVX/dp6ZkMRQDNOr9D+FvO1rG0mZP1hv5TFoPs2e71munOcob CqZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=B6fSYmuLysXmtvlK0ZikS+mTqzGyVxSSj3ZOYvZyAKE=; fh=mfKMd+dhPTjZ7I3dw587SXCsKv3t6HtO1J7ZI46loNE=; b=FrddQggzMI4ZgCYEcVpWTKmO9BsIRrSFd1eOg8L+8oT359aP457MEd/dPA9Igds5UD 3ipNtjMAffoJzgpcobHKfjJ2gl+ak6sdbGS7kb0OZdBJgjz2iP72WshA5tR+kaDSavUH d2O6JuTY0GWPeKgglA7ZfhYsGtdXSFRglirrgqSoK4+CWbiI7EiPuU3yOOwe0QkQrxoL EmVz4lP9JzkmwUsN1Z1XKh3LJZKHQCid0E04PtGVxg8TVsuTvLGraQig9J2UaaZxaeJu VKbIUs+XvYX0/MHEc+DDfalCPCcBBIWjRU7nn3iGqelTLNkGyiuu1ZTFT6qh3zhUc+xW ajmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h1gaFBnm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id n15-20020a170903110f00b001c71e907ee6si9968995plh.124.2023.11.20.21.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 21:20:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=h1gaFBnm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 927B08053B1E; Mon, 20 Nov 2023 21:20:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233341AbjKUFUq (ORCPT + 99 others); Tue, 21 Nov 2023 00:20:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjKUFUp (ORCPT ); Tue, 21 Nov 2023 00:20:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E03B0C8 for ; Mon, 20 Nov 2023 21:20:41 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80F08C43395 for ; Tue, 21 Nov 2023 05:20:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700544041; bh=JtavrUIxlyshUyyi8vAOsYEh7+zxgbA7A7azHwQBTEs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=h1gaFBnmNWBvyPbmZ48AD8dfeGT4q9dhkMRjE4+ML67hhTb9TEzs8J/bjXIAAHItk IC3O+KoHTKlXxLPF7kWsnHWEhb3GxNwN6Qs5GYnyec4GOfdUFjpZL6LIbKUB1EqZdt 15e5acu7EMZasxmwA0/bzaxbqk8NArV9wQNnFn5Asa1xnUMydd40PxajW5kBm0rD+t CJegbdREwj9ZdiGeWABWralhy+KoKV0ZtOAhpQFNv+T44Hfg2f15G/4WSEuOzUVFXw VJZNpVY8e9/v/BmeQQ80Xx97/AjeTJJdzBfoQ8FQtYJYYBTa/sqehZnFm7QTwVPFaa DjfoqAaiB/+rQ== Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-280165bba25so3540966a91.2 for ; Mon, 20 Nov 2023 21:20:41 -0800 (PST) X-Gm-Message-State: AOJu0YwVZXpcxXv2Oeiazf0okzP9beLruPLgUb1hERa1+ihKa371IcvY fb9H9FDAWeHJHtS9AQQRucKwi4haKOXmKSWHjnhLdw== X-Received: by 2002:a17:90b:38c2:b0:280:e0:9071 with SMTP id nn2-20020a17090b38c200b0028000e09071mr8413728pjb.28.1700544040906; Mon, 20 Nov 2023 21:20:40 -0800 (PST) MIME-Version: 1.0 References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-9-ryncsn@gmail.com> <87r0klarjp.fsf@yhuang6-desk2.ccr.corp.intel.com> <87a5r7c3o1.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87a5r7c3o1.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Chris Li Date: Mon, 20 Nov 2023 21:20:29 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/24] mm/swap: check readahead policy per entry To: "Huang, Ying" Cc: Kairui Song , linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 21:20:55 -0800 (PST) On Mon, Nov 20, 2023 at 5:12=E2=80=AFPM Huang, Ying = wrote: > > but this series is growing too long so I thought it will be better > > done later. > > You don't need to keep everything in one series. Just use multiple > series. Even if they are all swap-related. They are dealing with > different problem in fact. I second that. Actually having multiple smaller series is *preferred* over one long series. Shorter series are easier to review. Chris