Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <2d234d31-3045-72f2-57db-db03515eebcf@amd.com>
Date:   Tue, 21 Nov 2023 11:17:21 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/4] phy: core: add notify_connect and
 notify_disconnect callback
To:     Stanley Chang <stanley_chang@realtek.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Vinod Koul <vkoul@kernel.org>, Johan Hovold <johan@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Jinjie Ruan <ruanjinjie@huawei.com>,
        Rob Herring <robh@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Flavio Suligoi <f.suligoi@asem.it>,
        Roy Luo <royluo@google.com>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        =?UTF-8?Q?Ricardo_Ca=C3=B1uelo?= <ricardo.canuelo@collabora.com>,
        linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-usb@vger.kernel.org
References: <20231110054738.23515-1-stanley_chang@realtek.com>
Content-Language: en-US
From:   Kishon Vijay Abraham I <kvijayab@amd.com>
In-Reply-To: <20231110054738.23515-1-stanley_chang@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0dMQ3oxUU1pQ0hBOHRva01lbTI3ZmdLaWJjUVNxcVd0MHhvc1JrTm02VEYr?=
 =?utf-8?B?QWtqOUNreXlaN0Eyb0ladnZSTXVKWTY4blVJUFBZZ0NMeSttdVVHc0NsTXdn?=
 =?utf-8?B?NGVYa1ptSk5ZYkhRdEVIcjdZZUdrdTFNejJSNGs1bEhKbzZxV0NXRmZYVVpN?=
 =?utf-8?B?STd3aXVWcjJrbHo4N0E2UDZEa3BkWDdwZjR2SENwS3RCYXVOME1PQ21oR3A5?=
 =?utf-8?B?NXdPektINXFJdzdCU3JMejU4ZmNvVGg2SWl3Lzc4L0YxNG54NmhPMEwzR005?=
 =?utf-8?B?VjZ3NklFWUpYTUNNL2Z2dmw4aDJNNElBdGxPOHh4Q1dLbXYwaFFYZ1hrZVNR?=
 =?utf-8?B?bWw0b1pQNlFxZlRwNms3VHcrdzlGSTlCdGRvUzFObGw5Z0dLbk5tWEdsMm95?=
 =?utf-8?B?aCsxY2JsQzMrWXYvdWFXdWtnY2J5eXdVNXNlcTdhSkhUeXduaG5TVCs3TEhz?=
 =?utf-8?B?WEFFdDN2WGhtdlFxclhTYldSallpcFJIQXdOQzdnRWpkdDVLZVRNNUY0SkY2?=
 =?utf-8?B?amszZXl2dkRnTkdxWk9EZm1xSXc2R2xCa1pnVlhnQmxiTkdVYm52ekZCdlkr?=
 =?utf-8?B?N3NnNTN3ZjVteVRyLzlBamYzRGY4QkpTT0ZhOVhCYmlqZmo0M1l4a3dwYmgz?=
 =?utf-8?B?dTZvcllhRmJvSk9oZzhNblhtZXk3dHJyWE9xcnBSc2x2LzVLb2VMMG9mUkx6?=
 =?utf-8?B?dU9rRDJFTHFQQWE0eXBub2M2bDRzMVFza1l4c0lPbTNCVklBc2Vxb3VWNFlF?=
 =?utf-8?B?elpaYXI3cHY0c0dvZEpzd25iTFE3SXNHQWU4T1h6OGZ6UlR2NFBweUhBMC9x?=
 =?utf-8?B?SXA1NlUwSVE5WFB5QWNRR0dpTWhqVjNxMXFWN2JlYk5BdXdwNGJGbks3RGFk?=
 =?utf-8?B?aUkxYnpweTZySmlET3UzcmRwUml2UFJYN3F2SnBsNzAwc1pMZXR3dFdGRk9p?=
 =?utf-8?B?d2JheGZLSzdyNnlQeDVhcllvN21YUjkwc3ZQVmpka1lDZGR3WENvNFNMZ0NI?=
 =?utf-8?B?MyswYVgvN1FMTFRPYmFnamdXaXh4VmpGdDcwbDVUUEhmbFEyNHczTWZEQSt2?=
 =?utf-8?B?NFIxc3ZRcmZDMHZKUk53Y1N6cHRMdXR1WDNKcHErZzlra0dJeElpQWRnV2Fs?=
 =?utf-8?B?SGZNcHRxcm1sU2QxeXBqY0RBL1JQRDRGbjI4L0lYS3kvcGtBRjdCZHpVN3o3?=
 =?utf-8?B?TUVPcHZXVmJLRks4RzI2UWVEZm9NV0tIeHB5eWdmMmRqTS9tc2ZadnJrUW1i?=
 =?utf-8?B?WjJYcXdaM3hRWllqSnVEbCsvZU9BNDBPTUFEekpSUmw2VCt1T0VPMEQxRlhm?=
 =?utf-8?B?TThlTU9rdzQ4czdsbjlGMUxYKzRpOSs4R0Y3dHk4YWRzVnVpM0syNXgzM0JI?=
 =?utf-8?B?YXF5WUhFZHFuQ3hsUG1zTU9JaXpkemFvN2VUWGpXblJxS1BHeWhZMm1wVURp?=
 =?utf-8?B?TmhTSVZIRmxldXZLTGdiRFhRUVkxWUhERG5Ld04zRVNZcHc1R0hiQnl4Yzdz?=
 =?utf-8?B?L1NiK0FmcW54eUNLb2IwbTYwTHZVQ3lsaDBjSUlTTndpUzh5cDB2c1Y4c3VY?=
 =?utf-8?B?MWRUdnZxYmZhTm50cmxFb2hMMHVsRjloMnRNaW5iZmc2U3A2djVUa3h3R1U0?=
 =?utf-8?B?Q2ZRbUhySEtIUG8wZHQzNllwQldmSUpnQk5aVUJqcGxYTXAzT0FMUWw3U3Y1?=
 =?utf-8?B?SFViRCtTN3VXNVZ6TUw3ZHNOQzliMkJpcG51bkxBRG1pSll3N2g3Y2lzVTQ5?=
 =?utf-8?B?N094ZVpVa0Z6RmZPbno2N3VUTXN3VDcwMjFsSGFFT012K1JYVnM4b21OUlhR?=
 =?utf-8?B?VDQzcVFlNWNvMFREM1gxV3FQaWw5R1FSZWRxSk5Wc2ZuSlhUeFd4Z09TeHg3?=
 =?utf-8?B?c3QvbWhhbkZsQjhYSXdISXdpZXVJaXBDcmZIdlREZnVjcFg0L2pVejBIWE4z?=
 =?utf-8?B?TExjMXB2R1ZPVGFPMjRIZmRtaEI5RDVpbExwU1FtY2pHblkyWE1kb2p1cUlH?=
 =?utf-8?B?UW9qK0IwcWlrdmFleHorM0ZtVUlISWxTK3ZZanN1SHlFY1ltSDQ3MlNFUU4x?=
 =?utf-8?B?Z0w4b2RnQWU1RWl1MmlUa3QxVmxFd2dheHJsWS9rWXRNSGxBUTlvNWEwaDVo?=
 =?utf-8?Q?Lep9QGK6POfS806/p42umzjbB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9d7405ea-32e9-42f4-0876-08dbea555aac
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5827.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 05:47:32.0710
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gxt7LMdrZurohbs3mvPrmPmK6nbsBJm0+MahIoVpW/tPDHV4ARHSsY547nzaGo5wbOwvqD/ybYXTxx7jQ970Tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB8242
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 21:47:59 -0800 (PST)

Hi Stanley,

On 11/10/2023 11:15 AM, Stanley Chang wrote:
> In Realtek SoC, the parameter of usb phy is designed to can dynamic
> tuning base on port status. Therefore, add a notify callback of phy
> driver when usb connection/disconnection change.
> 
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> ---
> v1 to v2:
>      No change
> v2 to v3:
>      No change
> ---
>   drivers/phy/phy-core.c  | 47 +++++++++++++++++++++++++++++++++++++++++
>   include/linux/phy/phy.h | 18 ++++++++++++++++
>   2 files changed, 65 insertions(+)
> 
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
> index 96a0b1e111f3..a84ad4896b7f 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy)
>   }
>   EXPORT_SYMBOL_GPL(phy_calibrate);
>   
> +/**
> + * phy_notify_connect() - phy connect notify
> + * @phy: the phy returned by phy_get()
> + * @port: the port index for connect
> + *
> + * If phy need the get connection status, the callback can be used.
> + * Returns: %0 if successful, a negative error code otherwise
> + */
> +int phy_notify_connect(struct phy *phy, int port)
> +{
> +	int ret;
> +
> +	if (!phy || !phy->ops->connect)
> +		return 0;
> +
> +	mutex_lock(&phy->mutex);
> +	ret = phy->ops->connect(phy, port);
> +	mutex_unlock(&phy->mutex);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_notify_connect);
> +
> +/**
> + * phy_notify_disconnect() - phy disconnect notify
> + * @phy: the phy returned by phy_get()
> + * @port: the port index for disconnect
> + *
> + * If phy need the get disconnection status, the callback can be used.
> + *
> + * Returns: %0 if successful, a negative error code otherwise
> + */
> +int phy_notify_disconnect(struct phy *phy, int port)
> +{
> +	int ret;
> +
> +	if (!phy || !phy->ops->disconnect)
> +		return 0;
> +
> +	mutex_lock(&phy->mutex);
> +	ret = phy->ops->disconnect(phy, port);
> +	mutex_unlock(&phy->mutex);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_notify_disconnect);

Please use EXTCON framework for notifying connect/disconnect.

Thanks,
Kishon