Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
References: <20231107215742.363031-1-ankur.a.arora@oracle.com>
 <20231107215742.363031-35-ankur.a.arora@oracle.com>
 <20231108085827.GE8262@noisy.programming.kicks-ass.net>
User-agent: mu4e 1.4.10; emacs 27.2
From:   Ankur Arora <ankur.a.arora@oracle.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ankur Arora <ankur.a.arora@oracle.com>,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        torvalds@linux-foundation.org, paulmck@kernel.org,
        linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org,
        luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de,
        jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com,
        jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org,
        bristot@kernel.org, mathieu.desnoyers@efficios.com,
        geert@linux-m68k.org, glaubitz@physik.fu-berlin.de,
        anton.ivanov@cambridgegreys.com, mattst88@gmail.com,
        krypton@ulrich-teichert.org, rostedt@goodmis.org,
        David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com
Subject: Re: [RFC PATCH 34/86] thread_info: accessors for TIF_NEED_RESCHED*
In-reply-to: <20231108085827.GE8262@noisy.programming.kicks-ass.net>
Date:   Mon, 20 Nov 2023 21:59:09 -0800
Message-ID: <871qcj1wb6.fsf@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?I2rgd9nzPhsNBjeD3zzdypdiBE+HfB2WXg71YmLgOTrTr6Tg4PIJU0FJ8UqR?=
 =?us-ascii?Q?d2154rUT9cEgCCh4x3fyEldgLhcC98oQjGxeIa/khGgstJNcAcO0AzWABzvt?=
 =?us-ascii?Q?93kZTXquIc9nmqMDCq7Jima+MzfW224IHEXMbARDtblyQsbS65Gvc8pG4Ve9?=
 =?us-ascii?Q?fz58oe8YrnxD2TlMp6Wj9DVdcYwb++HO9EQkfh3wGY857EL9/pRq5zHn71E+?=
 =?us-ascii?Q?SVsLOqy5UH6Y4hkQf2SriE4JtmivSHPwB7LH+lasdsN9C5WXll3nkKB6NFMF?=
 =?us-ascii?Q?hVz83GStSmAnlhHWdkTiLzhGti9DLL3XfFkNHtrMCV+wl9lZC84enzlKo/Me?=
 =?us-ascii?Q?6hVbNLY9eikFfaoN/giDUvvtIqhvJF1GdT4T68EEmF9Vp3BeS9ICflErkNRi?=
 =?us-ascii?Q?bTiKUyFI3dKOzIyoX2CHUWnjalBnXD3N+y6275+yrMOg6Hp/uCNnSiZn4h0W?=
 =?us-ascii?Q?Sx0MHlwCNAk2zj30dJkU1BklCWE6Y8cbrLh7Wtr8gO1ghEFtnsOblleXKrYs?=
 =?us-ascii?Q?xZ2pVuagtUVSWUecoBFcHG9kWzNzmlvbt5vWvE+l/of5q7wmM7l2lVoAQQXE?=
 =?us-ascii?Q?OWREZdUiGzTWSUPEJjFopCR5bpHeQeQN9Rhm4enhDz+K4qLBVw3N5GHunC61?=
 =?us-ascii?Q?bvyxwKxulVPUjeePC2wfTYt44VI12yig6BaZbD13bEPXYWiR/yrocOQDyEjj?=
 =?us-ascii?Q?gmUh/C2wiCj4j2DuLOAnlYhYYpkVVU6H/vW7ZnOGYhLRUYmj7jy2sqQErA8T?=
 =?us-ascii?Q?xzDFSPurejljhazq/Gst2e6Fz5Uu2+F6I8sUOvBM88+xvzDCoQlDv3FPwFDD?=
 =?us-ascii?Q?/Jtl/dENiVe6YEdIgqNepdKxx+fT05dIoYGnLC7gSCfmqNP7yS33RozYlM1R?=
 =?us-ascii?Q?c1ojlU+74l5ZEP39G5/qWVsg5XN8+JQIMnooEtHgByZ+9wMqXrvxlm6FxnyA?=
 =?us-ascii?Q?2Otp31tO/FSGMyVAbi0pAZzfabZqxORwc9rjzjQL2q4Yh0chh6JpPeRMM7LT?=
 =?us-ascii?Q?YYj0jPjljDVo3F1m9mb7/KYiJDhM2bbogKbaGAQWx2iRnYclRD/lMVO5soV0?=
 =?us-ascii?Q?PJ6NrZ8L79ASSvagFC6csYRZhom7OpAjyV37r06rxaEwFfWQvZjx3UI91B7g?=
 =?us-ascii?Q?w52NA2NL1LbchLI36IHgBoBucWPeQOJvOCbtCxrXvDsGt/IHp6LOiihjj9Qd?=
 =?us-ascii?Q?41ilRYbDPWzbCisedCcEaMbo/tUeMIGJEX7goSOmQfA+WpJeVT0iYdigQmpb?=
 =?us-ascii?Q?w1b7RtAfBz4ls5joDPmF7cIg6YYpzyK4C8dX4C8gV2Tk17ujOPKElwGsTCYT?=
 =?us-ascii?Q?BQ8M3QwgNUuSE1Yer1sC416sMHcrXHbJkm9hrmiWtMSQR5lgioj8uVumYfKb?=
 =?us-ascii?Q?utnoJMAXDKTqBsXlU2t7nHc+YCXNL47K5JYwTS/uWeZ2ZJaIcbJAuyzW4xbX?=
 =?us-ascii?Q?euFMW7ioD+2RE4qgu3kYdZo3OofUOpoBtQUrzy+l/B/XqS9YJM1SBTFoLO+Q?=
 =?us-ascii?Q?2d3YDwKUicQSXWXvD2zn6XTnaEdiM6MhEGKoBRuImxh85yKRwFQ2aLGmmmzN?=
 =?us-ascii?Q?/h3KL8zssEnFv6xMrsQf/zwcXcpM71vWUiZqZSRL?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?O19emjSVXAb/7YrCmEGJI+uhYhEa4npNl8egNv4IkqWxQdyntggtbI4dbFeo?=
 =?us-ascii?Q?kwnSk4+Jx2qTBPoK/uZXLjAlq1jRyDRAhB62+nbvdMzM8XDtruNN9KYZGniI?=
 =?us-ascii?Q?38PTv3/+OnD4OBaojj8bgLuvqwsfMx3ya+2eg3lVBXYoqZQnn1tFISPTeGyu?=
 =?us-ascii?Q?b8Dxkn69geeWV5i4INZSlY4Vhw9rgaJr68L1AWtRunWvkpOLl4Owo1EorhOI?=
 =?us-ascii?Q?yiT1Ty3pAw1zGRLu+Pj1cestAWjq9yQTI21jn4qObWbKPta4mnOMY9sPpLpa?=
 =?us-ascii?Q?0XrTQsGk9b7eUjyIu9zYVTD3UpDyvBJtJUky9bZoNsoWU8nlwByWq6dxEBK7?=
 =?us-ascii?Q?TuNC61DyLEMmZPNrQAo/Fe/QoYmNONqL4g4Gje8wKGNrEwFbFMo3sTnyPh/B?=
 =?us-ascii?Q?VYaGzc7UXPHv3fAxZE9UhpH1lxRij/SkMxBUoRITKq3a4ZivXb81JBwhFvsR?=
 =?us-ascii?Q?qIkfkzSnVQ1TP1ZLv2fYSrw6ZyVVNhYS6EHs34V9oogjJA1oKBoX2D8WRe0+?=
 =?us-ascii?Q?y2k8BSlB5gCNGccUTXdvpMx8zvXRvybDIFkVqdHLNvyYMUC2HCnPo3YCkf9w?=
 =?us-ascii?Q?Dbl+3rNk/vQ0WD8Og9DlLQCmjXRKUZD0hgSHnLuru9QYktmqYNyOIY4La0+X?=
 =?us-ascii?Q?pSf1+mTLaploFLL6c87Ri0ohO27f2FpMUhbzU0iKn+Ve2WQXSEmwWiMa6D2q?=
 =?us-ascii?Q?36yE9EjiCcDvyzNzC+aBuNjwoWPmo475DhoD/TrYNnhXxs8bG62chUXNlBsA?=
 =?us-ascii?Q?usCg+XaKhMNZFaYsdNSjhCNxvDN6N6aHjhimGAwecfOaivTgNt5QfY93Jk9c?=
 =?us-ascii?Q?hMOZ0VBLOrOxqLVcatS7UwwjyMUdKySadoGwkxlnqPylRUQzv3LDwekBFKnB?=
 =?us-ascii?Q?5q53m6NRRZgHsmwPdLUa3BwSCGMPft3AINljRvP/x2tC/Y+VRoXkjeL2v2+C?=
 =?us-ascii?Q?pdMH13Qcm+tBg+jJqq+T+PlB24mW09jVE/otGWseUQmN2AdkUZF3lb3kgVxB?=
 =?us-ascii?Q?tWFMVS5awjBr8Fv8HWDwus0JI5IIrYa9XkhSsdJyEGgYlYPZuWXQKcTKh58S?=
 =?us-ascii?Q?ulzgcnPirUPeL1oQ0/Xyhwkx8U5fKJo7Dgj0h7guXQa5mMUbHObinMsa2bfk?=
 =?us-ascii?Q?89I5UcPRh4nve9qiqvfMOloBpc4sNyD8sLMGNSHyivbllkdp9xFz90cTNy6A?=
 =?us-ascii?Q?qhnMR7csrQEwbcga5kQhbV96O2gxeZ4Kwst+iz5u2umuHZ348DiWteWoPBjs?=
 =?us-ascii?Q?XDAtBQ+IRakGvUoSBPfPZ+N8txAa8F2nL30rMBXwfVWgOAPLbLSts2CJW2vm?=
 =?us-ascii?Q?RZuuc2KGHwIPe3OMSc5CPMty7eZUzCUQaE2MoBuCsXwRX5guLk1S+UCdmEIY?=
 =?us-ascii?Q?9rz8fY/q74Zhp6EELjW68Htymyo6Va5CrgmAlH+zbSMZXrecR8BYBlYxlq3M?=
 =?us-ascii?Q?um4EpR+6Xhvf+hTbfzLaF38sm5PzHokoWaabx0InIOlogkckN82RINDopr7/?=
 =?us-ascii?Q?0s3iYkFnSa1ia48P6c4T7R4uV/Pjne7siEBwnNt6dwKURF9pVymJLANmtg?=
 =?us-ascii?Q?=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d5d0a245-ab8a-4cd4-b21f-08dbea56fc15
X-MS-Exchange-CrossTenant-AuthSource: CO6PR10MB5409.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 05:59:12.2047
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JScQileuFrEcM9txfWdiSY4jX0MTccb4xAPF6doyVBn8RU8mkfUDXcRvvsanFqAcdIuhXTLvKoWTyTmitwoJpim/q/x27GdtR7DZ0wWGX3o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6448
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-21_03,2023-11-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=999 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311210045
X-Proofpoint-GUID: PJQJ0dO9eiZYEqLUYsItcpesI4IFiBy2
X-Proofpoint-ORIG-GUID: PJQJ0dO9eiZYEqLUYsItcpesI4IFiBy2
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 22:00:47 -0800 (PST)


Peter Zijlstra <peterz@infradead.org> writes:

> On Tue, Nov 07, 2023 at 01:57:20PM -0800, Ankur Arora wrote:
>> Add tif_resched() which will be used as an accessor for TIF_NEED_RESCHED
>> and TIF_NEED_RESCHED_LAZY. The intent is to force the caller to make an
>> explicit choice of how eagerly they want a reschedule.
>>
>> This interface will be used almost entirely from core kernel code, so
>> forcing a choice shouldn't be too onerous.
>>
>> Originally-by: Thomas Gleixner <tglx@linutronix.de>
>> Signed-off-by: Ankur Arora <ankur.a.arora@oracle.com>
>
>> ---
>>  include/linux/thread_info.h | 21 +++++++++++++++++++++
>>  1 file changed, 21 insertions(+)
>>
>> diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h
>> index 9ea0b28068f4..4eb22b13bf64 100644
>> --- a/include/linux/thread_info.h
>> +++ b/include/linux/thread_info.h
>> @@ -59,6 +59,27 @@ enum syscall_work_bit {
>>
>>  #include <asm/thread_info.h>
>>
>> +#ifndef TIF_NEED_RESCHED_LAZY
>> +#error "Arch needs to define TIF_NEED_RESCHED_LAZY"
>> +#endif
>> +
>> +#define TIF_NEED_RESCHED_LAZY_OFFSET	(TIF_NEED_RESCHED_LAZY - TIF_NEED_RESCHED)
>> +
>> +typedef enum {
>> +	RESCHED_eager = 0,
>> +	RESCHED_lazy = TIF_NEED_RESCHED_LAZY_OFFSET,
>> +} resched_t;
>> +
>> +static inline int tif_resched(resched_t r)
>> +{
>> +	return TIF_NEED_RESCHED + r;
>> +}
>> +
>> +static inline int _tif_resched(resched_t r)
>> +{
>> +	return 1 << tif_resched(r);
>> +}
>
> So either I'm confused or I'm thinking this is wrong. If you want to
> preempt eagerly you want to preempt more than when you're not eager to
> preempt, right?
>
> So an eager preemption site wants to include the LAZY bit.
>
> Whereas a site that wants to lazily preempt would prefer to not preempt
> until forced, and hence would not include LAZY bit.

This wasn't meant to be quite that sophisticated.
tif_resched(RESCHED_eager) means you preempt immediately/eagerly and
tif_resched(RESCHED_lazy) means you want deferred preemption.

I changed it to:

typedef enum {
	NR_now = 0,
	NR_lazy = TIF_NEED_RESCHED_LAZY_OFFSET,
} resched_t;

So, to get the respective bit we would have: tif_resched(NR_now) or
tif_resched(NR_lazy).

And the immediate preemption checks would be...

	if (tif_need_resched(NR_now))
		preempt_schedule_irq();

Does this read better?

--
ankur