Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <2c8daf55-22f8-f79e-ae02-6fc8d505ade2@amd.com>
Date:   Tue, 21 Nov 2023 11:45:11 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.1
Subject: Re: [PATCH] iommu/amd: Set variable amd_dirty_ops to static
Content-Language: en-US
To:     Kunwu Chan <chentao@kylinos.cn>, joro@8bytes.org,
        suravee.suthikulpanit@amd.com, will@kernel.org,
        robin.murphy@arm.com
Cc:     kunwu.chan@hotmail.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20231120095342.1102999-1-chentao@kylinos.cn>
From:   Vasant Hegde <vasant.hegde@amd.com>
In-Reply-To: <20231120095342.1102999-1-chentao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXhXZndpT3NLMnB5eVMzU3J3eVRCeGpuZjg4M1BNeGtVeDFORUxBZ0ZQR0Rn?=
 =?utf-8?B?OCs3eUhFSDBMZkVycHo3dnN1ellVRjljeGNVcEhCbGJ3RGk2QUtQYlU5VXFF?=
 =?utf-8?B?cGk5UHFSd1dVTTU2OGovTncxTFBvVEZDUVVwck5ZQ0Q0RHZlMlpPY0hnYmI5?=
 =?utf-8?B?OW1DVkVEVUM5S29IemNuckREakY3azd3Vkt3Y3U5R3Evb3l6amMrL3B6OUpu?=
 =?utf-8?B?ODBoYzZVdHdjOFR2QXByYnI3Zzc0RHVvMUlpRWtHcEdOUm8yQzlzT1Jsc285?=
 =?utf-8?B?dDVoRE9CcVFYNjhRYUEvMnJpWGVzOHpZSGozVXovUTBwanJ4a1lCWDJyck43?=
 =?utf-8?B?eG8xaitpNk55UE1IWGhPZ1VXMlZ4d0VWN1BvRHMxbDM1Tk1TRW8yTUlobGJP?=
 =?utf-8?B?MW93UnBQRUhvNEo0N1RVbFVOWm9oNzRDYUhXMFJhUnRHOWc3aFk0NzhPUThw?=
 =?utf-8?B?RmJyOTlSWjdpdFN1aXNkOUtQK0lDbHBlOUs3SW51Ti8wVGdnQzhKMXRXVnl5?=
 =?utf-8?B?Vmp3V1NQZVZBY3Z0N0R4bVViZHdNaGZJVno4Q2dtSFJTa3RYdEEva21aeGRL?=
 =?utf-8?B?OUtOWnJjNytlODRlNVIyRXFyNFQwbXVoTm9QRVRsa0pkdkpVSmdNMWRtbkto?=
 =?utf-8?B?LzdOeXFLVWxhb25RQytwZFh3MVFtdERnOEFSVHBFT2R6OWFWZWtRNXcyR1Fh?=
 =?utf-8?B?djlHUEU2Ykh0Rnk1YWdQVGtYUTdneFFFSkVUcmd0cUNvSmI0Yjk3Njd2QVVk?=
 =?utf-8?B?Z1Q4cFVRdU5PWWhTYnE3YWMwa2ZLcmF3OVZhL1h0VjMzVk8yTHk3a0N5OUhF?=
 =?utf-8?B?czdEbm5vbU9BbWtaVk0xS3grQ1NvdVB4SlFSNWtZYXZWREFWOHBwS21xSW0x?=
 =?utf-8?B?ak9oSituQndKenhXNGhtNDRRSU1QdzZ2WHppQXNMcXRlTEttN2pWeGo1TnJq?=
 =?utf-8?B?RGczcm9kU3hZc250eUtoOG9PU2dUNmtEVExCZTFxZUl3S3R6OHBvcGJiQ3Zz?=
 =?utf-8?B?Zm1Gc0gxb0dBSGNJdVBTODlQRHJSdTNmZkxHVndaTkVxL1pQYzlWYy84RFc4?=
 =?utf-8?B?UTkwNTZZSW50ejZrWDA0bmdQdUN5QmZSNExEaTBPSkZsaGNqRHVGdXA2MVVq?=
 =?utf-8?B?STdPdmx1eFp0N2JucXRjcHY4RnZ1N1JrRHNSc1ZKRUxtbTlKS3VkU29hWS9J?=
 =?utf-8?B?OEZIZHlQaEVKSkE0bmhRUzZaTHpPaEpMZUdmQzA4b1ZjTkVLUFhtaHZvOVZL?=
 =?utf-8?B?UC80QWpjMWdGbzEzek5VMXZDbzRxL1VmZG5QZzdlaUVVb2pyQTd1SEFlcmRm?=
 =?utf-8?B?MkN2czE2ek1vOWQzUlM1bTBPeFdjTjBNSjUyN3JzWGRrMEl0K0ljWkVqNGZK?=
 =?utf-8?B?NmJCTTVueXF4SlJXNy9yY1lIOWpqWG43SFR4Rm1GNzRJK3RVcGpXTWJqOU9R?=
 =?utf-8?B?TExwUXkveGh3VkNBL3hIT0ptRlN2b3NvMEREb3FLb1pzRUFlMDZXM2Fxc0I3?=
 =?utf-8?B?TFFLL0pWYWJiOG15ZWJudDlVWmM3TzJHQk14K3gzVXlVdDZLVXRuRWJIck9P?=
 =?utf-8?B?V0ZIOGs4UGYwUlNrMFppanRmcmVqN0R2eWFETlhLc09kNy9IeklZUk0ydzVs?=
 =?utf-8?B?TDJUcytaeXI3TWNodTQ0bkQrZG1lMVdSb2x1WUZQNzFEZVdGWDRPYU5xL3Zr?=
 =?utf-8?B?dUpiRllJTHhOdUxSVFRVQjJhQU0ybTlyS3JTd3FZOHZPMEw3WjNudlhhVmZF?=
 =?utf-8?B?TTg4N3JsM291YjdrbzJsUGpTWW5Wa2lMblB1cEtuUGUwMkFkNURYNHBLQnlp?=
 =?utf-8?B?eVNUYmV0UGlxNFk4Y285cWlrd0l0Si9Hb1puUWJvNXBnQ3lHUkhyODY0aHRI?=
 =?utf-8?B?NEYrUlNrZzVzNUVhVUp6YXYxZ2trUTN0TFhkVytmUHBOUW56YkRNd1h5ZHUx?=
 =?utf-8?B?K3RtQngzNk9MVUFBNlZaaXlEbnZDTGxmcFFIamdCS0orNHJqYmJ3ZzNwSE8y?=
 =?utf-8?B?L0ZaQnB6eW1NVVY3dTYxcjh6bFRSNW9QN002NEVhYW05RjJaclF4OU1yS001?=
 =?utf-8?B?STl2cG1MT0M1dndiS1FYSm9qVmZWRzhtZWNHN3Fzc0NLRUc4RGk2QVB6aXdN?=
 =?utf-8?Q?fpYbTZQgWGS156Tqm0Rw6U6Ev?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4187f003-e97e-404b-5b95-08dbea593d04
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6048.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 06:15:20.4534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wh61lM0dnE/v1oyyWHZuTyy9aF9u1lXHIaE7Pb2FNd7U18uSCOlWamltguPrk5q4hTugGWTCNafYXYxOXV9jFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7908
X-Spam-Status: No, score=-4.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 22:15:46 -0800 (PST)

On 11/20/2023 3:23 PM, Kunwu Chan wrote:
> Fix the followng warning:
> drivers/iommu/amd/iommu.c:67:30: warning: symbol
>  'amd_dirty_ops' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Thanks for the fix. Looks good to me.

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant

> ---
>  drivers/iommu/amd/iommu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index fcc987f5d4ed..9f7064360828 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -64,7 +64,7 @@ LIST_HEAD(hpet_map);
>  LIST_HEAD(acpihid_map);
>  
>  const struct iommu_ops amd_iommu_ops;
> -const struct iommu_dirty_ops amd_dirty_ops;
> +static const struct iommu_dirty_ops amd_dirty_ops;
>  
>  int amd_iommu_max_glx_val = -1;
>  
> @@ -2635,7 +2635,7 @@ static bool amd_iommu_enforce_cache_coherency(struct iommu_domain *domain)
>  	return true;
>  }
>  
> -const struct iommu_dirty_ops amd_dirty_ops = {
> +static const struct iommu_dirty_ops amd_dirty_ops = {
>  	.set_dirty_tracking = amd_iommu_set_dirty_tracking,
>  	.read_and_clear_dirty = amd_iommu_read_and_clear_dirty,
>  };