Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp197780rdf; Mon, 20 Nov 2023 23:06:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBoO/jaAc94RJD9sFFQz8KNdObzYMokH6nU1bKgrAI+pxSODjgbhBEkZkMPlXBs+d8gj/e X-Received: by 2002:a17:90b:1a8c:b0:280:cc2b:d5be with SMTP id ng12-20020a17090b1a8c00b00280cc2bd5bemr8301968pjb.15.1700550383632; Mon, 20 Nov 2023 23:06:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700550383; cv=none; d=google.com; s=arc-20160816; b=W67BaExYXhpZ8I4zvoW4SFpwxjsSUM4yqU8UVjlSufR6r6jREypqWVESCScWxuto1X DmqTm2yXQ6BVVE703i2WN0bX7w70JpiWg6rJO17HFS29IZSIEcINPb7yLX5wzNRH58tC EujYi4qraHk2nOKusHqI9gEC7fll9U1K/AXJZHX7SGsz3t/GONOdS3r5GrzbXJPsHdO5 +GSNl+6hy31k7bDmXNpBDyLp2TuRW5MNiU7o7X6CwSwhboMsVtzrLBcpiuka6iU+1t1d VmhqHWz1pK3wdRVX1lviaGSHqdny5gVqCW4WL5tl8Lkle1RxtRT1kncDxjjcU0nuo4HP RXfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=nH4swh9fEPW3jOPrSOjxPBymwQwviSlAcTZL7Zl3GV8=; fh=w8YGavuRoxloa29ctT2YHi79+Vq7Am8DSTIR1w3ewgA=; b=BlkTop1DML0sglI6aex/heqXjFTEWkim+8h/aeaj2E8hhAyhz/JinRhQydhyDuc+6m TipCrg3L972Xky675Ue8Lg4GxWVM3KG7ZBcOAOdoOAM37uy8/GROyDMBWNe9334MOGHf VraQkZnQl3SXnU5/XHVtVQ5YTUVdRW/9X2isNB6nlaRAVMro+MY0GRsmCbdSssERaYG3 FuCzCTUlxG6N7gtfbYwfQT6YBSChtYjWF3ZVH4SOGZrmkvLE8oUydUGy+HUBnqZImi7D HpjoI5A8gsw2yinLp0st1qL1Ml8XT5ujx0rn/YzMnqkzhlBlYWmWx3PwLFSj4IQblVh3 NEjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qaO+wPer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id rm14-20020a17090b3ece00b00280277d721dsi10153638pjb.83.2023.11.20.23.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 23:06:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qaO+wPer; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id B2FE58076C91; Mon, 20 Nov 2023 23:06:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233396AbjKUHGJ (ORCPT + 99 others); Tue, 21 Nov 2023 02:06:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjKUHGH (ORCPT ); Tue, 21 Nov 2023 02:06:07 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EACB124 for ; Mon, 20 Nov 2023 23:05:56 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5409bc907edso7177419a12.0 for ; Mon, 20 Nov 2023 23:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700550355; x=1701155155; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nH4swh9fEPW3jOPrSOjxPBymwQwviSlAcTZL7Zl3GV8=; b=qaO+wPerdX+S5dO/FQz5QgjDZeD3mfsqCC0BV7nKyCucG79JLovMpx5y+7l6rPYAEY ATCltATFbvEPX1nL775gZksKFSYrqNdIX4X/ZcryMmqqcI4FbPujTi7yWlFI+YjvW2kW dBWs7/UhuQM3AWbyzgRSmDXh4B+/0afOItuHHFKzJRO0nAf7aU49abstiOu5bQobXo14 /f5qsVmVuxQqh92AVnN9xE5O/BKzCVCXphLFAvo/JIO24bRMVy+6I0A85ew+W23Y1ZE4 cap91yM1OlRwryteekYsmcTfaLZpFBbfbp+YeZoQEfbicBJ1CP+lrH5xuDIS2rXO2uj+ 3heQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700550355; x=1701155155; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nH4swh9fEPW3jOPrSOjxPBymwQwviSlAcTZL7Zl3GV8=; b=b+VEurAvindzP4wgbzj+BkwN193V8k79MpqtrgrEtMBPNzU0LwJiUANnmLzkrfpFHZ qiOogAjKveCZHxeyVzq0+w4+SNbuPGBx5/c1Ib3mMO347/zo3EVjDSUUpZg0yTjDx2Zj DBBO1dC/sfCrueypi/ktjVOzUzO946WyYtD6MHrZbOzamxBhn2HvA1rqvADP1BHN6qPm Zx92qWHM7OdRI6nTXrHT5Nv3F7FAPenSNlXA+1AX6ohseffzam1fzRLJjHkrWYoQtD39 uTL+zLSwNO8mg5OyMHo3AS8BDD+lae9OdfK+03izt9Mr3mB+CZmNTEVXHawvQ2XhsT7F 7xaw== X-Gm-Message-State: AOJu0YwFI8+mUaOvSEql1/wgvp75dh5EvY/c0CTEmTsm38EKhdlGv+f5 CTaOaHXeoxAKAY//M0REVRaHTw== X-Received: by 2002:aa7:df17:0:b0:53e:468d:64a9 with SMTP id c23-20020aa7df17000000b0053e468d64a9mr1197574edy.21.1700550354648; Mon, 20 Nov 2023 23:05:54 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.11]) by smtp.gmail.com with ESMTPSA id c17-20020a056402101100b0054851cd28d2sm4011789edu.79.2023.11.20.23.05.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 23:05:54 -0800 (PST) Message-ID: <3009000a-c973-4894-83d6-ce2ddab5ccf0@linaro.org> Date: Tue, 21 Nov 2023 08:05:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nfc: virtual_ncidev: Add variable to check if ndev is running Content-Language: en-US To: bongsu.jeon@samsung.com, Nguyen Dinh Phi Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "syzbot+6eb09d75211863f15e3e@syzkaller.appspotmail.com" References: <20231119164705.1991375-1-phind.uet@gmail.com> <20231121013146epcms2p1587bebc341f17406625e8b0490b6ab1a@epcms2p1> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231121013146epcms2p1587bebc341f17406625e8b0490b6ab1a@epcms2p1> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 23:06:20 -0800 (PST) On 21/11/2023 02:31, Bongsu Jeon wrote: > On 20/11/2023 19:23, Phi Nguyen wrote: > >> The issue arises when an skb is added to the send_buff after invoking >> ndev->ops->close() but before unregistering the device. In such cases, >> the virtual device will generate a copy of skb, but with no consumer >> thereafter. Consequently, this object persists indefinitely. >> >> This problem seems to stem from the existence of time gaps between >> ops->close() and the destruction of the workqueue. During this interval, >> incoming requests continue to trigger the send function. > > Dear Krzysztof, > > Even though i agree on this patch, i think that NFC subsystem could handle this scenario not to trigger the send function after close. > Do you think it would be better that each nci driver has the responsibility to handle this scenario? It's better if core does it, but so far each driver was taking care of it. Send a patch if you have some better solution. Best regards, Krzysztof