Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp216419rdf; Tue, 21 Nov 2023 00:00:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/LXPcXDp5dA8r+FbwlrkLMIbTljSAvzz0iBKqijYtvix7wugCr5F5AKGmmbDHTO9E6aK1 X-Received: by 2002:a17:90a:ab01:b0:280:200c:2e20 with SMTP id m1-20020a17090aab0100b00280200c2e20mr7335053pjq.27.1700553599778; Mon, 20 Nov 2023 23:59:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700553599; cv=none; d=google.com; s=arc-20160816; b=uF5E738BIN9+uYu3K1hPaUkJXcRcKWtMfnFMm+Krovwdot9rssxDxhJ9Y5wAuoa4AG xE/aKYGY5JATzVwyyMMFi8X5w37JUFFmsmPLmcr3mYGCKGtz8dwqBy0xqi/1QI3kp3HY BJKvvqnExEAPaPPvADNssZdtQbCM08PEhTqox5BQhQutuIAmwntD6s7ekTBMQJybRdCf 7aEIXjOgvmMVGYzOGaMSzfOYfFbq6NqG0f1dXelusNIn2MsthCnPOAV47DdsEuvb1HIr 8HPUbeZT+UUyFXor7umIikdCZ7SVs2rJaIljF8BqAvBtrctIdaf3YfQYMSwSp2NnIUZD rbQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=KnQN/JHkdFEOPeqlrbFfAW1UeTsAvWdGl8rW+LmA61U=; fh=V+P6Afz0jc0oTZOWNspANvmimQyt28hwWZRgECMERnA=; b=Jy/idevX6ADLPRaUIKwzdbE9s8ViZG0ufZpDDV6aAYv4krSCdVpY2jGpblzJ8GrArA YlxJiVPuE/trBimdMtWx8USERxdBivMAjuicY1WblirPLVgDYSxFqwiNZuWPAJnlrxoc /LlUBfEiEpJqgRMIVnHW9mA+2x7J9NtEtz5ZrBugSme5lFTjg+lUH7Mr6rFVAJ93OQM4 C/SKBWBU7jXJx7aG9FW84LsZR2T3S+DRdUuGavB7VXrMKbG3j/iELIRnEOR4KrGjDz1r N7iE2bLA0vVPQfBOnYnYporYDQAR6k7y86oI3CPa0uCvdiV2aCay/qu0sD0vFlqLSWCu 4KhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eIqFNRGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id h20-20020a170902f7d400b001c610ae885bsi9336640plw.59.2023.11.20.23.59.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 23:59:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eIqFNRGh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2CF9580BD3A2; Mon, 20 Nov 2023 23:59:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbjKUH7r (ORCPT + 99 others); Tue, 21 Nov 2023 02:59:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjKUH7o (ORCPT ); Tue, 21 Nov 2023 02:59:44 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE484CB; Mon, 20 Nov 2023 23:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700553581; x=1732089581; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=jLywcSkJVeUVZAMXXk4GKRzHNS5GUGt7XyR9aAX8XtQ=; b=eIqFNRGh2rzHRCvmMM64QSesFBSPFlUsqra8ZICM74NVdHQJ3zXtVtiv /ZdAC1WZb1kf+EsK7QcJqWamO7hXbyvZ9QQPBbV9ZP61NBTHcfZsVbzdp 0wCSnIv13rpUE9azoeSeLp1tNdXK1BxiJRiPChukwZym+/RM4K4quuKyG 58AzzaWs7HtAkNLtC340GLWDbyOBaBc0rU7xyqES4UyHcPuRAIqE75i+a ltsJGIAfHRPODb+e/frHHEzGT28e+vbC1iOh46g3/NTp1Xku6hk4fci/D ELe0WvuXhw4uz8Cwo6MOvjMzEyOBkUoiFz1sa6dfuTqIevzFFrQ1hJ5rZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="456123241" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="456123241" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 23:59:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="742961606" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="742961606" Received: from sbouradx-mobl.ger.corp.intel.com ([10.252.58.80]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 23:59:39 -0800 Date: Tue, 21 Nov 2023 09:59:36 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Yang Li cc: Hans de Goede , markgross@kernel.org, vadimp@nvidia.com, platform-driver-x86@vger.kernel.org, LKML , Abaci Robot Subject: Re: [PATCH -next] platform/mellanox: Simplify bool conversion In-Reply-To: <20231121005557.69324-1-yang.lee@linux.alibaba.com> Message-ID: <4e9d19f-2a51-3286-5b48-ea3dd278c7d5@linux.intel.com> References: <20231121005557.69324-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 20 Nov 2023 23:59:57 -0800 (PST) On Tue, 21 Nov 2023, Yang Li wrote: > ./drivers/platform/mellanox/mlxbf-tmfifo.c:94:41-46: WARNING: conversion to bool not needed here > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7584 > Signed-off-by: Yang Li Thank you for your patch. This is already fixed by the commit 57eb82ff34e3 ("platform/mellanox: mlxbf-tmfifo: Remove unnecessary bool conversion") that is currently queued in pdf86.git/review-hans branch. Also, next time write a better changelog, it's not enough to just quote an error message. -- i.