Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp220746rdf; Tue, 21 Nov 2023 00:08:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQgAzvUHTtcSEsKnOSsV2nTit3Jrx90VGxw+DTHuV/YF100+Yi7sYVbg/Vu5qEjmzzgPAN X-Received: by 2002:a05:6a20:441b:b0:18a:fad3:9a68 with SMTP id ce27-20020a056a20441b00b0018afad39a68mr341117pzb.27.1700554107791; Tue, 21 Nov 2023 00:08:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700554107; cv=none; d=google.com; s=arc-20160816; b=jEMxjigV2Re96ncmPHmyO/vANGTQyu87LSAjEVI5vIIvenWvL9Otk8TEGd+5tHrTcm lZLkndyq4dKHW5bRZpdqTuZnEemIuEeeL82R9VfbRg92AUjx4GMS3OMuQIi79afCVxdO CBiKgWnmAcWxgBI14A5bqjxJZ3OF86MRFC0AJwkFiUpMYYQ3uzDXhYLdvHw5HGlbJ9xx l+YfvHb7CbA2BIfpTDYEiYprhu4CsiHT3F/q+jW8fZxcc2Rg3Q0rZwD2q00HetPD88nF qDmvB+j7Cr6DfQqop8GzKPkdrAERPw5/WexeXfoa7+T3pwK7YRPvUK/vzQmQ9twi4BDe of1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jf+53p0cUnIftIk+ASeTKKaKfYbhgr6GsCD4UJuoI4M=; fh=1IjIKe6s7h4dZGIHZU2Q8ndUh5AzRh2j1w8D84q3XwM=; b=n68snU/iJPV33chuw3CTc9/Oz9HLpCCuockPgyTuOft6/GIBGe0kdXp5RzL1Q39Hqu gCSF6tyz07Sd6+MOpLJx2xqPXuK/+Cyq/745Th7p2e6mUkV/KzGj9eMuHeh1Y+z/8RKG wLebs8My9QZyHSTpXR8VkGIG4f3kJUSLgyzAWEw3zwXh3TXmNA9FZK7UcPZDh5BBQ5ds evbf0JrHiiT6e3tmtiurtSEl1qDd2rMY6BImvtZzsrfYgkge4Umozpd67f57EbXpI8kX /Vjw4gJ6rzc5CyMX1g2MrKVvI4WaybneWYBsSMJ0UaRMhgMkGKNNoHI+xSGDSHaxK3oh 8wMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id be9-20020a170902aa0900b001ca93040adbsi8919245plb.653.2023.11.21.00.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 00:08:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 092FA803D8E1; Tue, 21 Nov 2023 00:08:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjKUIIO (ORCPT + 99 others); Tue, 21 Nov 2023 03:08:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjKUIIN (ORCPT ); Tue, 21 Nov 2023 03:08:13 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D70BB for ; Tue, 21 Nov 2023 00:08:08 -0800 (PST) Received: from dggpemd200004.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SZH3B6frYz1P8cb; Tue, 21 Nov 2023 16:04:38 +0800 (CST) Received: from huawei.com (10.175.113.32) by dggpemd200004.china.huawei.com (7.185.36.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.1258.28; Tue, 21 Nov 2023 16:08:05 +0800 From: Liu Shixin To: Yu Zhao , Andrew Morton , Yosry Ahmed , Huang Ying , Sachin Sant , Michal Hocko , Johannes Weiner , Kefeng Wang CC: , , Liu Shixin Subject: [PATCH v10] mm: vmscan: try to reclaim swapcache pages if no swap space Date: Tue, 21 Nov 2023 17:06:24 +0800 Message-ID: <20231121090624.1814733-1-liushixin2@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.32] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemd200004.china.huawei.com (7.185.36.141) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 00:08:25 -0800 (PST) When spaces of swap devices are exhausted, only file pages can be reclaimed. But there are still some swapcache pages in anon lru list. This can lead to a premature out-of-memory. The problem is found with such step: Firstly, set a 9MB disk swap space, then create a cgroup with 10MB memory limit, then runs an program to allocates about 15MB memory. The problem occurs occasionally, which may need about 100 times [1]. Fix it by checking number of swapcache pages in can_reclaim_anon_pages(). If the number is not zero, return true and set swapcache_only to 1. When scan anon lru list in swapcache_only mode, non-swapcache pages will be skipped to isolate in order to accelerate reclaim efficiency. However, in swapcache_only mode, the scan count still increased when scan non-swapcache pages because there are large number of non-swapcache pages and rare swapcache pages in swapcache_only mode, and if the non-swapcache is skipped and do not count, the scan of pages in isolate_lru_folios() can eventually lead to hung task, just as Sachin reported [2]. By the way, since there are enough times of memory reclaim before OOM, it is not need to isolate too much swapcache pages in one times. [1]. https://lore.kernel.org/lkml/CAJD7tkZAfgncV+KbKr36=eDzMnT=9dZOT0dpMWcurHLr6Do+GA@mail.gmail.com/ [2]. https://lore.kernel.org/linux-mm/CAJD7tkafz_2XAuqE8tGLPEcpLngewhUo=5US14PAtSM9tLBUQg@mail.gmail.com/ Signed-off-by: Liu Shixin Tested-by: Yosry Ahmed Reviewed-by: "Huang, Ying" Reviewed-by: Yosry Ahmed --- v9->v10: Use per-node swapcache suggested by Yu Zhao. v8->v9: Move the swapcache check after can_demote() and refector can_reclaim_anon_pages() a bit. v7->v8: Reset swapcache_only at the beginning of can_reclaim_anon_pages(). v6->v7: Reset swapcache_only to zero after there are swap spaces. v5->v6: Fix NULL pointing derefence and hung task problem reported by Sachin. mm/vmscan.c | 50 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 506f8220c5fe..1fcc94717370 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -136,6 +136,9 @@ struct scan_control { /* Always discard instead of demoting to lower tier memory */ unsigned int no_demotion:1; + /* Swap space is exhausted, only reclaim swapcache for anon LRU */ + unsigned int swapcache_only:1; + /* Allocation order */ s8 order; @@ -308,10 +311,36 @@ static bool can_demote(int nid, struct scan_control *sc) return true; } +#ifdef CONFIG_SWAP +static bool can_reclaim_swapcache(struct mem_cgroup *memcg, int nid) +{ + struct pglist_data *pgdat = NODE_DATA(nid); + unsigned long nr_swapcache; + + if (!memcg) { + nr_swapcache = node_page_state(pgdat, NR_SWAPCACHE); + } else { + struct lruvec *lruvec = mem_cgroup_lruvec(memcg, pgdat); + + nr_swapcache = lruvec_page_state_local(lruvec, NR_SWAPCACHE); + } + + return nr_swapcache > 0; +} +#else +static bool can_reclaim_swapcache(struct mem_cgroup *memcg, int nid) +{ + return false; +} +#endif + static inline bool can_reclaim_anon_pages(struct mem_cgroup *memcg, int nid, struct scan_control *sc) { + if (sc) + sc->swapcache_only = 0; + if (memcg == NULL) { /* * For non-memcg reclaim, is there @@ -330,7 +359,17 @@ static inline bool can_reclaim_anon_pages(struct mem_cgroup *memcg, * * Can it be reclaimed from this node via demotion? */ - return can_demote(nid, sc); + if (can_demote(nid, sc)) + return true; + + /* Is there any swapcache pages to reclaim in this node? */ + if (can_reclaim_swapcache(memcg, nid)) { + if (sc) + sc->swapcache_only = 1; + return true; + } + + return false; } /* @@ -1642,6 +1681,15 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, */ scan += nr_pages; + /* + * Count non-swapcache too because the swapcache pages may + * be rare and it takes too much times here if not count + * the non-swapcache pages. + */ + if (unlikely(sc->swapcache_only && !is_file_lru(lru) && + !folio_test_swapcache(folio))) + goto move; + if (!folio_test_lru(folio)) goto move; if (!sc->may_unmap && folio_mapped(folio)) -- 2.25.1