Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp227770rdf; Tue, 21 Nov 2023 00:24:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSBtBR3r+vYmuSEKIfihPvMjIDxj95pco651bAqmwcBxQpNypszmKaLkLtAdOhK05VG6Nb X-Received: by 2002:a05:6870:9713:b0:1f0:3b3f:8686 with SMTP id n19-20020a056870971300b001f03b3f8686mr11976011oaq.54.1700555075734; Tue, 21 Nov 2023 00:24:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700555075; cv=none; d=google.com; s=arc-20160816; b=j6jGaFyLWVcRCkGNEqPvNwDE3zkP4GciwufKzanFVXWycOrFUmMDRb99a8nSxF9Cbt G4r+6N5926QJGfndQNu+A3s4Pl8u/mFLdliaE2KXsmBSnkIOwphRbxXl28LsEU2bAabB u91WCS/OU6d3tAUem4chus9ToH3Y3O3msATc3FmDwlVsFvvQpbihOnV2J52CSgKuvZAF SmiI6ma6K0CLxgH5apNh47/2LAnYRSw7Yf0juy/AkcrBtUss1KecAS83YifwPxMFFH0C dT1NkU2CP3zPrZMv21khGOSnl6sAh/I0ILkgu4yDrxzCPdrjIMvfu65QX0o7TWvt3Cpn 9q+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=FCK1g9YM8XFjym+Y1ma/CnG4HTN5lgzW4MRhGnM9Ctg=; fh=X1lxrGLA7V3PBg9NtHG1M9vtBdBLI2mDk4lzNRfgcS0=; b=arQLe9ImovVTk9L/o9sFJr9d3amKkImInmTHawDIfUxPxJovhZ8cSFaRQcE4ZCL/8u Yxz6koAwFf5XghnmZh57CEiPfcdaGBN1D4IqUo9z5FdHBvS8kJt3EaHh2E6gLg7XcHgZ 2qmrOdfFyFmSrSCDszckT2qZIpVq5wBWJvKKz0DtlZPvMOEDZ5+wSKLU4tu8ZpvpNTqY hnzyY6XYCFfRQ2TxGGKkEhnSqVIbWWhJA2/OlC3l9CDxUDXpX2RJOvuuMew4jVXH97Jf S4wMW04YGijCYOKokUIwWuZZWZZBYMg3UCup5CYhTJ8AP0JstpyjNygwAM2U5vy2PObY S0wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=EeiNnOVB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id j16-20020a634a50000000b005a0737404a7si9895551pgl.258.2023.11.21.00.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 00:24:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=EeiNnOVB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 10FB9806AFD6; Tue, 21 Nov 2023 00:22:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229682AbjKUIWN (ORCPT + 99 others); Tue, 21 Nov 2023 03:22:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjKUIWK (ORCPT ); Tue, 21 Nov 2023 03:22:10 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEA44F4 for ; Tue, 21 Nov 2023 00:22:06 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-548ae9a5eeaso6655a12.1 for ; Tue, 21 Nov 2023 00:22:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700554925; x=1701159725; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FCK1g9YM8XFjym+Y1ma/CnG4HTN5lgzW4MRhGnM9Ctg=; b=EeiNnOVB61DSfWZT9NiKt2naE2DONQ3VnXhdeyq1oif3E2uLjHqe8NkhtUTkXNLqQR aqZksBmH+efpSrmqVfxtSsGpLeKixUl9TQyp+AzQeVnYnQ1F6VgUoEA1ysokhZP9hHT/ HP7Oo7nFZ/BjpoBWv7STFJPpRup4sxdefBsI40vk+ThVvb6vWQAIiqTkZbtiAEMER7BI W4acUuzSCi8bTGLQfVNeSJqkqHZ9HOgYurOLetOjYe/NpW5/XUsAWJ4AEaAoqjpDDizt OFHdnIg4nhf7fWm3ID63MP67mjRvtJgMh/v5uXxx2JGnlptz8GwElIVnxL0CWRX4wf5M FAnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700554925; x=1701159725; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FCK1g9YM8XFjym+Y1ma/CnG4HTN5lgzW4MRhGnM9Ctg=; b=AhBznJV7vCf6gQqvUN59rG9k4oMJD779sI71Ot0FwcALEF9KqwLfCqvpweUPRx3GvJ Bk9zn7rPYAWPj7CwsL5lv5l/NdstZGpkRysFMdiWnb+513NnKpNRw+H5is0TojTL3s3e TSqNbyNroXIBXcu/tR+FrFveQjHktizllMd+v4lAd07ALO/hOOvCBjdB7IqjxnXJKitq lejlSffo+WxoIS2cv6ocu8k0hvfgO+iMnTEsdpnXSIopNyKnxj2xHAY0hE20rGkVpLiN e7q9eN1rWZiE1Dp7X00r372IOZZkpYdepub+id3Kt4k2ncfoyxLy2hwXuLXNjecNb5FX ELOA== X-Gm-Message-State: AOJu0YzUmcTDth7UbyLKysU8UjKplNoZM2Vb6LhzCJJcuigxYKNdVZ0h xdLhn6sCTv1G7FOuhBBKbbQd+i/xfAYodwjAl3Fzqg== X-Received: by 2002:a05:6402:4414:b0:544:e2b8:ba6a with SMTP id y20-20020a056402441400b00544e2b8ba6amr463035eda.3.1700554924840; Tue, 21 Nov 2023 00:22:04 -0800 (PST) MIME-Version: 1.0 References: <20231121020111.1143180-1-dima@arista.com> <20231121020111.1143180-4-dima@arista.com> In-Reply-To: <20231121020111.1143180-4-dima@arista.com> From: Eric Dumazet Date: Tue, 21 Nov 2023 09:21:53 +0100 Message-ID: Subject: Re: [PATCH 3/7] net/tcp: Limit TCP_AO_REPAIR to non-listen sockets To: Dmitry Safonov Cc: David Ahern , Paolo Abeni , Jakub Kicinski , "David S. Miller" , linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Francesco Ruggeri , Salam Noureddine , Simon Horman , netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 21 Nov 2023 00:22:23 -0800 (PST) On Tue, Nov 21, 2023 at 3:01=E2=80=AFAM Dmitry Safonov wr= ote: > > Listen socket is not an established TCP connection, so > setsockopt(TCP_AO_REPAIR) doesn't have any impact. > > Restrict this uAPI for listen sockets. > > Fixes: faadfaba5e01 ("net/tcp: Add TCP_AO_REPAIR") > Signed-off-by: Dmitry Safonov > --- > net/ipv4/tcp.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index 53bcc17c91e4..2836515ab3d7 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -3594,6 +3594,10 @@ int do_tcp_setsockopt(struct sock *sk, int level, = int optname, > break; > > case TCP_AO_REPAIR: > + if (sk->sk_state =3D=3D TCP_LISTEN) { > + err =3D -ENOSTR; ENOSTR is not used a single time in linux. I suggest you use tcp_can_repair_sock() helper (and return -EPERM as other TCP_REPAIR options) > + break; > + } > err =3D tcp_ao_set_repair(sk, optval, optlen); > break; > #ifdef CONFIG_TCP_AO > @@ -4293,6 +4297,8 @@ int do_tcp_getsockopt(struct sock *sk, int level, > } > #endif > case TCP_AO_REPAIR: > + if (sk->sk_state =3D=3D TCP_LISTEN) > + return -ENOSTR; > return tcp_ao_get_repair(sk, optval, optlen); > case TCP_AO_GET_KEYS: > case TCP_AO_INFO: { > -- > 2.42.0 >