Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Wu Bo <bo.wu@vivo.com>
To:     Alasdair Kergon <agk@redhat.com>,
        Mike Snitzer <snitzer@kernel.org>,
        Mikulas Patocka <mpatocka@redhat.com>
Cc:     dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
        Wu Bo <wubo.oduw@gmail.com>, Wu Bo <bo.wu@vivo.com>
Subject: [PATCH 1/2] dm verity: init fec io before cleaning it
Date:   Tue, 21 Nov 2023 01:55:28 -0700
Message-Id: <419e7aa58f67d90020512892f7652623e8c9f059.1700555778.git.bo.wu@vivo.com>
In-Reply-To: <cover.1700555778.git.bo.wu@vivo.com>
References: <cover.1700555778.git.bo.wu@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LGRtE2X/rNXFYOOsS5YubsX3M33L89w7KtXvMR74dzL0nUbWKN2GnKqX4jNl?=
 =?us-ascii?Q?wgBFngNSJEzVDsvNL6Jn/r/4fc0u1zCQ8sKGpiJOgWNgd83Pm472+6NksyYd?=
 =?us-ascii?Q?Ylmb1/YuOVY+Qutv5mUNDmvVZrt6YmIEBMdKcku110QwT6jFbkYdniYTH95g?=
 =?us-ascii?Q?kkW7RNAxlcYpWYJejlnB5K4Ofu3KmBjpCWCfidAayzmoZW+t75jzDkQEG00D?=
 =?us-ascii?Q?I4s10mxFaY/tC8aYX4AXJXkxmNxPa5p3SAIftR6pcnJGY1LnBTdurq6BjFym?=
 =?us-ascii?Q?caa/Zr6UrxosjspeR6r2fm4ihKt/i61sD/7FjvY6K/7jpNnpoUZF1h4Fghme?=
 =?us-ascii?Q?0WuWcrC9N+yZrIWpAvtg7CsqjtaJnlqJuKXwhn7TYT+Qd5Rb/REl6KXWjo1h?=
 =?us-ascii?Q?bEs2Uc7xkh45DtZx1YdFQ2blYLxLp2zV4trJcJPyN/aaIURYT6/2sBdur80B?=
 =?us-ascii?Q?mOpfKic/tqGGSQDqgLk6RunKTw3GUTi0rsbGxboz6MqQu7Ct6jzfG4TfVTng?=
 =?us-ascii?Q?+IERJm5fQw+FVPphVOobPPOnzY2o42X8whmjX9jSHWeTUMKnxi4PoL0NXnWB?=
 =?us-ascii?Q?UZrstTETDxQCST7q3MXcWa1A54OgzO+1iQqnnTRPMS2+TaRnAeD6hXliJgTh?=
 =?us-ascii?Q?3FhFkT2XgOIJlDLmIneH+JgRYhx9n1o7mb9SzB4cOdJgOXJUO64XDc8r43yF?=
 =?us-ascii?Q?U852ByA5yLUjS+qeymtiXIwntiOsjxNdw2l0UPV0yzIIhpioIfqw2oagMtIj?=
 =?us-ascii?Q?0QBUdVxTFW8U6/Uj5AGcGvGk0hyZ6ydF78VUG5mKku/XE0QGZkxVG4RTQjUC?=
 =?us-ascii?Q?e6Tp0TSVRH9nc/skJOW9Ssm2EDd4Qz9UwbAGiM9qSwt2MSOhR7s4olvTa9wO?=
 =?us-ascii?Q?PTbYYSj5bWeqQ3s5zA2xciiLIibxrl8rbSD7J21FpYQ6b3d8zcAUohQ6yv2B?=
 =?us-ascii?Q?A96+iAGK7x1HpyKPNTNucOMfd6U3p5/a+m97JLTikyXomBKalTZWyVX46mBm?=
 =?us-ascii?Q?8cFGvQiee1GdL/bQRxWjjOTFXFinfjlyutDXW8C+ok7ibecKTk/2lzzImS2w?=
 =?us-ascii?Q?ydB25KKl3BmOaFyDeAmRc0I0x7sOBX1Izh6sn+c7NddkgdYbeibhq1txk/g0?=
 =?us-ascii?Q?nKZ+7QEZMuHo/c9kJHFPnETb9QFKz0SartfSj6mDT3c13B1X7sFUaJmoguRN?=
 =?us-ascii?Q?GVFqAPjfHx57qGnrQ5jtnEZuvKTws6atlQpUjjzMTBUZYrV3VSQLh45OSKDW?=
 =?us-ascii?Q?cu9k0qIZfVhOs/3xarU1/OXWAQHHBUVLwnNhA7pLR6RDgx78JWrfv8yB4qsB?=
 =?us-ascii?Q?G3iBh3tTMjyHJudJH/PUK1BTS5Ncnjnvau74P9DqnceYTEbD/0tTd065P6fI?=
 =?us-ascii?Q?0GXyUIoau396aOgzdxhtTXSEscK8BFNXbAfk3F10xGTjmS9PKEYgmrn8yNZq?=
 =?us-ascii?Q?ZAhvlmdha9FCLVuInDokrFeYeh++RCv7SQF7FeYIT45+ZAkbb7WcsJv7HQL4?=
 =?us-ascii?Q?Qpw3WWf592rVnfZ6E2oPETseyJdqXZGftKvApFe+jDEyvDO8aFg58+QeKJm6?=
 =?us-ascii?Q?BJvtgw3/nqbYPJxOSGgXa1lq4tPWLZVNmY2XUglo?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7739ea1a-2ffe-4979-ca50-08dbea6e6604
X-MS-Exchange-CrossTenant-AuthSource: PS2PR06MB3509.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 08:46:48.9329
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 21kDYlBMzv3tj0+xmxqKhAppm5qU9rdOoJTApDKOi+Ywub/FNR+nsl1X6yW02DuGNiB4PmNTg1mAru9zztDPJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4127
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 00:47:23 -0800 (PST)

If BIO error, it may goto verity_finish_io() before
verity_fec_init_io(). Therefor, the fec_io->rs is not initialized and
may crash when doing memory freeing in verity_fec_finish_io().

Crash call stack:
 die+0x90/0x2b8
 __do_kernel_fault+0x260/0x298
 do_bad_area+0x2c/0xdc
 do_translation_fault+0x3c/0x54
 do_mem_abort+0x54/0x118
 el1_abort+0x38/0x5c
 el1h_64_sync_handler+0x50/0x90
 el1h_64_sync+0x64/0x6c
 free_rs+0x18/0xac
 fec_rs_free+0x10/0x24
 mempool_free+0x58/0x148
 verity_fec_finish_io+0x4c/0xb0
 verity_end_io+0xb8/0x150

Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 drivers/md/dm-verity-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
index e115fcfe723c..42b2483eb08c 100644
--- a/drivers/md/dm-verity-target.c
+++ b/drivers/md/dm-verity-target.c
@@ -642,7 +642,6 @@ static void verity_work(struct work_struct *w)
 
 	io->in_tasklet = false;
 
-	verity_fec_init_io(io);
 	verity_finish_io(io, errno_to_blk_status(verity_verify_io(io)));
 }
 
@@ -667,6 +666,7 @@ static void verity_end_io(struct bio *bio)
 {
 	struct dm_verity_io *io = bio->bi_private;
 
+	verity_fec_init_io(io);
 	if (bio->bi_status &&
 	    (!verity_fec_is_enabled(io->v) || verity_is_system_shutting_down())) {
 		verity_finish_io(io, bio->bi_status);
-- 
2.25.1