Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Justin Lai <justinlai0215@realtek.com>
To:     Simon Horman <horms@kernel.org>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Ping-Ke Shih <pkshih@realtek.com>,
        Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v11 00/13] Add Realtek automotive PCIe driver
Thread-Topic: [PATCH net-next v11 00/13] Add Realtek automotive PCIe driver
Thread-Index: AQHaF8hx62WvfSwr8k6No036AHxBZLB8twcAgAfUibA=
Date:   Tue, 21 Nov 2023 09:35:02 +0000
Message-ID: <6f765fed07f0455bbc46f86698c1b62d@realtek.com>
References: <20231115133414.1221480-1-justinlai0215@realtek.com>
 <20231116175724.GF109951@vergenet.net>
In-Reply-To: <20231116175724.GF109951@vergenet.net>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

> On Wed, Nov 15, 2023 at 09:34:01PM +0800, Justin Lai wrote:
> > This series includes adding realtek automotive ethernet driver and
> > adding rtase ethernet driver entry in MAINTAINERS file.
> >
> > This ethernet device driver for the PCIe interface of Realtek
> > Automotive Ethernet Switch,applicable to RTL9054, RTL9068, RTL9072,
> > RTL9075, RTL9068, RTL9071.
> 
> ...
> 
> >  MAINTAINERS                                   |    7 +
> >  drivers/net/ethernet/realtek/Kconfig          |   17 +
> >  drivers/net/ethernet/realtek/Makefile         |    1 +
> >  drivers/net/ethernet/realtek/rtase/Makefile   |   10 +
> >  drivers/net/ethernet/realtek/rtase/rtase.h    |  353 +++
> >  .../net/ethernet/realtek/rtase/rtase_main.c   | 2542 +++++++++++++++++
> >  drivers/net/ethernet/realtek/rtase/tt.c       | 2542 +++++++++++++++++
> >  drivers/net/ethernet/realtek/rtase/tt.h       |  353 +++
> 
> Hi Justin,
> 
> Unless I am mistaken, by the end of this patch set tt.c is identical to
> rtase_main.c, and tt.h is identical to rtase.h.
> 
> If so, why?

Sorry, tt.c and tt.h are redundant codes. This part will be corrected in the next version of the patch.
> 
> $ cd drivers/net/ethernet/realtek/rtase
> $ sha1sum *.[ch] | sort
> 9762c7f0fc1acb214d1705905495fad6b902a3c8  rtase.h
> 9762c7f0fc1acb214d1705905495fad6b902a3c8  tt.h
> ccfe889f5ae3b6ecfa0dfba91d30fd7beffd4291  rtase_main.c
> ccfe889f5ae3b6ecfa0dfba91d30fd7beffd4291  tt.c