Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Tue, 21 Nov 2023 04:42:33 -0500
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc:     ivan.orlov0322@gmail.com, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        mathieu.desnoyers@efficios.com, shuah@kernel.org
Subject: Re: [PATCH v1] selftests/media_tests: fix a resource leak
Message-ID: <a0cdd2a9-08db-4b9e-aba4-7837df7fd2eb@suswa.mountain>
References: <71465605-7179-4281-8ec8-80f741e78038@suswa.mountain>
 <20231121093238.5376-1-zhujun2@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231121093238.5376-1-zhujun2@cmss.chinamobile.com>
Precedence: bulk

On Tue, Nov 21, 2023 at 01:32:38AM -0800, Zhu Jun wrote:
> From: zhujun2 <zhujun2@cmss.chinamobile.com>
> 
> The opened file should be closed in main(), otherwise resource
> leak will occur that this problem was discovered by code reading
> 
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> ---
> 
> Hi Dan Carpenter 
> 	
> 	I believe that the Linux kernel code is sacred and should strictly adhere to C code conventions
> 

*sigh*.  You do you, I guess.  This patch is pointless but I don't care
whether it's merged or not.

regards,
dan carpenter