Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <5014f1bf-ee2f-4ea4-a6a1-ea9b0656e157@oracle.com>
Date:   Tue, 21 Nov 2023 10:05:05 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu/vt-d: Set variable intel_dirty_ops to static
Content-Language: en-US
To:     Kunwu Chan <chentao@kylinos.cn>, dwmw2@infradead.org,
        baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com
Cc:     kunwu.chan@hotmail.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20231120101025.1103404-1-chentao@kylinos.cn>
From:   Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20231120101025.1103404-1-chentao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDh6cE1qcDBGd0VUa244QUhxc0E5K3BUcUplMnk3NHBEYnZ4ZFM1WnJJbmtG?=
 =?utf-8?B?cmgydDNXMGpkRFF4T3FyOEY1WEFFOTBPUWtFZkFhbkdGbEVRMmJ2TGl3WGlz?=
 =?utf-8?B?OHVBanJwTzlMMVZoRkl6eVMraitZdXJFL0E3UGR6eWxhWkJkZ3V3VzZGTDlD?=
 =?utf-8?B?bHlVeXo4OXFpbDBQdG14d1pxbHJucTJJelVVSGRVckxKRmthTEZqcmFBVytZ?=
 =?utf-8?B?di91elNEYWc1NldvYWJwcWxnbmROUUZKMXRNaDJuTHE0VGtJT1lOUjVOQVBu?=
 =?utf-8?B?VnI5bFJhdHZsTWVNempMYzlOZWFLNS93QnpQU1pQTmVvOU5XbDkyRDdtclF1?=
 =?utf-8?B?WlNuOGNwSHVaelorWlNWQjN4Z3NhV1hudnBJT014UkdZWGpTeEtzZWZHKzFH?=
 =?utf-8?B?ODVQNFJvZzVEWFpNSWR2R0wxQkVBVXZlSW81MURaVVpTOXVNMzg4bytjd3Ar?=
 =?utf-8?B?RzlVRzZHTUQ2UEtNZmxHTHFKMy9JZWh0RFh0NVlGdnFoWEZ0N2JFTERVcGpX?=
 =?utf-8?B?a1Q3QzF5OWdSR0NDcHV6bUNHS29XWkxjUUQxQXhMS3djR0o0OElZSmkrOTNR?=
 =?utf-8?B?dmx5RGU2YnlCUkFrekZjTnJlSnF6aTZrcDE0Wmp2Ni83bFdkbHRHTGhnWE5y?=
 =?utf-8?B?Z2NJV25qNHR1bVV5QWp5MHNWdEUrQ1Y5L3ZldlB3QmhsNXA5b3lyZHB1NGVT?=
 =?utf-8?B?Nm9GMVRiSHBYSVY5OXA3TmRuNnorZTdJaHRoZ1pwTE9nNjhvb1pZNEFDK0pr?=
 =?utf-8?B?dFFLYWNJNWp0WjZyT0pPcU5oSk5GVEcyTjBtcXB3MUJCc05LODJEOXNNamI0?=
 =?utf-8?B?N2FGMmk1dFhocWdneC95RGMxMVdvMHBaUEtJSHR1RlplZURPNzJ3d2c1ajI4?=
 =?utf-8?B?S0ozb01qWEFLbU00OTkwTEYzdXJhWXhwbkhjSERla3dUdnBncTBrUnVTcytG?=
 =?utf-8?B?cGFYUjRHS0NiOGJYbGczSjhwTlE1ZzdoWmkxb3RubGR0MmZycG04OXgxaHlx?=
 =?utf-8?B?VlVzWFZVbDJYT0RDTVdCRXZlVi9RMDlYTHBqUU8xd3JYRjFKZURHdnFSRVR0?=
 =?utf-8?B?V2xOQW1WdExENmhkQXpYQWwraWQycm9qaGZ3dHpicmUwWGh3SUtyQnROZTFq?=
 =?utf-8?B?TXJWaXZyWktyTHdYZEUxMTRTRi9Pczk2K0o2bXFnRXJQLzhnS0xGbTBiU21l?=
 =?utf-8?B?M3NTRXRvRThUaWVEUWdVanovTlBHTURmQ091YnkwNkVwV3k3ZXNmNkswc1E0?=
 =?utf-8?B?MXNHdmRwZndoZXRUV0lYdTdhMTRwazNDbEhtcWdZZzdqOWJVZ1l3NkNIWjN5?=
 =?utf-8?B?UkZMVFFYanJMZGdqK3NhRDk3b1lnMFNCcDhIc0pvOVlBTCtYMDh4aFlJNVZV?=
 =?utf-8?B?b1d4Y3BWOWRVd2NheHg1NkEwRld5R1pRaEVuM3NXQXUwS3hTQnhoMFp2L0JU?=
 =?utf-8?B?NXZpbDRRL0ozcEVNNXdmRnl4QW14b3hCNFVWalFjbE0zQVdrZk1zY2JZRjg1?=
 =?utf-8?B?Q3dwRTVLRlVjYjFFazBJaXhFL1RkSHQ5LzZNNERsNDJoU3FucE9SZ2xwSndB?=
 =?utf-8?B?aU95UEMrVjJ3VGV6aTNnSFhJbXBSYVhrbVovRzR0SjNSR2xsaWNUZU1Sb0JT?=
 =?utf-8?B?WjRtSDFKMGJyY0Mrc25ZRHJtSCt0Ym9jSmxiN2hlYzhBbE5GcTBjakpWUm9q?=
 =?utf-8?B?OFBab3VUVjBSUXl5a3NUMUFld0M2TkZ0RXptSTBjTkZUMHVmQk5Ic3Y3eE1P?=
 =?utf-8?B?MjNDWi91bm9MY2oxUVU1UVljM1hMQ0hLZ1htNnoyVU9xS3ExYndCeHVkbEhD?=
 =?utf-8?B?NHFIWTR3SUVTY3FnY01uZmJCbkFDcHJ1bjh5YUpZeHp6L0FZbTUvYndIb2RY?=
 =?utf-8?B?M1hyTGVsR2lMU2JrVFNsMmZiUXI3R204R3p5ZjhrSGhLS3FqNEg4QmdBVVd4?=
 =?utf-8?B?Q3lBT0dFWkJHcGRsQk5LcDZGckdma293MDJTYUtaYlovbXlML3l6VStiUDhh?=
 =?utf-8?B?SnlDVHNscVBUU0hMQTZyaTZBOVNrbk12dGhvTEpJVTBNdlE3ZVpLbCtrWGc1?=
 =?utf-8?B?NlZRUXJHMmgzY0JBZC9rellFQjBPYmZvR21GMU9GYXY4dEdRWXp6SDVkUVNY?=
 =?utf-8?B?TkNTQlJQZGtLTjgrZTBzc1ZlU09aWExmb0FkYTVkT2ZycW93WWIraDFZTXdv?=
 =?utf-8?B?WGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?bE1hdDI0UzB2ZVhFV1lFbFJnOWdiYlRTNzlaVkxMMmQ5d2gzVnpZSHF2WTlv?=
 =?utf-8?B?cGNtV3JvdjBrVDk2d21KUzAwVUZLS3U2dkwvd0UrcWg0OHdnOHFzL3ZNTGpJ?=
 =?utf-8?B?MkFMTS9pYno3dWJNYW11M25XNnRjQ0JiTURzMElVTW1Fd2gweEYwOE0zbTFV?=
 =?utf-8?B?Yzk0SjRuWktPTXdWRFpNczNBMU5aZDhmWFVHWkhQdkdVMTA4ek9qOFQ5SWd2?=
 =?utf-8?B?SGFaNE16TzFRNjhyRXNKZzh3b0FFWm0zbVd5S3ZtV3luaXpKbUFFcFBlc0o2?=
 =?utf-8?B?NDl0TEV0Z2NjNVBaWDB2RmRCNkx6UmxzK2xZelBOcU9aYmEwZlNSWkJNT3JE?=
 =?utf-8?B?RXppTWxTUHlhUlJPSkhieWFCRkJIREZJNkxSVTVCMmRpaVpsbGo1Q0pzRkoz?=
 =?utf-8?B?STRtUk9MQzBrenN4eWI1bldkODl6YlZZdUFxTDkweVNYcitLNTAxV0ZoTXpk?=
 =?utf-8?B?L3BRZ0ZPUFVlRG5TSDNzcmVPUHJRL3I4TTZXM1RKeFhGKzhBYVUxS08zT0JX?=
 =?utf-8?B?SW9WYmlhU0VUZEJ2aEtSTFdoOU0xemJrcWVBSjRJZ1h0TjRJOTNSNXhEcklY?=
 =?utf-8?B?RlNvanY1cG5NbUVIOFpEMXdqbVlOWlZndXE1VjZBaE1WZGhwY3N0Tmk0L25E?=
 =?utf-8?B?bmtKa0pwQVpvSFhzdGcrQmQ0M2lhdGR1cTI3L0xmZWRTK25DUFMxRDl0b3NJ?=
 =?utf-8?B?ZzdTTUdieW9JdW5ZcER4bjQzcU9tendHTVFhWE11bFlZaTY1S3V2czJwWU5O?=
 =?utf-8?B?UWQxV2hDUW4wYkVuaVRlMGtQaS93VTVYSEtXR1VJOFo2RDJKOHFqMllqVnM3?=
 =?utf-8?B?YXNMdWVnSzEwRGZ1V21jdS9lMVJPaVM4OU1FdS9Gb0t6bkpKYUtlQU9oeDRu?=
 =?utf-8?B?YXZxNCtieWlrSnJ2ZEdwQU5QSElPdU1XSVhxWXRRUzU2YTUxTmRJc1pYMDJ4?=
 =?utf-8?B?ZFh5NXhQWkVtMFJFNHNsaUhXMWxRNS9UOWQ1UzRyQk9EbjcvUUtzT05FTUMw?=
 =?utf-8?B?K1ZsbTBOOEJYOHIxUW9idCtDTXFZcXFJL1RyV2NiQUFXTXJaR3IzN2ZXZ0Ew?=
 =?utf-8?B?K01jckJHVVMwWFBCZ29yc2U4eXM1b0lHa1RxMmFkQ0liOEZndW4zeEg5UDNs?=
 =?utf-8?B?TU13K1E1eXdBL2t0dWFGN2REVFlFRElOVkpmRVFqZEFVVEkvZm1VVTFIRW04?=
 =?utf-8?B?YzlUaVZOTXZod3piQ3g1U09YOW45TVdST3E4dStzeU1NZ3F2MFJVZ1IxM1oz?=
 =?utf-8?B?QXlhbFJYYlo0OXp5ZkVMQldVRXVWMHlES0FqOXFiTEo2Ryt0OVBzR1lzczJl?=
 =?utf-8?B?akNPbndqVnA0S2VJSXBWRENLKzRtWkRpMGl5RWpOQ0owR3hBU2EwNnVtQVRj?=
 =?utf-8?B?QVJmQ0dlMFNsQ1E9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3861f905-cc1f-4d8b-0cfa-08dbea795804
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 10:05:09.3938
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SPifC1/zvQKFqqhN4u87xuVZdHospMsbhn0wUGvwr/KQtQ4wleIPuLgY9FNZTbxI1BdQRaz4cbhK+P8f0o75bLIzcEKwbfi8CXMVxhDjY6k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5976
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-21_03,2023-11-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311210078
X-Proofpoint-ORIG-GUID: R8rBgCrfwsqU942pjchzzn6JFgE7UP-Y
X-Proofpoint-GUID: R8rBgCrfwsqU942pjchzzn6JFgE7UP-Y
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 21 Nov 2023 02:06:06 -0800 (PST)

On 20/11/2023 10:10, Kunwu Chan wrote:
> Fix the followng warning:
> drivers/iommu/intel/iommu.c:302:30: warning: symbol
>  'intel_dirty_ops' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
>  drivers/iommu/intel/iommu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 3531b956556c..68e4d4006300 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -299,7 +299,7 @@ static int iommu_skip_te_disable;
>  #define IDENTMAP_AZALIA		4
>  
>  const struct iommu_ops intel_iommu_ops;
> -const struct iommu_dirty_ops intel_dirty_ops;
> +static const struct iommu_dirty_ops intel_dirty_ops;
>  
>  static bool translation_pre_enabled(struct intel_iommu *iommu)
>  {
> @@ -4925,7 +4925,7 @@ static int intel_iommu_read_and_clear_dirty(struct iommu_domain *domain,
>  	return 0;
>  }
>  
> -const struct iommu_dirty_ops intel_dirty_ops = {
> +static const struct iommu_dirty_ops intel_dirty_ops = {
>  	.set_dirty_tracking = intel_iommu_set_dirty_tracking,
>  	.read_and_clear_dirty = intel_iommu_read_and_clear_dirty,
>  };