Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <0e1bf1ff-a214-4b73-9a8c-95f997a170b5@oracle.com>
Date:   Tue, 21 Nov 2023 10:05:10 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iommu/amd: Set variable amd_dirty_ops to static
Content-Language: en-US
To:     Kunwu Chan <chentao@kylinos.cn>, joro@8bytes.org,
        suravee.suthikulpanit@amd.com, will@kernel.org,
        robin.murphy@arm.com
Cc:     kunwu.chan@hotmail.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20231120095342.1102999-1-chentao@kylinos.cn>
From:   Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20231120095342.1102999-1-chentao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkZmZXdFZEIxa0VXaTBaT1I2RTdOZlMwZTBHYlduNUc5L0NUc1lNblJBajNm?=
 =?utf-8?B?OFlpTVMzMzNzUGtaaWxHeHc2NFRTd0VIb0hiWllaTGNkVWJaZ3hSUy80c04w?=
 =?utf-8?B?alA2eWVaWHh0WktQV09Yd0szZHE1bzBKUjFkbGdweCt5MUViQ0d5N1c0N3pj?=
 =?utf-8?B?WEZGZE8vMW9nNUk3WDUrZ2s1M0pqUm5xNDVuQW9hZkhkczlrWll5U1VIRCtE?=
 =?utf-8?B?UzVqcXlOcTl1V2tLeTNhVHNrTGF3Ynd3cElRUVlFYmtGTnIvbzJaclpYcFBk?=
 =?utf-8?B?eE03bDZmMzJ0bXJ5S3FvSGk3YmkzSkQrUEFwRDBFM29oanlVNVg5aytqUkNa?=
 =?utf-8?B?ZUpnZHZQNWN5bGNkYUVWKzdrOWVTa0lzRExIOVBUK1FIc0liOGtuZ2xIa3dM?=
 =?utf-8?B?VlUwTXZWRlVWd0lxREZvaUN6cXUyR2xaaXhQNi9mNGMwTkJmRlhUZzdmMmFi?=
 =?utf-8?B?akp3SXR0WHgzS0xBdHJ0WVdlYlRlYVB1QjRIUXZkQ0ZraVhNbjdJYkVVR25i?=
 =?utf-8?B?ZWFFKzZ2dFJoeER3NXRZRitxVXpnTUtYTExJcUlSK1dvSjRlV05qQkZ0M3Ji?=
 =?utf-8?B?bjFKVmRKenFZc3YzMzFWVjh1NElQMHpPVTMwNFMzUkR5T2lyVmc2ZjZCRnBM?=
 =?utf-8?B?bXBjTmhMRXBVQU5Fd1JMVkRKUkpzcnNGZ1QzRSthalZUUXNlWmdabHAxbW1W?=
 =?utf-8?B?MnV0emtuOFI1c0lGSStvMlFsN1NDSEZ5TllRQWVYRDROZVVLbDB4Z3c5cWRU?=
 =?utf-8?B?NUhJT0pDSEFMNjhjN01XbzdLMTlqdE45NTRqUXNlMnEraWJPeUFDeHU0dThJ?=
 =?utf-8?B?MUNHKzlKTk9SSlFobDNVYTMxOGZaQS91aXBVa3lEaVBVWE9WZ0RoN3E5bVZV?=
 =?utf-8?B?VklKUXdJTkUzTFFIUHZzaHZSREFpc0FYUHhJc3ZIaFlSV0UrL2VpTjV5YmNK?=
 =?utf-8?B?ZDhrWDhtV1IvdndVRXBCcDNIY0Rzcnd0Z3BzTVhQR3ZBQlV6b0lEcFUzUTRy?=
 =?utf-8?B?UWg1TUxueXJsS2xoZmo4UERhREJFUnRsUHltS2FXZTJEMXpsUkt3RUxaZ05h?=
 =?utf-8?B?SXJscGRidUVja2VSQTdYaUlCY3lDVTZHWGw4VWRCZDZzOEEyRzluTG84NEFn?=
 =?utf-8?B?cWgxRTdLMzNZYkJJRndISXVMeCtJRDBrL3FBaWZLSjZSQXNqR1lyWmZFeFUz?=
 =?utf-8?B?bUZPMzh5MTdkMWRFeXExd2dLZmVGaGRhb3FRSXNVUGg3aTNpckNtQVhiVW1m?=
 =?utf-8?B?RWtLRm4yQkNrLytiVi8veWlUbEFqYytvRDRiU05CVTl3aS8vUFVKc29xeW9F?=
 =?utf-8?B?ZlNGOTQ5eVY1TnVjdCtxTVR3azJjRkpyT1VHZTdUQzVjMU9iN0dUV3dtNEdC?=
 =?utf-8?B?V3Y1S292NkJuaTZ6QzdjeDZkbXdJeUd3L0R5R1pJc1dGdjJ6NENyUEFzU0g4?=
 =?utf-8?B?VHFpNXE3NWpaenNUd2dwSGZ2bFZNNUloeGJxUDBRMyt4aldXbmZ2YUhYUkZy?=
 =?utf-8?B?VU16WHoyREVpVDlWUi9pMmtqdmpVdTJQWStHelRvQVR0T2J6SkdyVW9RbVhG?=
 =?utf-8?B?QVdkMDVZajNMOEhVVi9iWU5iQUE1UDVBdXgwRDVwQXdXOHBLS1JBb1JMVU9z?=
 =?utf-8?B?cTkrQkJ4bXZVK1J3N0M4YXplN2Rrc1NkaldjL3A1UGd1WTE1VEhVQXZxYVZa?=
 =?utf-8?B?YSt2OHZtcG9Wc3l5NjVPVlhGSUxKRVhFRHpKV2tNeW9lQXhvL3dkNzlMZWM5?=
 =?utf-8?B?OURxbmZzVmpKejllUXJ6R0ZrYXRReU5UenpackxHbzljcVNlaFRrM0t5cWYr?=
 =?utf-8?B?ZDZ0QldWNC9BS2hPMkJQdEtXeXJnc2lKQStGMC9kWFJaUlV1azBMUkd6NGw4?=
 =?utf-8?B?WUNMczMwUHd3Ujh2VVMvb3hkUTMwU0VqREJveGRDNDB5ampvcjJPNlZJRjRa?=
 =?utf-8?B?bFAzcHV1Y0c3WmFubFl4YzAxcTJFR01DOVVESnVmOExoTGUwOTJxeThKQXZT?=
 =?utf-8?B?L0VtWWVQUlFOTHJScDh4Uzdmdy9XMzBJWXpYcW1ieHAwVWtVVzFBdXVLajNN?=
 =?utf-8?B?MkZwYU50SW5uSFpYRnpKTElRWnV1RkYza21samdDaFB3c25aZjJmc2hCQ2VQ?=
 =?utf-8?B?Z3h0UFJqd05Dd01YcHl6Mnk1Y200ejA4OVlKWkhRUnFnS1VzVWJaRmdPZS9q?=
 =?utf-8?B?SUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?L25GejFKR2ZhL0ExcUVLNUdteTBSa0VnL01mTlVQVVBqZUcwZW14czRHRm9K?=
 =?utf-8?B?N2tPUHFYMDh0ZWQwZ0xWUzd2QXhFdlZsdkZCWWRWejdlWTZGWFV5SjF3ekZh?=
 =?utf-8?B?dVB5Skp5OHVhd0lobE5XSFIwT2xqclZsbERpVXY3cXZxSWhKcEZvMHhjZjdV?=
 =?utf-8?B?WHVSMUFqNVlqWHlobHQvanpUQklWVlZaR1ZOT3RuM3RPUWIwQk1NQ0diQ2N5?=
 =?utf-8?B?NXVRRkpneWZPWHR1Z2daUlpBdDRwcVoyek1VU1loSGNTQmVnbUM2czUwZXBN?=
 =?utf-8?B?d1IyQnNhc2p0c2d6a1BUWVdGWENZVUhZa3k4RnViaUViZXdPR2IrQS9WdHh3?=
 =?utf-8?B?anlLK0hUUUxvTUMxbkZEc0JYYVFTQmxjZWJHY0owU0dVL2dXc1Z5cmViNk5G?=
 =?utf-8?B?bFdVSkROYmd4ajByUFZpRXpKZGFMTGFSeVk0bS9GcmtlKzJ6aUlaV09yQVJZ?=
 =?utf-8?B?WGtPRXFLNnhMK3JvWEIyVnBNV09HV0kxOER2cmVsU0dXOU1hbnV3YmhSc1V0?=
 =?utf-8?B?SnpOQjRGdXlTY2RaR3NMOEZIRmFpTXBQL2N6OGM0WHVCb0h2ZXNnQVJkZGt3?=
 =?utf-8?B?SmRXZlo2MElmM1hsR050ZEFQNVk3VGpGNWFnckI5OVlDUWduVmlLeVJXWmd3?=
 =?utf-8?B?dy91YmpXaHpmMVRNMUNvb1ZsOFlPVFcxVFhFQlUvUDQ1T1FZdUgwenEwVmcy?=
 =?utf-8?B?amRXbmphTzY0YWZLZkpLREJ2alRsVkN5YlM3M2dzRlJQcEpPNjNTSkZUVVZ6?=
 =?utf-8?B?cnpuSy9NVFBKNkNjaEloOXIrSGhjSlVDMDBoa242T0d3SExSNU1TSi83bUYw?=
 =?utf-8?B?VzhmSTBXS2QzRmtqd0JZY1pHT240dWgyckNnRnEvL0ZPL1FCSnA4NEp2NGRj?=
 =?utf-8?B?c2tBcHYza3dKR2dCRkNLSU0xcmFWNEgwYmpEbmMzWmxYMXdpcitGUEZEUVB4?=
 =?utf-8?B?UXc1MzVRT3JvUDFIWG9GQjlFYnNjbm5HSlNXQ3BNeTdFZTBZYVJqc3I4Sy9Y?=
 =?utf-8?B?ZjNRMFhNVis0SW1aelhxbTJXNmdFS0VYUmN5eHFaZEdBalNaZ0RKeGdYNkVp?=
 =?utf-8?B?RDQ1bWtnL1ArRC9KNFp5Wkc3TnZONzlKaE8wd1NWTjRicUNpZmxsN0lqNjZ2?=
 =?utf-8?B?K29SeGtEZjVFdGtranhJc1lKWG5GNlF3ZjdhbFpPZzkvd29BYVQ1OE9nL29t?=
 =?utf-8?B?SFhObGFQckVTNDhRektqVFU5a0xPREdXa09YNlUzbWNhMU1iK1dVM1hkY2lq?=
 =?utf-8?B?MmFWSGhWeTF0U0Z4bkpXc1Nia3B0Qm9JcFV2SW9HandLWHprQT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4fc0f46e-9aa7-4737-0c8b-08dbea7959e8
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 10:05:12.5202
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2GhJMnm83aou1eLZSJLbqiTM6XK2jlLpwPMyu4zjgECWs7vDntxKx0P7Cw3/EdONqGQ3coxsM2b6kZvQ0iGCvZy31xURXfXQSgiw+cTR0zM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5976
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-21_03,2023-11-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311210078
X-Proofpoint-GUID: 6vGTq87OgyQKcGcvwaEGQA9TdrafwxPy
X-Proofpoint-ORIG-GUID: 6vGTq87OgyQKcGcvwaEGQA9TdrafwxPy
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 02:05:59 -0800 (PST)

On 20/11/2023 09:53, Kunwu Chan wrote:
> Fix the followng warning:
> drivers/iommu/amd/iommu.c:67:30: warning: symbol
>  'amd_dirty_ops' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
>  drivers/iommu/amd/iommu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index fcc987f5d4ed..9f7064360828 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -64,7 +64,7 @@ LIST_HEAD(hpet_map);
>  LIST_HEAD(acpihid_map);
>  
>  const struct iommu_ops amd_iommu_ops;
> -const struct iommu_dirty_ops amd_dirty_ops;
> +static const struct iommu_dirty_ops amd_dirty_ops;
>  
>  int amd_iommu_max_glx_val = -1;
>  
> @@ -2635,7 +2635,7 @@ static bool amd_iommu_enforce_cache_coherency(struct iommu_domain *domain)
>  	return true;
>  }
>  
> -const struct iommu_dirty_ops amd_dirty_ops = {
> +static const struct iommu_dirty_ops amd_dirty_ops = {
>  	.set_dirty_tracking = amd_iommu_set_dirty_tracking,
>  	.read_and_clear_dirty = amd_iommu_read_and_clear_dirty,
>  };