Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp278988rdf; Tue, 21 Nov 2023 02:28:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGjNjHc57aYt5OAONJgKHQ89d5wsVw03iBfK7oOsrzPIcRvX+BGx/duBXH6vpDpj06lu5AC X-Received: by 2002:a05:6a21:789a:b0:18a:59fa:7da4 with SMTP id bf26-20020a056a21789a00b0018a59fa7da4mr5811474pzc.29.1700562506919; Tue, 21 Nov 2023 02:28:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700562506; cv=none; d=google.com; s=arc-20160816; b=MCd474FXccuJB0kpzwc8x/YadmqZZngahtX6RF+CBVn7nFatWCnh2d2JlRoqFXShS6 Gr/elrsw6HxgYliOPvWVZ5LY/VyBnQcIl2caJU3K2/9krBCQJfHNDzHEAsbjwqD+P5rQ QaR3T3Nj9EYcYYDZy6MHZfnzYg90DgbHtRG0RRhKFIMTj7MSNZwms7fC/o4O5OI9CD+S MEv7BGs2/QMdLOaVStGb+vvW269JiZ12A6SGc0bI+ts7/bG1+EJlvkSkS4h1/UvrqFVy 3MD99qTQR1FjKpYQezZo5/qeJatiwMhCzKe9utEGF/UuTONas3EI0rc+bymqe2QMETVL dgbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=ME8mQZAJfu3KmV5hnIpgicdED11+YLGNGZQG/TCbQu4=; fh=X50ojSvIRD8Vh260WoYB7TfVWc92ITC9yWTDCKjPH3E=; b=knVtW3SGnKek0ZrCu1o8BvxSNBSLJtdNk3+08tK4uwnRhoJoj9VacfVEolPwonX7aA Yi3gFVjywOiMq1pumxrrLPiLsuUQWhf8ICVCO9tBMXJ6tFClS7vkaJMqJI1hlUrzGEi2 Kbx7LumceE/5hPAOjdm28ASeQlqfolIcqgH2daQiJVRy8xOtvLpOdaX8gCkl1WWMzrEd /JljLWpZZPTGjd+U1fjyC69gwSSM4Bjbr2zdcupPMgNvmsDmIOKyy0fSyg3w8WznQ1HK OTws5qPr/LHfH9NnZS9y3IHFhanG+Ha46eP2omjjC0dGKirONH9U5OkoBOSWQWilJ6ak JhTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dKnQzpWm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id sr8-20020a17090b4e8800b002809a033855si10300740pjb.157.2023.11.21.02.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 02:28:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dKnQzpWm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2C31E808D4AA; Tue, 21 Nov 2023 02:28:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231923AbjKUK2Q (ORCPT + 99 others); Tue, 21 Nov 2023 05:28:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbjKUK2P (ORCPT ); Tue, 21 Nov 2023 05:28:15 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3A04BA for ; Tue, 21 Nov 2023 02:28:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700562491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ME8mQZAJfu3KmV5hnIpgicdED11+YLGNGZQG/TCbQu4=; b=dKnQzpWmF7YIzUft8mjpn8raS+FyETjkOS75OsOzZiNyOM/P0mWy0dEjexJJUSDmWtaQSF aRmZ9ucLctEBkRNL9qRYhQbmDHzgbTGYWjjm0m1A6nEqgfA/v/X4PblIR8u6R79sHW2/XM WqQNkV+yR2vaRQXdOzLDG82Uv2t3BOQ= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-jClnGcRLNUCIiz5xh0UteQ-1; Tue, 21 Nov 2023 05:28:09 -0500 X-MC-Unique: jClnGcRLNUCIiz5xh0UteQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-9fe081ac4b8so18747966b.1 for ; Tue, 21 Nov 2023 02:28:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700562488; x=1701167288; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ME8mQZAJfu3KmV5hnIpgicdED11+YLGNGZQG/TCbQu4=; b=HmOvjljxdeIBiTTDq2eh1PmVL7lZdBaY7ww9lnJIymKi8t1A0XWlAQiDDALxjoR5ny J3vSZVMk5iabzfbYtfKlYMFkUO6Ufpc90soJylzYyu0RPMi4wCwXs/tZJIxXnVTPLpYk Sa3WZHPHRGunvsrrxYFHfUrveVriQzj1R3aY2pYX7N8yYg0bVuOPo9ngMpbeBFAS6ICm BnMU5CCJLLgWnDAfOxURIWbI859m18DEwN0jnQVodluV4MMTHo0kH8hgTAIQq4Q8ih5c BKpu7Pm2pdBr4ti0P0s0iKH2z9cToj9Syz8+vewn2WgY4lfVdrt6AOiZWXC1hLMPK4m0 EWCg== X-Gm-Message-State: AOJu0Yz6ROI/aQxUWJulPRRtIlp/r20Al746Iiln3CHDHqZCwB4JvB+p 49DRZ0fiotBcoV2EEdmtmGPsNefmen2Grx+vrtmJzFh6otC/hL8uzMI7Ud+DDBnrlaRU8B7FYIa eb3H1mQo3PIP1LRanrL2jckrm X-Received: by 2002:a17:906:3089:b0:a01:ae7b:d19b with SMTP id 9-20020a170906308900b00a01ae7bd19bmr948654ejv.7.1700562488579; Tue, 21 Nov 2023 02:28:08 -0800 (PST) X-Received: by 2002:a17:906:3089:b0:a01:ae7b:d19b with SMTP id 9-20020a170906308900b00a01ae7bd19bmr948641ejv.7.1700562488281; Tue, 21 Nov 2023 02:28:08 -0800 (PST) Received: from gerbillo.redhat.com (146-241-234-2.dyn.eolo.it. [146.241.234.2]) by smtp.gmail.com with ESMTPSA id qu14-20020a170907110e00b009fc6e3ef4e4sm2993985ejb.42.2023.11.21.02.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 02:28:07 -0800 (PST) Message-ID: <4fa33b0938031d7339dbc89a415864b6d041d0c3.camel@redhat.com> Subject: Re: [PATCH 2/2] r8152: Add RTL8152_INACCESSIBLE checks to more loops From: Paolo Abeni To: Douglas Anderson , Jakub Kicinski , Hayes Wang , "David S . Miller" Cc: Grant Grundler , Simon Horman , Edward Hill , linux-usb@vger.kernel.org, Laura Nao , Alan Stern , =?ISO-8859-1?Q?Bj=F8rn?= Mork , Eric Dumazet , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Tue, 21 Nov 2023 11:28:06 +0100 In-Reply-To: <20231117130836.2.I79c8a6c8cafd89979af5407d77a6eda589833dca@changeid> References: <20231117130836.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> <20231117130836.2.I79c8a6c8cafd89979af5407d77a6eda589833dca@changeid> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 02:28:24 -0800 (PST) On Fri, 2023-11-17 at 13:08 -0800, Douglas Anderson wrote: > Previous commits added checks for RTL8152_INACCESSIBLE in the loops in > the driver. There are still a few more that keep tripping the driver > up in error cases and make things take longer than they should. Add > those in. >=20 > Signed-off-by: Douglas Anderson I think this deserves a 'Fixes' tag. Please add it. Additionally please insert the target tree in the subj prefix when re- postin (in this case 'net') You can retain the already collected reviewed-by tags. Thanks, Paolo