Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp279152rdf; Tue, 21 Nov 2023 02:28:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxnxfXoDlU2hZDo7nC5JwTgKgoouq+jeI7cfaxnk+HqGX6UJ1reLCL99iVmSwYOrlLl3oW X-Received: by 2002:a17:903:41c4:b0:1cf:677d:f8c8 with SMTP id u4-20020a17090341c400b001cf677df8c8mr3607253ple.5.1700562533519; Tue, 21 Nov 2023 02:28:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700562533; cv=none; d=google.com; s=arc-20160816; b=Jho+RMoUsfRCM7GmQ+SvEdTq2y+RYAqMqNx3rqHXs6YQeQEvuggvTkAFHUGT/NN1LJ Xu7FV92fT/xQn3ZwHS1c0iOUWs8o1Xi2ReMKue96U72+MbXs2S0vjepqihvM3ZdJWFo4 R3w1F40rlkbbvsoYrDUmew7hKPnJGMLXvp5nSZ74zxyKLugQTUeq4o9gS24V4loQEFXA wtm/QTiuvgklSb3jrsLjYJTpOvGcHSsB6CJK6Mt/2EvkDLdo6gSKZGug3NZBARK4yYuQ KspVA1ENqd2MDiDz0aQORBHUFdnLNDubuv9sOOD5qeEkxTF899J4AnMmQ2bVAWaJ8qn3 Uxkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=aVRDDBzCiN0yGxEcaavJVtsWWKQ26OPLgFyvV4vi+f4=; fh=FgP9dEYqUSMQGiokshJ3NpMQTCDilMM/Nw4uX4g/zQM=; b=wadL3oDSGAVc4pnYmhCkKkMCbM07PZ1MITFw3UJUH/NqFKYimlCGFp5VrB/FqjLRsV 01glDDSahqqtusR05e5CYSr/E/vvL6RnXtBrHXtGZe/ztj3arh4WPZ3Bz9XvPQZmZs0D VhKBT/AzbfT+a1gymE3+cDLm0O6x0mb/RgoiPQro3bTGSVuErqGOiXkLs4EmrbxWxur2 NLcbQqbmAFdhJJnhsBueaQMRdZkHlc3EFGG8HS19idXxR26upGKb09E2b5o6rtHrEzmj VzouY+SYZwzAf+SlZh2ElNY44u+a8Knzi188xRrOTE8iY2PSfAlGoqWfUfBNATTqAgOB iUjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FgialH4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id c6-20020a170902d48600b001c39f2b4d2bsi10694815plg.438.2023.11.21.02.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 02:28:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FgialH4Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 7230380321F9; Tue, 21 Nov 2023 02:28:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232960AbjKUK2m (ORCPT + 99 others); Tue, 21 Nov 2023 05:28:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229598AbjKUK2l (ORCPT ); Tue, 21 Nov 2023 05:28:41 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB55C11C for ; Tue, 21 Nov 2023 02:28:35 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5079f6efd64so7023560e87.2 for ; Tue, 21 Nov 2023 02:28:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700562514; x=1701167314; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aVRDDBzCiN0yGxEcaavJVtsWWKQ26OPLgFyvV4vi+f4=; b=FgialH4YVIvW0GAAp2t1Ku5/mgp7Bo89k3Hv4r6di9UqBcKFf+diolBx7qqg1I1YXq vxAXDWeqV6hwmycH7w7C9JEIpr/cuSffOBe4ezB8Oi9HMYp2EJSlrXLOl1TSTGjxWp9C tMsziwQCg422J3Z17LbRRoPBJeOomp5sOlhpDAt63v2yiy0Rsq39SwN+pjFQXNXWDiYe XmPFRQSrkwRzubH6yYiA4BTsLHQ3DkY2PhOccgZ3DgNODpf/8VTdoDV431HMHjUqaK3R CWB/OQt3U5dECPiJfolfLndsMPuHvLpBl18Kt32fRSgzpkKkWk5IeMRxn9gEsILKosO+ eqXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700562514; x=1701167314; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aVRDDBzCiN0yGxEcaavJVtsWWKQ26OPLgFyvV4vi+f4=; b=sH7B6RSf9Z0wVLoih2zsK+y1V6fmO76JNfTfeey5MslpW8W3dhibl9rSw4Yi0sdkis wAbGz1LY+3g5APNFowXrlgWgeHmf6687J8XSVHIoGOuRFSKV39S+mzdZy8t2kO5EOqnB UpdPpFuqyNufj43d6io+4yHtO3hRoL+e3Q87NfBemx/stbnMxWcottAdvPOwzCe2Cs/0 0ei76ms87dj91SVs1OQtL1TmbS6h/wOBOfEwo6DZ4WsosTtN3mA6cNrfU1V9PiF247bQ p+NTJMGZ267tQVzGObn2GO0KptVxt5xsJvGATeZFAqrmsvUZwJUJCv6ylgGruR/+vOOc K7oQ== X-Gm-Message-State: AOJu0YyjQITmPUWbVPGRItB5wQoAS8WequXq3Qwc9NJfN+mAU9DWXnDF rGBKARXmanvjkCuRlvkizNVq0g== X-Received: by 2002:a19:384c:0:b0:509:8e9e:a416 with SMTP id d12-20020a19384c000000b005098e9ea416mr5987611lfj.47.1700562513839; Tue, 21 Nov 2023 02:28:33 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.11]) by smtp.gmail.com with ESMTPSA id w11-20020a056402070b00b005489d3b0a58sm2752349edx.55.2023.11.21.02.28.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 02:28:33 -0800 (PST) Message-ID: <6513aefa-b0be-4a29-8c9c-483822217ebf@linaro.org> Date: Tue, 21 Nov 2023 11:28:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] docs: dt-bindings: add DTS Coding Style document Content-Language: en-US To: Dmitry Baryshkov , Geert Uytterhoeven Cc: Michal Simek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Davis , Arnd Bergmann , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Konrad Dybcio , Neil Armstrong , Nishanth Menon , Olof Johansson , linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20231120084044.23838-1-krzysztof.kozlowski@linaro.org> <19358871-009d-4498-9c13-90d5338b1e9f@amd.com> <76fa8f61-fe31-4040-a38d-cc05be3f4f17@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 02:28:49 -0800 (PST) On 21/11/2023 11:13, Dmitry Baryshkov wrote: > On Tue, 21 Nov 2023 at 10:09, Geert Uytterhoeven wrote: >> >> Hi Krzysztof, >> >> On Tue, Nov 21, 2023 at 8:47 AM Krzysztof Kozlowski >> wrote: >>> On 21/11/2023 08:33, Michal Simek wrote: >>>> On 11/20/23 20:31, Krzysztof Kozlowski wrote: >>>>> On 20/11/2023 20:18, Geert Uytterhoeven wrote: >>>>>> On Mon, Nov 20, 2023 at 3:53 PM Krzysztof Kozlowski >>>>>> wrote: >>>>>>> On 20/11/2023 15:01, Michal Simek wrote:> > >>>>>>>> On 11/20/23 09:40, Krzysztof Kozlowski wrote: >>>>>>>>> Document preferred coding style for Devicetree sources (DTS and DTSI), >>>>>>>>> to bring consistency among all (sub)architectures and ease in reviews. >>>>>> >>>>>>>>> +Organizing DTSI and DTS >>>>>>>>> +----------------------- >>>>>>>>> + >>>>>>>>> +The DTSI and DTS files should be organized in a way representing the common >>>>>>>>> +(and re-usable) parts of the hardware. Typically this means organizing DTSI >>>>>>>>> +and DTS files into several files: >>>>>>>>> + >>>>>>>>> +1. DTSI with contents of the entire SoC (without nodes for hardware not present >>>>>>>>> + on the SoC). >>>>>>>>> +2. If applicable: DTSI with common or re-usable parts of the hardware (e.g. >>>>>>>>> + entire System-on-Module). >>>>>>>> >>>>>>>> DTS/DTSI - SOMs can actually run as they are that's why it is fair to say that >>>>>>>> there doesn't need to be DTS representing the board. >>>>>>> >>>>>>> I have never seen a SoM which can run without elaborate hardware-hacking >>>>>>> (e.g. connecting multiple wires to the SoM pins). The definition of the >>>>>>> SoM is that it is a module. Module can be re-used, just like SoC. >>>>>> >>>>>> /me looks at his board farm... >> >>>>>> I guess there are (many) other examples... >>>>> >>>>> OK, I never had such in my hands. Anyway, the SoM which can run >>>>> standalone has a meaning of a board, so how exactly you want to >>>>> rephrase the paragraph? >>>> >>>> What about? >>>> >>>> 2. If applicable: DTSI with common or re-usable parts of the hardware (e.g. >>>> entire System-on-Module). DTS if runs standalone. >>> >>> OK, but then it's duplicating the option 3. It also suggests that SoM >>> should be a DTS, which is not what we want for such case. Such SoMs must >>> have DTSI+DTS. >> >> So you want us to have a one-line .dts, which just includes .dtsi? > > Well, I think it is impossible to run SoM directly. There is a carrier > board anyway, which includes at least regulators. So, I guess, the > SoM.dts will not be a oneline file. Geert claims he has SoM with an USB connector which can run when power is supplied by that USB connector. I can imagine a CPU board (so a SoM in format of a board, not small DIMM-card) which has connectors e.g. for power and a slot for external motherboard for additional, optional interfaces. Look at picture on 14th page: https://www.renesas.com/us/en/document/mat/rza2m-cpu-board-users-manual This looks like some case of SoM, although maybe not that popular outside of Renesas :) Best regards, Krzysztof