Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Tue, 21 Nov 2023 13:55:22 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Manivannan Sadhasivam <mani@kernel.org>
Cc:     Kory Maincent <kory.maincent@bootlin.com>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH v6 0/6] Fix support of dw-edma HDMA NATIVE IP in remote
 setup
Message-ID: <js3qo4i67tdhbbcopvfaav4c7fzhz4tc2nai45rzfmbpq7l3xa@7ac2colelvnz>
References: <20231117-b4-feature_hdma_mainline-v6-0-ebf7aa0e40d7@bootlin.com>
 <20231121062629.GA3315@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231121062629.GA3315@thinkpad>
Precedence: bulk

Hi Mani

On Tue, Nov 21, 2023 at 11:56:29AM +0530, Manivannan Sadhasivam wrote:
> On Fri, Nov 17, 2023 at 11:03:48AM +0100, Kory Maincent wrote:
> > This patch series fix the support of dw-edma HDMA NATIVE IP.
> > I can only test it in remote HDMA IP setup with single dma transfer, but
> > with these fixes it works properly.
> > 
> > Few fixes has also been added for eDMA version. Similarly to HDMA I have
> > tested only eDMA in remote setup.
> > 
> 
> Just out of curiosity, can you share how you are setting EDMA_MF_HDMA_NATIVE?

This topic has already been concerned on v1 (in another context
though):
https://lore.kernel.org/dmaengine/20230621151948.36125997@kmaincent-XPS-13-7390/

Here is the repo with the out-of-tree driver Kory said he was using
together with the kernel's version of the DW eDMA/hDMA driver:
https://github.com/Brainchip-Inc/akida_dw_edma

-Serge(y)

> 
> - Mani
> 
> > Changes in v2:
> > - Update comments and fix typos.
> > - Removed patches that tackle hypothetical bug and then were not pertinent.
> > - Add the similar HDMA race condition in remote setup fix to eDMA IP driver.
> > 
> > Changes in v3:
> > - Fix comment style.
> > - Split a patch in two to differ bug fix and simple harmless typo.
> > 
> > Changes in v4:
> > - Update patch git commit message.
> > - Link to v3: https://lore.kernel.org/r/20231011-b4-feature_hdma_mainline-v3-0-24ee0c979c6f@bootlin.com
> > 
> > Changes in v5:
> > - No change
> > - Rebase to mainline 6.7-rc1
> > - Link to v4: https://lore.kernel.org/r/20231011-b4-feature_hdma_mainline-v4-0-43d417b93138@bootlin.com
> > 
> > Changes in v6:
> > - Fix several commit messages and comments.
> > - Link to v5: https://lore.kernel.org/r/20231114-b4-feature_hdma_mainline-v5-0-7bc86d83c6f7@bootlin.com
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > Kory Maincent (6):
> >       dmaengine: dw-edma: Fix the ch_count hdma callback
> >       dmaengine: dw-edma: Fix wrong interrupt bit set for HDMA
> >       dmaengine: dw-edma: HDMA_V0_REMOTEL_STOP_INT_EN typo fix
> >       dmaengine: dw-edma: Add HDMA remote interrupt configuration
> >       dmaengine: dw-edma: HDMA: Add sync read before starting the DMA transfer in remote setup
> >       dmaengine: dw-edma: eDMA: Add sync read before starting the DMA transfer in remote setup
> > 
> >  drivers/dma/dw-edma/dw-edma-v0-core.c | 17 +++++++++++++++
> >  drivers/dma/dw-edma/dw-hdma-v0-core.c | 39 +++++++++++++++++++++++------------
> >  drivers/dma/dw-edma/dw-hdma-v0-regs.h |  2 +-
> >  3 files changed, 44 insertions(+), 14 deletions(-)
> > ---
> > base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
> > change-id: 20231011-b4-feature_hdma_mainline-b6c57f8e3b5d
> > 
> > Best regards,
> > -- 
> > Köry Maincent, Bootlin
> > Embedded Linux and kernel engineering
> > https://bootlin.com
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்