Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <e5b458fa-c7ad-424d-8416-2947d684b5dc@intel.com>
Date:   Tue, 21 Nov 2023 12:15:30 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next] i40e: Use correct buffer size
Content-Language: en-US
To:     Kunwu Chan <chentao@kylinos.cn>
CC:     <horms@kernel.org>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>,
        <intel-wired-lan@lists.osuosl.org>, <jeffrey.t.kirsher@intel.com>,
        <jesse.brandeburg@intel.com>, <kuba@kernel.org>,
        <kunwu.chan@hotmail.com>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <pabeni@redhat.com>,
        <shannon.nelson@amd.com>
References: <20231113093112.GL705326@kernel.org>
 <20231115031444.33381-1-chentao@kylinos.cn>
 <55e07c56-da57-41aa-bc96-e446fad24276@intel.com>
 <4b551600-f1a3-4efe-b3e9-99cb4536f487@kylinos.cn>
 <2c61c232-1bbb-4cae-bb7f-92a7f2298e97@intel.com>
 <55b77a28-a680-4465-bb57-2a5cb20ce06a@kylinos.cn>
From:   Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <55b77a28-a680-4465-bb57-2a5cb20ce06a@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0t5cnVTcXZvRVF4ak4vMGdZZ21XSXZDZ0JNU21LdE5mcTRMSS9MbjB1YVZB?=
 =?utf-8?B?dmdIdGlyZERTR1pNM2xPRVRjbHNXLzYxaTUzNitNT1dXckZxQ0cvQmxYemQx?=
 =?utf-8?B?cjl2bmJwWnVGWWU4eG9oVWhMOFBMb201a0NlVUM3dVNXcTBmdDJZMmJmNDhD?=
 =?utf-8?B?bkVlbW5wVHZML1FCN2VpUHA3K0RpazRNRU9nNEpLbDY1T0ZlMnQ1THJNVlF1?=
 =?utf-8?B?QndhUUw5bUoxaTN0T3MxNFZxR0VCRGl6YkpXZVpOOC9NVzU2cGtmWkJadlN0?=
 =?utf-8?B?U0dkTUlkc0ZrTXRTNzFvLzBYeCt2N0p6SVFiaTNSazJSbUpuUjVneHVQZjZG?=
 =?utf-8?B?RU4rYkxiTFNEVFJZRDY5bHc0VTdIa2JjSU8xYjJpR3VWamMxbC84VXd3L1ZK?=
 =?utf-8?B?ZlhBNzlYK3AwckpPSWN5SkxwZEZEYjhkZkM2UzdaditjaS9mVlZFNENqYy9m?=
 =?utf-8?B?Z3ZiNGE2dlJTMTBEellKQXRlTmJ5V2ZucnRBY3dOdnNwbjZUQ29Wd1pTckNy?=
 =?utf-8?B?NXZsL0FEckl2dFBibzJzaUt4VjUxWDFIZ2xHUzEya1d4MElkekEwU2wyQ2NL?=
 =?utf-8?B?WW4zYzJobVFuOWdwTThwd3RicllUd3p6TnQxMmpYMWRUMUFTVktVN2dZNFFF?=
 =?utf-8?B?U2daYWlscjdlRzB1K0tIbGdJY2N3OUZkdnZZeUUvRENHQ2VqTUtKdVYxWUVy?=
 =?utf-8?B?VHM2TzB4OUdOR3VQNnhqRlJIRTFwZzI2Z0w1aVRmK1Nhb2FsZTVzc2JibkF6?=
 =?utf-8?B?SWNIK0hUV3ZxVzNsRkUvRVJBSDQyWWRNTWJTV0ZzeUpvd3FVMUJUKytCWWg3?=
 =?utf-8?B?a05BaEM3akt5d0o4RHdQdTJTWTFOb3NKSVJMd2VVKy9WQ1VhRFBHbG9BUVZk?=
 =?utf-8?B?VHEyWHU5L25yb2V2V2czc21FQlJJSDF2bm1FV0R6VlhNWkJSaCtxSkp2cjJh?=
 =?utf-8?B?T2R0NlQ0QmFoUXUwWTdWbFNwMjF5a2NaakZ0TXJQUlhVeWtkd29idnVFaFRh?=
 =?utf-8?B?MkYrcUd0bGk5T25hSy9EbnpKMGdPMDl6ZXR6MXcvMGR0WjlHd2lCU3ViYm1k?=
 =?utf-8?B?Q3BkM1FidnlEbGRKQXMvd3pLMXQvbEk0VCs3K0FJeTB4Qk5PSlJlZ3liK3FV?=
 =?utf-8?B?dEd6T3hoczlOQmRPWVhyUGxtcGg2K2xLNktyaENmNFY2V2ViaXdvVXlmRm03?=
 =?utf-8?B?VndkeTdLcjFtbmMxWFBWSS9aTmllUkVFcXgvaENPVVRjYWF2VHUxQ3EyWWxm?=
 =?utf-8?B?RjBwUnVyYndPdnJ0TXFENCtHT0kzbGpncUpSN1JnSFdndm9oNTRTKzk3TWkr?=
 =?utf-8?B?VFlLMkRpYmsyeTlHOU5kUXl4L2RaMEJGbXB1ZVFsNGszcWs2enJBN3FwWDkr?=
 =?utf-8?B?SWUvRWx6Zk9wVmxkTkkwUlBUYU44eDNsK1BIZTBMM1FURGlFTUFiN0ZCemJj?=
 =?utf-8?B?WmRBVnlkclBhTlRtcEtQWkxuSm1YWVU5L0c5SUpNVjlwTnVSU3FLNVAwL2J6?=
 =?utf-8?B?N3ZXZzRVcERtYk50WXUydFBnQmJhWHYveW1NU2hhNVBLa3lCLzdTeU8xUWoz?=
 =?utf-8?B?MXgvdEs5QkZQWWVudHk5K0ZzSjQvQ3RlVzhPcjRKMmhrV0tlMDlnbjRZMXFE?=
 =?utf-8?B?Vkt5TXJiY0xiZG56bWNoOS96ZmF2Zk5tclg2MXRDQnArd2dyR3lDVnMrdUNB?=
 =?utf-8?B?T3lxZXEwSnFsdHF1NENzSXVFRmE1alFNQmNra1V6RWVzY1pNQTd0OVZIWUhS?=
 =?utf-8?B?Q3U1R2I4MUYxK052WkpvTElDR2FtNktsNmFTTXBnT3ZTZ05DYXg3RXZ6L3ZF?=
 =?utf-8?B?c1lrUDNodWNvTnZ4TytxZ0cyL2xWSkFCR0tYZUV6ZmYzVXcwaTRiNWU3QVZW?=
 =?utf-8?B?eGwrTnFLWCt1ZTUvK2xJbjlhMXh0YlFNYVpNcjJMNE5CMmVEUkJHUGtJdzIz?=
 =?utf-8?B?TXJKV0xDSUt0TS9xa2xRdGpWeGtCZmZ6cGVyVExMUzVHa2lKbHpqWVJsK01I?=
 =?utf-8?B?UU5LNzRRcjNLSFBKQTJNRDd2NWhENDk5aUVIODlsazNUY1ZPbytaTnY4MzU1?=
 =?utf-8?B?ZjZPbWtzTEZVSTYyM0tVM1RiOElhZUhpcytxa0ZtVWdRQVJBWHBvemtiSWxI?=
 =?utf-8?B?dWJBZHlpT0NrQ2kyTHdpUDA4YnZTZHg3NW5QWnU0amxMUzlTeS9XbUo5YXFo?=
 =?utf-8?B?Y0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b855b5f-f594-411d-fa2c-08dbea8339b5
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3625.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 11:15:53.5685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rvoFpLc3GdQEwuuqsphnf/twhzW/Q6Mqky+6GELkc4lM8BUWMxhQ7ShUSnbczxN+QmkUAo6os2h8R4LK0bSul/Te+Stw+6t182POpwgkyXE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8478
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 21 Nov 2023 03:16:36 -0800 (PST)

From: Kunwu Chan <chentao@kylinos.cn>
Date: Tue, 21 Nov 2023 10:12:17 +0800

> Thanks for your reply. I understand what you mean, i.e. the caller of
> 'kasprintf' is responsible for calling 'kfree' to free up memory.
> 
> My concern is that in many scenarios, the requested memory will be
> released after a period of use.
> 
> Has anyone else forgotten to free up the requested memory when using
> 'kasprintf'? e.g. 'dam_heap_init' calls 'dma_heap_devnode' to allocate
> memory:
> dam_heap_init
>     -> dma_heap_devnode
>           -> kasprintf
>             ->kvasprintf
>                  ->kmalloc_node_track_caller
>                   -> __kmalloc_node_track_caller
>                       -> __do_kmalloc_node
>                           -> kasan_kmalloc
> 
> 
> There is no function like 'dam_heap_exit' to free the memmory allocated
> by dma_heap_devnode.
> 
> Another case is 'cpuid_devnode'. Will this cause a memory leak, and is
> there a better way to avoid the memory leak in this case?
> 
> Or is there a uniform place in the memory management module to free up
> this memory?

If the lifetime of the allocated buffer equals to the lifetime of the
kernel, i.e. it's allocated once at kernel init and then used throughout
the whole uptime, there's no need to free this piece.
Temporary buffers or buffers allocated from a driver are a different
story, their lifetime is shorter, which means you always need to
manually free each of them on exit.

> 
> Thanks,
> Kunwu
Thanks,
Olek