Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp305092rdf; Tue, 21 Nov 2023 03:21:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGkyZBAgtc+AT9+U/I9X1tKBtsPtnCuGWyxUyVk9h6u0rnKIaa4XJagqTKrOZLOn+JoA8aU X-Received: by 2002:a17:90b:1b11:b0:27d:661f:59ac with SMTP id nu17-20020a17090b1b1100b0027d661f59acmr8159191pjb.38.1700565663597; Tue, 21 Nov 2023 03:21:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700565663; cv=none; d=google.com; s=arc-20160816; b=Kr0EBKBodrfwvVRHjWHojDXlpQJ7AIZYcBOExCYiNs/pVdgAH20nNm6c6y7+hWJH6d OxT3pvaO5Jvh1w92YmiH6lwL5xgidqpGltkHHSHkzubdXsII0NBE38aPxRWJVSTTbEd5 +ejGGi8V1dNCh1MONaatCE4u7iNj9tgsHa9BE5aUECB9v5AKnin4bmpb+s4UBu2olc7p +4JYWUgeMa7hkPsUmf4Zw9l8OUVF/1GbMrRFp5mgNqQCytuaQxm86plsRA/5eOTiWuYF 5866h7CUWdy6qlZcxOIKZ//3zMph8djtARVHncy7R2gMiodHTBkDPaY/GsqtP6DdolLI 7+DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:message-id; bh=dHtu2kRGZ0LH/N1X/PWWwv28B3GR8jL1BL7Ou5Resek=; fh=9306A/hgJuTg3+xRtFoErWtTvqSrMRL08f6A29TPMJE=; b=mfCj7RFZseOal8SuasfE126H+nhDkzW9/eNxaKoprTTbQy/+qK78/G6nRLaIEUo5nb 2/cmL17odGsMPZ6fEZztNUeLjpXdMymefP7Mo8LnsqE6QdrXRb0z/8UNYdOtLIQFnrkK hIuq6RQUIqVWgUnHYI4zfcQR29MI/YRUbU0J0Dr7rYR8lNJUJZMsLNQTBSiF61pGkBE0 Uo7iWFIksck8+CuLv8WEM1IwhvC1c5Iun89TZg6Btxf4h0ypVk/bxRMRrNuaDJeV5O1A SpLwX5zphK0EnLQy6BdTgRRlO7hItPesIF6gkeUEpmsJW/Te0RlSplwoEMD3s5CEm/1s t8wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=E4cYMZzx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id bk14-20020a17090b080e00b00283a251c077si7752157pjb.94.2023.11.21.03.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 03:21:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=E4cYMZzx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 5EA6D8049D2E; Tue, 21 Nov 2023 03:21:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbjKULUu (ORCPT + 99 others); Tue, 21 Nov 2023 06:20:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjKULUt (ORCPT ); Tue, 21 Nov 2023 06:20:49 -0500 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [IPv6:2001:41d0:203:375::b6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FF6AA2 for ; Tue, 21 Nov 2023 03:20:45 -0800 (PST) Message-ID: <34cb7d4b-58f8-446e-9259-0a234380213c@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700565641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHtu2kRGZ0LH/N1X/PWWwv28B3GR8jL1BL7Ou5Resek=; b=E4cYMZzxGTT+jZuSXOCoi6zxlnj9qBGTVtIOSMsTXn360AHqjKYPwfZKL2zlb4b0riYh+e +RoFh7jo2nNMUZQ5R+Um4UO4WeKvyIeaavqHdRgsyFp3WZN5U1E3QWSHIKTGE6l9zdND5i GVBme3DO7/FqpqE+2p8TnktcHUfUA+Y= Date: Tue, 21 Nov 2023 11:20:38 +0000 MIME-Version: 1.0 Subject: Re: [PATCH v2] dpll: Fix potential msg memleak when genlmsg_put_reply failed Content-Language: en-US To: Hao Ge , arkadiusz.kubalewski@intel.com Cc: jiri@resnulli.us, michal.michalik@intel.com, davem@davemloft.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <0c6e0cd5-d975-41cc-824e-10b5e28251a2@linux.dev> <20231121013709.73323-1-gehao@kylinos.cn> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20231121013709.73323-1-gehao@kylinos.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 03:21:00 -0800 (PST) On 21/11/2023 20:37, Hao Ge wrote: > We should clean the skb resource if genlmsg_put_reply failed. > > Fixes: 9d71b54b65b1 ("dpll: netlink: Add DPLL framework base functions") > Signed-off-by: Hao Ge > --- > v1 -> v2: change title due to add some similar fix for some similar cases > --- > drivers/dpll/dpll_netlink.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) Thanks! Reviewed-by: Vadim Fedorenko