Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   Lukas Funke <lukas.funke-oss@weidmueller.com>
To:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
Cc:     Lukas Funke <Lukas.Funke@weidmueller.com>,
        Lukas Funke <lukas.funke@weidmueller.com>,
        linux-kernel@vger.kernel.org
Subject: [PATCH] extcon: usbc-tusb320: Set interrupt polarity based on device-tree
Date:   Tue, 21 Nov 2023 13:48:44 +0100
Message-Id: <20231121124844.872238-1-lukas.funke-oss@weidmueller.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0kPvhCAjUNPcVRgD5s4W4EfzLBnbvs3PILxwXEY3roi4ucvKigUl7v8LRtTT?=
 =?us-ascii?Q?k8H3t9l16cql1AOd5yoW7JfB18d9WecRU9/sSQqvIVxwFz2tsBKYwQKIGIZ6?=
 =?us-ascii?Q?C/t8XbeurMfr1xYkBRBtqvQzYQe9sPDvcLiwrfair4S6F91GQwP7Uhc7lA9W?=
 =?us-ascii?Q?sIMPD3uvukcTB6wPXtWyReWKv+0I6U1bXsEVbkks9FxN0l/UnjBc5L12Bp+5?=
 =?us-ascii?Q?Y9pnDAKIxVW8hLUb4CCgCHsrDDZr0dTOueRfdrM4+P5WoQXhjxkfp05/897K?=
 =?us-ascii?Q?8YwfJG/+khA6RWe8JMk0Es2TbbF2UmXdoMlxnXNBixtQLJPMBq11AvV0emIe?=
 =?us-ascii?Q?tsrLPhUtnuYwPJmEJXjGxjV81YQG7RGEOYh0w5EDSQtHBdolJOdj3+i6BGaq?=
 =?us-ascii?Q?CQCsLB4G8aKweyP2Pf7QpxJI+QJ82xEF6BRLU6D5nY/ZWrEdutaFOzoNWM4O?=
 =?us-ascii?Q?kupusoq9rpyGiykwXLLHTU4w9RG5QBAIeBvMbYr2PKjcPgom4++NARE7ZGhZ?=
 =?us-ascii?Q?UQgqIa1ssdunM/I2pzvNlGPi8c2i0yLveTCSBEtZ7EpAWPLsewFos2yvoyBD?=
 =?us-ascii?Q?ubnP9PEwbwTpW5LPnX+924sETYkNsYWNEI1uf4zB/ADUL2M8+kDBAzH0j2tH?=
 =?us-ascii?Q?d8fFmJL2XJasGVjQKMkBjir9Er4seVpBzApja+H6ZYpeyl9Im3/xzifHTZ6f?=
 =?us-ascii?Q?1FJwx/jJbRm29TvTAhrWOheZ7c/FvgGMQpjJpLaXOFPKm1kCFMXIOKA3m0LC?=
 =?us-ascii?Q?YP2GR0JhJGibVKEgfnREa6IlE+W+8cdBDFC0ZwVoo9QUMBtQ+Y6ztH95TZvD?=
 =?us-ascii?Q?rlI9ENo86gSb8Z0+sVdwohsNudm0QnYEsnqi2Zx0DLSpSpOheoo7MwzSYgGK?=
 =?us-ascii?Q?814QvFCcoRUGZuxairhRAvBo8TRMfezSMOcG+CNMSQSJPXY0rJCSBV/r2J1x?=
 =?us-ascii?Q?pGWvbF1/ufvOKlJBmXR2LitkQY+XXXjujiB+FpFVKGQwTh57+7M/zjvyTlKv?=
 =?us-ascii?Q?bpZuxJmqKAXfyhLXTWUH1LYgKKGlP8QVsD/+F72cHG7QwfTGM4PUw8w+u0+V?=
 =?us-ascii?Q?MQpoorzbfj0UPbZ1HN4+vWBiIVmBNlAG/DiklfxGyKjg63NDUcGT0zwpRvk6?=
 =?us-ascii?Q?rcKD7LnRzqDo+DBFIDwem36VAxUhRPqqWagI4F33zeZUH3jn/rLxs3wILXGC?=
 =?us-ascii?Q?NY3x8AMWUreud65K+m597DMG8liagbwOBuIoEkUsUvskjEP0op91iusfj+54?=
 =?us-ascii?Q?wJt8GbDOh70aQT80FtHTxkI5EpX3PhDevJaIuCLmAD/tK2/k49gqCM93E/QV?=
 =?us-ascii?Q?/LDYeyWeavtgteIh8HFKI30aHUtKxf/Gw9InsXbqpqrZbwffDL8CT6nxfF3+?=
 =?us-ascii?Q?q4N4EFrzBiO/ECRXeWqUofI9RwXWe+erf2ckga4r3M/jKehrxnpg2W0rfoTS?=
 =?us-ascii?Q?pns9W7DeQS0w/PVmnDeoYQ/h/Hsh7Egn4e4XGVilXMKBA6ZfsfGWcjb1amPD?=
 =?us-ascii?Q?yNkP0STfgnwZ2vEiX3Dd0R55E9KoDnBtTGH5ixgXBJSA45TInv7+VulTmFZu?=
 =?us-ascii?Q?p4XXqB7VjFObvQdGktlOuJbv4viGsPK/aNQcfBwfOqGLJIG6xf2mO7nkcd6r?=
 =?us-ascii?Q?mw=3D=3D?=
X-OriginatorOrg: weidmueller.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a52c4ed-49fe-46b5-0158-08dbea90372c
X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB8431.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 12:48:52.6051
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GfGkvXwYBBQdSJtZ2t9i7Py9e5tqTnbLHAsS92hm8C3q5K5ac4jgPkw12Js/exUuMifmn5w1wgbj7HLD4444/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6440
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 21 Nov 2023 04:49:12 -0800 (PST)

From: Lukas Funke <Lukas.Funke@weidmueller.com>

Remove 'IRQF_TRIGGER_FALLING' request which is not allowed on
every interrupt controller (i.e. arm64 GIC). Replace flag by a 
request that depends on the actual device-tree setting.

Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
---
 drivers/extcon/extcon-usbc-tusb320.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/extcon/extcon-usbc-tusb320.c b/drivers/extcon/extcon-usbc-tusb320.c
index 4d08c2123e59..f7d699a90f72 100644
--- a/drivers/extcon/extcon-usbc-tusb320.c
+++ b/drivers/extcon/extcon-usbc-tusb320.c
@@ -515,6 +515,8 @@ static int tusb320_probe(struct i2c_client *client)
 	const void *match_data;
 	unsigned int revision;
 	int ret;
+	int irq_pol;
+	struct irq_data *irq_d;
 
 	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -568,9 +570,17 @@ static int tusb320_probe(struct i2c_client *client)
 		 */
 		tusb320_state_update_handler(priv, true);
 
+	irq_d = irq_get_irq_data(client->irq);
+	if (!irq_d) {
+		dev_err(&client->dev, "Invalid IRQ: %d\n", client->irq);
+		return -ENODEV;
+	}
+
+	irq_pol = irqd_get_trigger_type(irq_d);
+
 	ret = devm_request_threaded_irq(priv->dev, client->irq, NULL,
 					tusb320_irq_handler,
-					IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+					IRQF_ONESHOT | irq_pol,
 					client->name, priv);
 	if (ret)
 		tusb320_typec_remove(priv);
-- 
2.30.2