Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp355847rdf; Tue, 21 Nov 2023 04:54:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHF9ZNAGnMTxhfneN55c9i4g3W21CXn342AiN8vMLV0sJElQgGsdn1jcJysQ6qoYs1/d2yp X-Received: by 2002:a17:903:22cc:b0:1cf:636f:1c12 with SMTP id y12-20020a17090322cc00b001cf636f1c12mr5136075plg.49.1700571299503; Tue, 21 Nov 2023 04:54:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700571299; cv=none; d=google.com; s=arc-20160816; b=P1hgk3FV9/AcMzMPWxu2eOtEgAzh36AUkIZ05AMWaMzNPbB2HZeCD8lyBfF12FTEGt otds3RB+1d8uXS56cCwKuOekF75RT9jAV1VMjhcoZKYTwAlFfYshcxyuCoOrm034gEta pBIawQqLmROxfO1mXf8GV8CE/hgXUtuJAwqd3E/Agw81v+AoUWc7nDSc1fbl995Ja7YQ /fdt0RPG8mPQO46BGSBDV8LqJIguXGufQnH3E85RZvDrw9WrkM/fx8xJnspF4Tiia7L9 rwxSRbPECLXososrUm2aTUamydqmJMJK1b5Vg1UI23LLiFVBQLmMCP0dHWfnju60ZegE BsLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:cms-type:content-transfer-encoding :date:message-id:in-reply-to:cc:to:from:sender:reply-to:subject :mime-version:dkim-signature:dkim-filter; bh=/RR37xrrSNj8iFkQHAHyLk3LkJuohJb8fMlvgFB2uZo=; fh=gdHtxQJhnRpK8nmYrcuUJQxT7LHcvWGWiCXUpFIy5IY=; b=DdfKohHlZg2nLFzYsUXBW48vh4NeudZ7pg9Uwy0OM7RP9RvITfY5onXtULimW3n1oh x4wKninRkVk0uLNnmg/jxtbHULC4Gy41VZSVg2/qSeBwB6pMZq4WVoZd1raroLTZvwby k/VjtTRgmrT0Hka5nO9J+fqExfLC8n6sZ658xF8v/z+XDnqFA2iZRtCCwRTBRbPzvCa6 F0foEda9goE0/UU8rn1Rh0GJBsm5nxmcHTvx7eZFN5dG9uvhUcAPDLTm05/TKyvbes+F u5m3URVOZERObiCN+tIaW0F2hQPrXsHqeK3CEQGgrK0XI9TOrwHM/CkS4ffpy79pIXSI hOdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=SjKujYea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id j4-20020a170902c3c400b001cc24ff4197si9736808plj.311.2023.11.21.04.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 04:54:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=SjKujYea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E8E0280BB233; Tue, 21 Nov 2023 04:54:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233670AbjKUMy0 (ORCPT + 99 others); Tue, 21 Nov 2023 07:54:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbjKUMyO (ORCPT ); Tue, 21 Nov 2023 07:54:14 -0500 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3312D63 for ; Tue, 21 Nov 2023 04:54:03 -0800 (PST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20231121125401euoutp01fe1df873a8c50077d425599819ffc0e9~ZpIiftnJs2639426394euoutp018 for ; Tue, 21 Nov 2023 12:54:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20231121125401euoutp01fe1df873a8c50077d425599819ffc0e9~ZpIiftnJs2639426394euoutp018 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1700571241; bh=/RR37xrrSNj8iFkQHAHyLk3LkJuohJb8fMlvgFB2uZo=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=SjKujYeaNAz4/scTi1Jge5JP8XT21rc7BdI1CNCKox4+kXHvnmVumfJcAWzT+w7MD UxsGu/HIS3ubV6pby7Uw8i0lykeDtWGGxQYMFYwbNv2BdFqmZEkPFkQx+NIhBcc7X8 D+aiZtA3EfytzWts6X/G5hzdflkvUsYSeTuKL8Hk= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20231121125400eucas1p1dd5586b9b196195765e9e3ba8997e390~ZpIiEjmvR3153731537eucas1p1J; Tue, 21 Nov 2023 12:54:00 +0000 (GMT) X-AuditID: cbfec7f5-853ff70000002550-be-655ca8684175 Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 3C.4E.09552.868AC556; Tue, 21 Nov 2023 12:54:00 +0000 (GMT) Mime-Version: 1.0 Subject: Re: [PATCH v5 8/9] thermal: exynos: use BIT wherever possible Reply-To: m.majewski2@samsung.com Sender: Mateusz Majewski From: Mateusz Majewski To: Lukasz Luba CC: Bartlomiej Zolnierkiewicz , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , Krzysztof Kozlowski , "Rafael J. Wysocki" , Daniel Lezcano , "linux-kernel@vger.kernel.org" , Amit Kucheria , Zhang Rui , ALIM AKHTAR , Liam Girdwood , Mark Brown , Marek Szyprowski X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <96565d08-8d6b-4a37-8a83-90bdd53ba89a@arm.com> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20231121125400eucms1p40c19eedff56881e1a1a9f1560ac9a2d9@eucms1p4> Date: Tue, 21 Nov 2023 13:54:00 +0100 X-CMS-MailID: 20231121125400eucms1p40c19eedff56881e1a1a9f1560ac9a2d9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-RootMTR: 20231120145107eucas1p13ed9ea8772346c404d2d7f47d4c80f5a X-EPHeader: Mail X-ConfirmMail: N,general CMS-TYPE: 201P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPKsWRmVeSWpSXmKPExsWy7djP87oZK2JSDbZPkbN4MG8bm8Xh+RUW Ux8+YbP4vuU6k8W8z7IWe19vZbf4dqWDyWLT42usFpd3zWGz+Nx7hNFixvl9TBYLm1rYLdYe uctuMffLVGaLJw/72Bz4PdbMW8PosXPWXXaPxXteMnlsWtXJ5nHn2h42j81L6j36tqxi9Pi8 SS6AI4rLJiU1J7MstUjfLoErY+ecuawFp4Qrzs1fz9jA+F2oi5GTQ0LAROLwtblMXYxcHEIC Kxglun9NYu1i5ODgFRCU+LtDGKRGWMBNYmHLMnYQW0hAUaJz+xs2iLiRxKEXu8BsNgEDiQdv IGpEBFQlrl24ywIyk1lgD6vEhW//mCGW8UrMaH/KAmFLS2xfvpURxOYUsJZ4tHI/O0RcVOLm 6rdw9vtj8xkhbBGJ1ntnoeYISjz4uRsqLiNxcsEyKLtY4uXaS1A1FRLHl0yHmmMusWnuGlYQ m1fAV+L8/nnMID+yAB06f0EpiCkh4CJx8m0SSAWzgLbEsoWvwSqYBTQl1u/ShxjiKDHp+Akm CFtAYs2JOVCLJCS2tjxhhWjlk5i0bTrcszvmPYGqV5U4vmcSM8zjT1puM01gVJqFCOdZSBbP Qli8gJF5FaN4amlxbnpqsXFearlecWJucWleul5yfu4mRmAaO/3v+NcdjCtefdQ7xMjEwXiI UYKDWUmEdwt7TKoQb0piZVVqUX58UWlOavEhRmkOFiVxXtUU+VQhgfTEktTs1NSC1CKYLBMH p1QDU/7b3Cgf8YipzI67RP6V+UkoPbxiGPGxXlqyKyyxrpbluuKjsE3fL6et4necr+fQyGLg oTuFtXH30Vut2//v/z7H73AE9+4fV9PqfBdmzFy3Y/pCtt6jsusrs+STvj698s7k3LT4nkm7 Pfti/rjYXJ3bslOqr+i1r//K7G/GvCuvpuzSUGPdsmEeexnz6ao6br6J2wRf7b1rmzNvSuXc r5sOmfSUWD4UOx5zWnBKSGW//6elHxO9/35YmR1ywtjFJy9076W5TlekBYsm9e6slNhvLv/l fvEf2W/2lwuWWZnflKjbdPz3YWvu4r+BD9ZpSq1fESf7yMT1y7S6r6vOnnv1NodBo+StfbyO /5zL6kosxRmJhlrMRcWJAO2MdeLSAwAA X-CMS-RootMailID: 20231120145107eucas1p13ed9ea8772346c404d2d7f47d4c80f5a References: <96565d08-8d6b-4a37-8a83-90bdd53ba89a@arm.com> <20231120145049.310509-1-m.majewski2@samsung.com> <20231120145049.310509-9-m.majewski2@samsung.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 21 Nov 2023 04:54:51 -0800 (PST) Hi, > > =40=40 -590,15 +590,15 =40=40 static void exynos5433_tmu_control(struct= platform_device *pdev, bool on) > >=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0continue;=0D=0A>=20>=C2=A0=20=C2=A0=0D=0A>=20>=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0interrupt_en=20=7C=3D=0D=0A>=20>=20-=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20(1=20<<=20(E= XYNOS7_TMU_INTEN_RISE0_SHIFT=20+=20i));=0D=0A>=20>=20+=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20BIT(EXYNOS7_TMU_INTEN_RISE0= _SHIFT=20+=20i);=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2= =A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=7D=0D=0A>=20>=C2=A0=20=C2=A0=0D=0A>= =20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0interrupt_en=20=7C=3D=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0interrupt_en=20<<=20EXYNOS_TMU_INTEN_FALL0_SHIFT;= =0D=0A>=20>=C2=A0=20=C2=A0=0D=0A>=20>=20-=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0= =20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20con=20=7C=3D=20(1=20<<=20EXYNOS_TMU_= CORE_EN_SHIFT);=0D=0A>=20>=20+=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20= =C2=A0=20=C2=A0=20=C2=A0=20con=20=7C=3D=20BIT(EXYNOS_TMU_CORE_EN_SHIFT);=0D= =0A>=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=7D=20else=0D=0A= >=0D=0A>=20Minor=20issue:=20the=20if-else=20segment=20here.=20When=20the=20= 'if'=20has=20the=0D=0A>=20brackets,=20then=20the=20'else'=20should=20have= =20them=20as=20well,=0D=0A>=20even=20if=20there=20is=20only=20a=20single=20= line=20under=20'else'.=0D=0A>=20It's=20not=20strictly=20to=20this=20patch,= =20but=20you=20can=20address=20that=0D=0A>=20later=20somewhere=20(just=20sa= w=20it=20here).=0D=0A=0D=0AFor=20what=20it's=20worth,=20this=20issue=20disa= ppears=20after=20the=20final=20patch=20of=20this=20series,=0D=0Abecause=20t= he=20other=20branch=20reduces=20to=20a=20single=20line=20too=20(all=20the= =20interrupt_en=0D=0Aoperations=20are=20done=20in=20the=20tmu_set_*_temp=20= functions).=0D=0A=0D=0AThank=20you=20:)=0D=0AMateusz=0D=0A