Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 21 Nov 2023 13:55:51 +0000
From:   Simon Horman <horms@kernel.org>
To:     Ravi Gunasekaran <r-gunasekaran@ti.com>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, wojciech.drewek@intel.com,
        bigeasy@linutronix.de, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, srk@ti.com
Subject: Re: [PATCH net-next v2] net: hsr: Add support for MC filtering at
 the slave device
Message-ID: <20231121135551.GB269041@kernel.org>
References: <20231121053753.32738-1-r-gunasekaran@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231121053753.32738-1-r-gunasekaran@ti.com>
Precedence: bulk

On Tue, Nov 21, 2023 at 11:07:53AM +0530, Ravi Gunasekaran wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
> 
> When MC (multicast) list is updated by the networking layer due to a
> user command and as well as when allmulti flag is set, it needs to be
> passed to the enslaved Ethernet devices. This patch allows this
> to happen by implementing ndo_change_rx_flags() and ndo_set_rx_mode()
> API calls that in turns pass it to the slave devices using
> existing API calls.
> 
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> ---
> Changes since v1:
> * Renamed "hsr_ndo_set_rx_mode" to "hsr_set_rx_mode" based on Wojciech's comment
> * Picked up Wojciech's Reviewed-by tag from v1
> * Rebased to tip of linux-next
> 
> v1: https://lore.kernel.org/netdev/20231120110105.18416-1-r-gunasekaran@ti.com/

Thanks Ravi,

I confirm that the review of v1 has been addressed.
This patch looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>