Received: by 2002:a05:7412:40d:b0:e2:908c:2ebd with SMTP id 13csp409191rdf; Tue, 21 Nov 2023 06:09:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsMXVKo94wte/1qEvz/Ve2sM1N4iqHzOL40h8avTLehM438Sje3UiqarixBUL53Kp5k98e X-Received: by 2002:a17:90b:38cb:b0:27d:1376:3ae1 with SMTP id nn11-20020a17090b38cb00b0027d13763ae1mr9787440pjb.0.1700575792870; Tue, 21 Nov 2023 06:09:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700575792; cv=none; d=google.com; s=arc-20160816; b=TEyVxIBq5Z4Nd8cD6CCDMd3rmKvUANmmx7R9D8a3cJxe6pPySAk8lTWQSKM3eVvquY skusZs8Qha2sAbexxUC6CG6Y4PPl2zgsb1qGl/qD0tFoiSqNDMLYM50CUjIgGSFTmSdh 4TlHRQBw5hYs4oDiNkg1q2ErtR2alCFQe8z6FQBvXqg6icIgFLNvg1B1sSYJNBg3GxYv G3eq0y8pzSX5tJiH7ZqG3Js71y3iu+xxubN5kIkyvpZLyPcUIC9TSP0oJI3ocCaA8L2+ PgJvaFDWzH6ayqXlJHDB4jXWt5pyL4VzH5LA7EZ/udHlYHr0W3sP3oCS992qWVK8MwQv kOCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pHWgNESgCWoJ2eWcmQxTRzVKaXXjAYN5uUnSam7uW1o=; fh=+6OIeCl1nFEwhaiJrnAaplqrdaXnW3y/xxHkCydXbLI=; b=Hn+gLZm+6BapFFMZ7dnUr//b8ZLNUvEO3BgFa8QUwjQ8/BI9J5ASvchBeuQ7Lul7Ms XzxJLYLsa13FVk52IINMp9E+q4Wfp1p8QXE8XvWuW92JrIzJ8csuE1yUj/LWnnvoMCXc yebJgP9Gd8liTpgH6axsFIobx2RkYn9TugM954i0MQe5WKSJuDfgzvNro0u+FJyWpCnk FK67Zq+qbRQsLqsjXSW29S3oNXkne5bypBSNeKMaD3Uz1mdLQ9lu0YxtGhOdksvXYVEf IYUydAOfTTmU90KBMh45Vn9BUXX9mOv5l0GJwX45IJY62zSu/esKcq7XMI2ge6DndLKH Gm1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VOS1oT+A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id c18-20020a17090a8d1200b00280cc652dd6si13071862pjo.173.2023.11.21.06.09.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 06:09:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VOS1oT+A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DB574811F933; Tue, 21 Nov 2023 06:09:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234076AbjKUOJE (ORCPT + 99 others); Tue, 21 Nov 2023 09:09:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234049AbjKUOJD (ORCPT ); Tue, 21 Nov 2023 09:09:03 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438EA10C1; Tue, 21 Nov 2023 06:09:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700575740; x=1732111740; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=S7FWmcXN79Vx+j4cixX7ygbYhrBJf1bmjbAASxLRWaA=; b=VOS1oT+AvYN/oyzLTQ65zmwmD7T4jnfU6j1oqG49nU2SEeUhiHwQ1xqT Kd/0cKMt8HVt0ccs1uJu1qi1D9h+DnHmoNKiq24kjZcRN/rdTGT1xtl6V Ew9K8oevx+nWo6EEtVoP/24ewcPHbvmFYSwG6oyRiqIuQPAoxvi6x6yC+ Q9gAMyIOcNDoKthF4/mvAuHWeHGSGXTH6dGRlWuzr0vQkzqjvZTtbLb1X bpstuLXAw1zXzyhjKmy7LHvm2vXQG3NXu3MTy/OBArTGVdeKuxY8ej3aM UwHTQnw1teMFTGrUqPeSZ95BFczekpjJEv83KxxVc+y2ROsamxcxGocNK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="382242013" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="382242013" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 06:08:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="766660042" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="766660042" Received: from kuha.fi.intel.com ([10.237.72.185]) by orsmga002.jf.intel.com with SMTP; 21 Nov 2023 06:08:57 -0800 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 21 Nov 2023 16:08:56 +0200 Date: Tue, 21 Nov 2023 16:08:56 +0200 From: Heikki Krogerus To: Paul Menzel Cc: linux-usb@vger.kernel.org, LKML , Hans de Goede Subject: Re: Unplugging USB-C charger cable causes `ucsi_acpi USBC000:00: ucsi_handle_connector_change: ACK failed (-110)` Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 21 Nov 2023 06:09:10 -0800 (PST) On Tue, Nov 21, 2023 at 12:50:43PM +0100, Paul Menzel wrote: > Dear Linux folks, > > > On the Dell XPS 13, BIOS 2.21.0 06/02/2022, with Debian sid/unstable and > Linux 6.5.10, when unplugging the (Dell) USB Type-C charger cable, Linux > logs the error below: > > ucsi_acpi USBC000:00: ucsi_handle_connector_change: ACK failed (-110) > > As this is logged with level error, can this be somehow fixed? > > drivers/usb/typec/ucsi/ucsi.c: dev_err(ucsi->dev, "%s: ACK failed (%d)", > __func__, ret); > > Please find the output of `dmesg` attached. Thanks. The firmware not reacting to the ACK command is weird, but I'm not sure if it's critical. Does the interface continue working after that? Do you see the partner devices appearing under /sys/class/typec/ when you plug them, and disappearing when you unplug them? thanks, -- heikki