Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231121070826.1637628-1-sakari.ailus@linux.intel.com>
In-Reply-To: <20231121070826.1637628-1-sakari.ailus@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 21 Nov 2023 15:13:16 +0100
Message-ID: <CAJZ5v0jgxVR9t604tC6LNOoD5Pv9vyhZNx=LiAcr4OR_C4_PcA@mail.gmail.com>
Subject: Re: [PATCH 1/1] ACPI: scan: Fix an error print in DisCo for Imaging support
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     linux-acpi@vger.kernel.org,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Nov 21, 2023 at 9:33 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> The recently merged DisCo for Imaging support used a wrong printk
> specifier in printing a message. Fix it by using %zu instead of %lu.
> Also use "bits" instead of "bytes" as these are indeed bytes.
>
> Fixes: a6cb0a611273 ("ACPI: scan: Extract MIPI DisCo for Imaging data into swnodes")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/acpi/mipi-disco-img.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
> index cad72d1fc127..7286cf4579bc 100644
> --- a/drivers/acpi/mipi-disco-img.c
> +++ b/drivers/acpi/mipi-disco-img.c
> @@ -533,7 +533,7 @@ static void init_csi2_port(struct acpi_device *adev,
>         if (ret < 0) {
>                 acpi_handle_debug(handle, "Lane polarity bytes missing\n");
>         } else if (ret * BITS_PER_TYPE(u8) < num_lanes + 1) {
> -               acpi_handle_info(handle, "Too few lane polarity bytes (%lu vs. %d)\n",
> +               acpi_handle_info(handle, "Too few lane polarity bits (%zu vs. %d)\n",
>                                  ret * BITS_PER_TYPE(u8), num_lanes + 1);
>         } else {
>                 unsigned long mask = 0;
> --

Applied (with a slightly adjusted subject), thanks!